linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: geert@linux-m68k.org (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: shmobile: clk-mstp: change to using clock-indices
Date: Mon, 28 Apr 2014 17:03:48 +0200	[thread overview]
Message-ID: <CAMuHMdUmSj6FPhDLazoXxZD_nasL_A0NE1_h63+53b9sNHer2Q@mail.gmail.com> (raw)
In-Reply-To: <20140428132641.GA9590@katana>

Hi Wolfram,

On Mon, Apr 28, 2014 at 3:26 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>> +     if (of_find_property(np, "clock-indices", &i))
>> +             idxname = "clock-indices";
>> +     else
>> +             idxname = "renesas,clock-indices";
>
> ...and here in the code? It might also be a tad more intuitive to check

Thanks, a comment never hurts.

> for the depracted binding, and if not found, use the new one as default,
> i.e. switch the logic of the if block. Very minor nit, though.

I think checking for the new one first is the right thing to do.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus TorvaldsH

  reply	other threads:[~2014-04-28 15:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 16:06 [PATCH] clk: shmobile: clk-mstp: change to using clock-indices Ben Dooks
2014-04-15 16:11 ` Geert Uytterhoeven
2014-04-28 13:26 ` Wolfram Sang
2014-04-28 15:03   ` Geert Uytterhoeven [this message]
2014-05-05 22:50 ` Mike Turquette
2014-05-06 11:43   ` Geert Uytterhoeven
2014-05-12  8:31     ` Geert Uytterhoeven
2014-05-12 23:55       ` Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdUmSj6FPhDLazoXxZD_nasL_A0NE1_h63+53b9sNHer2Q@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).