linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: geert@linux-m68k.org (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/15] pinctrl: sh-pfc: Initial R-Car M3-N support
Date: Wed, 14 Feb 2018 14:37:08 +0100	[thread overview]
Message-ID: <CAMuHMdUpEjnNa4kru7mUnvhTu2YoofoopuCvUp=AGdRJqfaNEw@mail.gmail.com> (raw)
In-Reply-To: <1518515162-23663-5-git-send-email-jacopo+renesas@jmondi.org>

Hi Jacopo,

On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi
<jacopo+renesas@jmondi.org> wrote:
> Add initial PFC support for R-Car M3-N (r8a77965) SoC.
> No groups or functions defined, just pin and registers enumeration.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Thanks for your patch!

Looks mostly OK to me.
You do want to compare with pfc-r8a7796.c: all differences not related to
SATA_DEVSL, FSCLK, DU_DOTCLKIN2/3, and PRESET are issues that were fixed
recently in pfc-r8a7796.c, and should apply to pfc-r8a77965.c, too.

That leaves us with very few differences only, but it won't be trivial to have
a combined M3-W/N PFC driver, I'm afraid.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply	other threads:[~2018-02-14 13:37 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13  9:45 [PATCH 00/15] R-Car M3-N initial support Jacopo Mondi
2018-02-13  9:45 ` [PATCH 02/15] clk: renesas: cpg-msr: Add support for R-Car M3-N Jacopo Mondi
2018-02-13 11:48   ` Kieran Bingham
2018-02-14 11:03   ` Geert Uytterhoeven
2018-02-15 15:31   ` Simon Horman
2018-02-16  9:03     ` Geert Uytterhoeven
2018-02-19  2:53   ` Rob Herring
2018-02-13  9:46 ` [PATCH 14/15] pinctrl: sh-pfc: r8a77965: Add EtherAVB groups/functions Jacopo Mondi
2018-02-14 14:47   ` Geert Uytterhoeven
2018-02-13  9:46 ` [PATCH 15/15] ARM64: dts: r8a77965: Add EtherAVB device node Jacopo Mondi
2018-02-14 14:48   ` Geert Uytterhoeven
     [not found] ` <1518515162-23663-2-git-send-email-jacopo+renesas@jmondi.org>
2018-02-14 10:01   ` [PATCH 01/15] Documentation: devicetree: R-Car M3-N SoC DT bindings Simon Horman
2018-02-19  2:52     ` Rob Herring
2018-02-19  9:19       ` Simon Horman
2018-02-14 10:36   ` Geert Uytterhoeven
     [not found] ` <1518515162-23663-4-git-send-email-jacopo+renesas@jmondi.org>
2018-02-14 12:48   ` [PATCH 03/15] soc: renesas: Add R-Car M3-N support Geert Uytterhoeven
2018-02-15 15:34     ` Simon Horman
2018-02-20 10:10     ` jacopo mondi
     [not found] ` <1518515162-23663-6-git-send-email-jacopo+renesas@jmondi.org>
2018-02-14 13:58   ` [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x " Geert Uytterhoeven
2018-02-14 21:22     ` Philippe Ombredanne
2018-02-15 15:38     ` Simon Horman
2018-02-16  9:20   ` Geert Uytterhoeven
2018-02-16  9:36   ` Geert Uytterhoeven
     [not found] ` <1518515162-23663-9-git-send-email-jacopo+renesas@jmondi.org>
2018-02-14 14:03   ` [PATCH 08/15] Documentation: devicetree: renesas, sci: Add r8a77965 Geert Uytterhoeven
2018-02-15 15:47   ` [PATCH 08/15] Documentation: devicetree: renesas,sci: " Simon Horman
2018-02-19  2:59     ` Rob Herring
     [not found] ` <1518515162-23663-12-git-send-email-jacopo+renesas@jmondi.org>
2018-02-14 14:05   ` [PATCH 11/15] gpio: rcar: Add R-Car M3-N compatible string Geert Uytterhoeven
2018-02-20 13:35     ` jacopo mondi
2018-02-20 13:40       ` Geert Uytterhoeven
     [not found] ` <1518515162-23663-14-git-send-email-jacopo+renesas@jmondi.org>
2018-02-14 14:06   ` [PATCH 13/15] Documentation: devicetree: ravb: Add r8a77965 Geert Uytterhoeven
2018-02-14 15:02   ` Sergei Shtylyov
2018-02-15 15:45   ` Simon Horman
2018-02-19  3:01     ` Rob Herring
     [not found] ` <1518515162-23663-8-git-send-email-jacopo+renesas@jmondi.org>
2018-02-14 14:08   ` [PATCH 07/15] ARM64: dts: r8a77965: Add dmac device nods Geert Uytterhoeven
     [not found] ` <1518515162-23663-13-git-send-email-jacopo+renesas@jmondi.org>
2018-02-14 14:10   ` [PATCH 12/15] ARM64: dts: r8a77965: Add GPIO nodes Geert Uytterhoeven
     [not found] ` <1518515162-23663-11-git-send-email-jacopo+renesas@jmondi.org>
2018-02-14 14:13   ` [PATCH 10/15] ARM64: dts: r8a77965: Add SCIF device nodes Geert Uytterhoeven
     [not found] ` <1518515162-23663-10-git-send-email-jacopo+renesas@jmondi.org>
2018-02-14 14:42   ` [PATCH 09/15] pinctrl: sh-pfc: r8a77965: Add SCIFs groups/functions Geert Uytterhoeven
     [not found] ` <1518515162-23663-7-git-send-email-jacopo+renesas@jmondi.org>
2018-02-14 13:59   ` [PATCH 06/15] Documentation: devicetree: dma: Add r8a77965 dmac Geert Uytterhoeven
2018-02-15 15:39   ` Simon Horman
2018-02-15 15:56     ` Simon Horman
2018-02-16  9:01       ` Geert Uytterhoeven
2018-02-16 13:40         ` Simon Horman
2018-02-19  2:58       ` Rob Herring
     [not found] ` <1518515162-23663-5-git-send-email-jacopo+renesas@jmondi.org>
2018-02-14 13:37   ` Geert Uytterhoeven [this message]
2018-02-14 13:53     ` [PATCH 04/15] pinctrl: sh-pfc: Initial R-Car M3-N support jacopo mondi
2018-02-14 14:25       ` Geert Uytterhoeven
2018-02-19  2:57   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdUpEjnNa4kru7mUnvhTu2YoofoopuCvUp=AGdRJqfaNEw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).