[PATCH/RFC 0/5] arm64: dts: renesas: Break out common board support

[PATCH/RFC 0/5] arm64: dts: renesas: Break out common board support

[Geert Uytterhoeven]

	Hi all,

The Renesas Salvator-X and ULCB development board can be equipped with
either an R-Car H3 or M3-W SiP, which are pin-compatible.  All boards
use separate DTBs, but currently there's no sharing of board-specific
devices in DTS.

This series reduces duplication by extracting common board support into
their own .dtsi files.  As the level of support varies across boards and
SoCs, this requires the addition of a few external clocks and
placeholder devices on R-Car M3-W, so the common board support DTS can
refer to them.

  - Patches 1 and 2 add the external audio and PCIe bus clocks on R-Car
    M3-W, which are present in r8a7795.dtsi, and used in
    r8a7795-salvator-x.dts,
  - RFC patch 3 adds placeholders for devices that are not yet supported
    and/or tested on R-Car M3-W, but used on R-Car H3,
  - RFC patch 4 extracts common Salvator-X board support,
  - RFC patch 5 extracts common ULCB board support.

For R-Car H3 based boards, there are no functional changes.
For R-Car M3-W based boards, some new devices are now described in DT.

Dependencies:
  - renesas-devel-20170420-v4.11-rc7,
  - Patches 1 and 2 can be applied as-is,
  - Patches 4 and 5 depend on "[PATCH 0/8] arm64: dts: renesas: Break
    out R-Car H3 and M3-W SiP"
    (http://www.spinics.net/lists/devicetree/msg173820.html).

DTB changes have been inspected using scripts/dtc/dtx_diff.
This has been tested on Salvator-X (both H3 and M3-W).
This has not been tested on H3ULCB and M3ULCB due to lack of hardware.

Thanks for your comments!

Geert Uytterhoeven (5):
  arm64: renesas: r8a7796: Add external audio clocks
  arm64: renesas: r8a7796: Add external PCIe bus clock
  [RFC] arm64: dts: r8a7796: Add placeholders for various devices
  [RFC] arm64: dts: renesas: Extract common Salvator-X board support
  [RFC] arm64: dts: renesas: Extract common ULCB board support

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts     | 341 +-------------
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 522 +--------------------
 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts     | 201 +-------
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 259 +---------
 arch/arm64/boot/dts/renesas/r8a7796.dtsi           | 112 +++++
 .../{r8a7795-salvator-x.dts => salvator-x.dtsi}    | 372 +++++++--------
 .../dts/renesas/{r8a7795-h3ulcb.dts => ulcb.dtsi}  | 243 +++++-----
 7 files changed, 421 insertions(+), 1629 deletions(-)
 copy arch/arm64/boot/dts/renesas/{r8a7795-salvator-x.dts => salvator-x.dtsi} (95%)
 copy arch/arm64/boot/dts/renesas/{r8a7795-h3ulcb.dts => ulcb.dtsi} (96%)

-- 
2.7.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 2/5] arm64: renesas: r8a7796: Add external PCIe bus clock

[Geert Uytterhoeven]

Add the external PCIe bus clock as a zero Hz fixed-frequency clock.
Boards that provide this clock should override it.

Based on r8a7795.dtsi.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 101cd41d693a7ab5..8e2aab8b6b103cc9 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -157,6 +157,13 @@
 		clock-frequency = <0>;
 	};
 
+	/* External PCIe clock - can be overridden by the board */
+	pcie_bus_clk: pcie_bus {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <0>;
+	};
+
 	soc {
 		compatible = "simple-bus";
 		interrupt-parent = <&gic>;
-- 
2.7.4

[PATCH 1/5] arm64: renesas: r8a7796: Add external audio clocks

[Kuninori Morimoto]

Hi Geert

> Add the external audio clocks as zero Hz fixed-frequency clocks.
> Boards that provide these clocks should override them.
> 
> Based on commit 623197b90c7aa97c ("arm64: renesas: r8a7795: Sound SSI
> PIO support").
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

>  arch/arm64/boot/dts/renesas/r8a7796.dtsi | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> index 2ec1ed5f499165ad..101cd41d693a7ab5 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -120,6 +120,29 @@
>  		clock-frequency = <0>;
>  	};
>  
> +	/*
> +	 * The external audio clocks are configured as 0 Hz fixed frequency
> +	 * clocks by default.
> +	 * Boards that provide audio clocks should override them.
> +	 */
> +	audio_clk_a: audio_clk_a {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <0>;
> +	};
> +
> +	audio_clk_b: audio_clk_b {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <0>;
> +	};
> +
> +	audio_clk_c: audio_clk_c {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <0>;
> +	};
> +
>  	/* External CAN clock - to be overridden by boards that provide it */
>  	can_clk: can {
>  		compatible = "fixed-clock";
> -- 
> 2.7.4
> 

[PATCH/RFC 0/5] arm64: dts: renesas: Break out common board support

[Geert Uytterhoeven]

On Fri, Apr 21, 2017 at 2:55 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Geert Uytterhoeven (5):
>   arm64: renesas: r8a7796: Add external audio clocks
>   arm64: renesas: r8a7796: Add external PCIe bus clock

Oops, the above should have had the proper "arm64: dts:" prefix.

>   [RFC] arm64: dts: r8a7796: Add placeholders for various devices
>   [RFC] arm64: dts: renesas: Extract common Salvator-X board support
>   [RFC] arm64: dts: renesas: Extract common ULCB board support

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH/RFC 0/5] arm64: dts: renesas: Break out common board support

[Simon Horman]

Hi Geert,

On Fri, Apr 21, 2017 at 02:55:16PM +0200, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> The Renesas Salvator-X and ULCB development board can be equipped with
> either an R-Car H3 or M3-W SiP, which are pin-compatible.  All boards
> use separate DTBs, but currently there's no sharing of board-specific
> devices in DTS.
> 
> This series reduces duplication by extracting common board support into
> their own .dtsi files.  As the level of support varies across boards and
> SoCs, this requires the addition of a few external clocks and
> placeholder devices on R-Car M3-W, so the common board support DTS can
> refer to them.
> 
>   - Patches 1 and 2 add the external audio and PCIe bus clocks on R-Car
>     M3-W, which are present in r8a7795.dtsi, and used in
>     r8a7795-salvator-x.dts,
>   - RFC patch 3 adds placeholders for devices that are not yet supported
>     and/or tested on R-Car M3-W, but used on R-Car H3,
>   - RFC patch 4 extracts common Salvator-X board support,
>   - RFC patch 5 extracts common ULCB board support.
> 
> For R-Car H3 based boards, there are no functional changes.
> For R-Car M3-W based boards, some new devices are now described in DT.
> 
> Dependencies:
>   - renesas-devel-20170420-v4.11-rc7,
>   - Patches 1 and 2 can be applied as-is,
>   - Patches 4 and 5 depend on "[PATCH 0/8] arm64: dts: renesas: Break
>     out R-Car H3 and M3-W SiP"
>     (http://www.spinics.net/lists/devicetree/msg173820.html).
> 
> DTB changes have been inspected using scripts/dtc/dtx_diff.
> This has been tested on Salvator-X (both H3 and M3-W).
> This has not been tested on H3ULCB and M3ULCB due to lack of hardware.
> 
> Thanks for your comments!

Thanks for tackling this important problem. I have looked over the changes
and they seem nice to me. I would, however, be more comfortable applying
them if they were rested on the ULCB boards.

[PATCH/RFC 0/5] arm64: dts: renesas: Break out common board support

[Geert Uytterhoeven]

Hi Simon,

CC Vladimir (which I forgot to CC initially, sorry for that)

On Wed, Apr 26, 2017 at 10:06 AM, Simon Horman <horms@verge.net.au> wrote:
> On Fri, Apr 21, 2017 at 02:55:16PM +0200, Geert Uytterhoeven wrote:
>> The Renesas Salvator-X and ULCB development board can be equipped with
>> either an R-Car H3 or M3-W SiP, which are pin-compatible.  All boards
>> use separate DTBs, but currently there's no sharing of board-specific
>> devices in DTS.
>>
>> This series reduces duplication by extracting common board support into
>> their own .dtsi files.  As the level of support varies across boards and
>> SoCs, this requires the addition of a few external clocks and
>> placeholder devices on R-Car M3-W, so the common board support DTS can
>> refer to them.
>>
>>   - Patches 1 and 2 add the external audio and PCIe bus clocks on R-Car
>>     M3-W, which are present in r8a7795.dtsi, and used in
>>     r8a7795-salvator-x.dts,
>>   - RFC patch 3 adds placeholders for devices that are not yet supported
>>     and/or tested on R-Car M3-W, but used on R-Car H3,
>>   - RFC patch 4 extracts common Salvator-X board support,
>>   - RFC patch 5 extracts common ULCB board support.
>>
>> For R-Car H3 based boards, there are no functional changes.
>> For R-Car M3-W based boards, some new devices are now described in DT.
>>
>> Dependencies:
>>   - renesas-devel-20170420-v4.11-rc7,
>>   - Patches 1 and 2 can be applied as-is,
>>   - Patches 4 and 5 depend on "[PATCH 0/8] arm64: dts: renesas: Break
>>     out R-Car H3 and M3-W SiP"
>>     (http://www.spinics.net/lists/devicetree/msg173820.html).
>>
>> DTB changes have been inspected using scripts/dtc/dtx_diff.
>> This has been tested on Salvator-X (both H3 and M3-W).
>> This has not been tested on H3ULCB and M3ULCB due to lack of hardware.
>>
>> Thanks for your comments!
>
> Thanks for tackling this important problem. I have looked over the changes
> and they seem nice to me. I would, however, be more comfortable applying
> them if they were rested on the ULCB boards.

tested?

I've pushed a branch for testing to topic/rcar3-dtsi-sharing in
git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH/RFC 0/5] arm64: dts: renesas: Break out common board support

[Simon Horman]

On Wed, Apr 26, 2017 at 10:11:55AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> CC Vladimir (which I forgot to CC initially, sorry for that)
> 
> On Wed, Apr 26, 2017 at 10:06 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Fri, Apr 21, 2017 at 02:55:16PM +0200, Geert Uytterhoeven wrote:
> >> The Renesas Salvator-X and ULCB development board can be equipped with
> >> either an R-Car H3 or M3-W SiP, which are pin-compatible.  All boards
> >> use separate DTBs, but currently there's no sharing of board-specific
> >> devices in DTS.
> >>
> >> This series reduces duplication by extracting common board support into
> >> their own .dtsi files.  As the level of support varies across boards and
> >> SoCs, this requires the addition of a few external clocks and
> >> placeholder devices on R-Car M3-W, so the common board support DTS can
> >> refer to them.
> >>
> >>   - Patches 1 and 2 add the external audio and PCIe bus clocks on R-Car
> >>     M3-W, which are present in r8a7795.dtsi, and used in
> >>     r8a7795-salvator-x.dts,
> >>   - RFC patch 3 adds placeholders for devices that are not yet supported
> >>     and/or tested on R-Car M3-W, but used on R-Car H3,
> >>   - RFC patch 4 extracts common Salvator-X board support,
> >>   - RFC patch 5 extracts common ULCB board support.
> >>
> >> For R-Car H3 based boards, there are no functional changes.
> >> For R-Car M3-W based boards, some new devices are now described in DT.
> >>
> >> Dependencies:
> >>   - renesas-devel-20170420-v4.11-rc7,
> >>   - Patches 1 and 2 can be applied as-is,
> >>   - Patches 4 and 5 depend on "[PATCH 0/8] arm64: dts: renesas: Break
> >>     out R-Car H3 and M3-W SiP"
> >>     (http://www.spinics.net/lists/devicetree/msg173820.html).
> >>
> >> DTB changes have been inspected using scripts/dtc/dtx_diff.
> >> This has been tested on Salvator-X (both H3 and M3-W).
> >> This has not been tested on H3ULCB and M3ULCB due to lack of hardware.
> >>
> >> Thanks for your comments!
> >
> > Thanks for tackling this important problem. I have looked over the changes
> > and they seem nice to me. I would, however, be more comfortable applying
> > them if they were rested on the ULCB boards.
> 
> tested?

Yes, tested :)

> I've pushed a branch for testing to topic/rcar3-dtsi-sharing in
> git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git.

[PATCH/RFC 0/5] arm64: dts: renesas: Break out common board support

[Geert Uytterhoeven]

Hi Simon,

On Wed, Apr 26, 2017 at 10:11 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> CC Vladimir (which I forgot to CC initially, sorry for that)
>
> On Wed, Apr 26, 2017 at 10:06 AM, Simon Horman <horms@verge.net.au> wrote:
>> On Fri, Apr 21, 2017 at 02:55:16PM +0200, Geert Uytterhoeven wrote:
>>> The Renesas Salvator-X and ULCB development board can be equipped with
>>> either an R-Car H3 or M3-W SiP, which are pin-compatible.  All boards
>>> use separate DTBs, but currently there's no sharing of board-specific
>>> devices in DTS.
>>>
>>> This series reduces duplication by extracting common board support into
>>> their own .dtsi files.  As the level of support varies across boards and
>>> SoCs, this requires the addition of a few external clocks and
>>> placeholder devices on R-Car M3-W, so the common board support DTS can
>>> refer to them.
>>>
>>>   - Patches 1 and 2 add the external audio and PCIe bus clocks on R-Car
>>>     M3-W, which are present in r8a7795.dtsi, and used in
>>>     r8a7795-salvator-x.dts,
>>>   - RFC patch 3 adds placeholders for devices that are not yet supported
>>>     and/or tested on R-Car M3-W, but used on R-Car H3,
>>>   - RFC patch 4 extracts common Salvator-X board support,
>>>   - RFC patch 5 extracts common ULCB board support.
>>>
>>> For R-Car H3 based boards, there are no functional changes.
>>> For R-Car M3-W based boards, some new devices are now described in DT.
>>>
>>> Dependencies:
>>>   - renesas-devel-20170420-v4.11-rc7,
>>>   - Patches 1 and 2 can be applied as-is,
>>>   - Patches 4 and 5 depend on "[PATCH 0/8] arm64: dts: renesas: Break
>>>     out R-Car H3 and M3-W SiP"
>>>     (http://www.spinics.net/lists/devicetree/msg173820.html).
>>>
>>> DTB changes have been inspected using scripts/dtc/dtx_diff.
>>> This has been tested on Salvator-X (both H3 and M3-W).
>>> This has not been tested on H3ULCB and M3ULCB due to lack of hardware.
>>>
>>> Thanks for your comments!
>>
>> Thanks for tackling this important problem. I have looked over the changes
>> and they seem nice to me. I would, however, be more comfortable applying
>> them if they were rested on the ULCB boards.
>
> tested?
>
> I've pushed a branch for testing to topic/rcar3-dtsi-sharing in
> git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git.

I managed to test it on the new H3ULCB and M3ULCB baords in Magnus' farm.
No issues detected.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH/RFC 0/5] arm64: dts: renesas: Break out common board support

[Simon Horman]

On Thu, Apr 27, 2017 at 03:32:49PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Wed, Apr 26, 2017 at 10:11 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > CC Vladimir (which I forgot to CC initially, sorry for that)
> >
> > On Wed, Apr 26, 2017 at 10:06 AM, Simon Horman <horms@verge.net.au> wrote:
> >> On Fri, Apr 21, 2017 at 02:55:16PM +0200, Geert Uytterhoeven wrote:
> >>> The Renesas Salvator-X and ULCB development board can be equipped with
> >>> either an R-Car H3 or M3-W SiP, which are pin-compatible.  All boards
> >>> use separate DTBs, but currently there's no sharing of board-specific
> >>> devices in DTS.
> >>>
> >>> This series reduces duplication by extracting common board support into
> >>> their own .dtsi files.  As the level of support varies across boards and
> >>> SoCs, this requires the addition of a few external clocks and
> >>> placeholder devices on R-Car M3-W, so the common board support DTS can
> >>> refer to them.
> >>>
> >>>   - Patches 1 and 2 add the external audio and PCIe bus clocks on R-Car
> >>>     M3-W, which are present in r8a7795.dtsi, and used in
> >>>     r8a7795-salvator-x.dts,
> >>>   - RFC patch 3 adds placeholders for devices that are not yet supported
> >>>     and/or tested on R-Car M3-W, but used on R-Car H3,
> >>>   - RFC patch 4 extracts common Salvator-X board support,
> >>>   - RFC patch 5 extracts common ULCB board support.
> >>>
> >>> For R-Car H3 based boards, there are no functional changes.
> >>> For R-Car M3-W based boards, some new devices are now described in DT.
> >>>
> >>> Dependencies:
> >>>   - renesas-devel-20170420-v4.11-rc7,
> >>>   - Patches 1 and 2 can be applied as-is,
> >>>   - Patches 4 and 5 depend on "[PATCH 0/8] arm64: dts: renesas: Break
> >>>     out R-Car H3 and M3-W SiP"
> >>>     (http://www.spinics.net/lists/devicetree/msg173820.html).
> >>>
> >>> DTB changes have been inspected using scripts/dtc/dtx_diff.
> >>> This has been tested on Salvator-X (both H3 and M3-W).
> >>> This has not been tested on H3ULCB and M3ULCB due to lack of hardware.
> >>>
> >>> Thanks for your comments!
> >>
> >> Thanks for tackling this important problem. I have looked over the changes
> >> and they seem nice to me. I would, however, be more comfortable applying
> >> them if they were rested on the ULCB boards.
> >
> > tested?
> >
> > I've pushed a branch for testing to topic/rcar3-dtsi-sharing in
> > git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git.
> 
> I managed to test it on the new H3ULCB and M3ULCB baords in Magnus' farm.
> No issues detected.

Great! Any objections to me queuing this up?

[PATCH/RFC 0/5] arm64: dts: renesas: Break out common board support

[Geert Uytterhoeven]

Hi SImon,

On Fri, Apr 28, 2017 at 9:04 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Apr 27, 2017 at 03:32:49PM +0200, Geert Uytterhoeven wrote:
>> On Wed, Apr 26, 2017 at 10:11 AM, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>> > CC Vladimir (which I forgot to CC initially, sorry for that)
>> >
>> > On Wed, Apr 26, 2017 at 10:06 AM, Simon Horman <horms@verge.net.au> wrote:
>> >> On Fri, Apr 21, 2017 at 02:55:16PM +0200, Geert Uytterhoeven wrote:
>> >>> The Renesas Salvator-X and ULCB development board can be equipped with
>> >>> either an R-Car H3 or M3-W SiP, which are pin-compatible.  All boards
>> >>> use separate DTBs, but currently there's no sharing of board-specific
>> >>> devices in DTS.
>> >>>
>> >>> This series reduces duplication by extracting common board support into
>> >>> their own .dtsi files.  As the level of support varies across boards and
>> >>> SoCs, this requires the addition of a few external clocks and
>> >>> placeholder devices on R-Car M3-W, so the common board support DTS can
>> >>> refer to them.
>> >>>
>> >>>   - Patches 1 and 2 add the external audio and PCIe bus clocks on R-Car
>> >>>     M3-W, which are present in r8a7795.dtsi, and used in
>> >>>     r8a7795-salvator-x.dts,
>> >>>   - RFC patch 3 adds placeholders for devices that are not yet supported
>> >>>     and/or tested on R-Car M3-W, but used on R-Car H3,
>> >>>   - RFC patch 4 extracts common Salvator-X board support,
>> >>>   - RFC patch 5 extracts common ULCB board support.
>> >>>
>> >>> For R-Car H3 based boards, there are no functional changes.
>> >>> For R-Car M3-W based boards, some new devices are now described in DT.
>> >>>
>> >>> Dependencies:
>> >>>   - renesas-devel-20170420-v4.11-rc7,
>> >>>   - Patches 1 and 2 can be applied as-is,
>> >>>   - Patches 4 and 5 depend on "[PATCH 0/8] arm64: dts: renesas: Break
>> >>>     out R-Car H3 and M3-W SiP"
>> >>>     (http://www.spinics.net/lists/devicetree/msg173820.html).
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

>> >>> DTB changes have been inspected using scripts/dtc/dtx_diff.
>> >>> This has been tested on Salvator-X (both H3 and M3-W).
>> >>> This has not been tested on H3ULCB and M3ULCB due to lack of hardware.
>> >>>
>> >>> Thanks for your comments!
>> >>
>> >> Thanks for tackling this important problem. I have looked over the changes
>> >> and they seem nice to me. I would, however, be more comfortable applying
>> >> them if they were rested on the ULCB boards.
>> >
>> > tested?
>> >
>> > I've pushed a branch for testing to topic/rcar3-dtsi-sharing in
>> > git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git.
>>
>> I managed to test it on the new H3ULCB and M3ULCB baords in Magnus' farm.
>> No issues detected.
>
> Great! Any objections to me queuing this up?

The dependency above (no feedback about the SiP types yet).

I can respin without that dependency, if that is preferred...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH/RFC 0/5] arm64: dts: renesas: Break out common board support

[Simon Horman]

On Fri, Apr 28, 2017 at 09:11:36AM +0200, Geert Uytterhoeven wrote:
> Hi SImon,
> 
> On Fri, Apr 28, 2017 at 9:04 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Apr 27, 2017 at 03:32:49PM +0200, Geert Uytterhoeven wrote:
> >> On Wed, Apr 26, 2017 at 10:11 AM, Geert Uytterhoeven
> >> <geert@linux-m68k.org> wrote:
> >> > CC Vladimir (which I forgot to CC initially, sorry for that)
> >> >
> >> > On Wed, Apr 26, 2017 at 10:06 AM, Simon Horman <horms@verge.net.au> wrote:
> >> >> On Fri, Apr 21, 2017 at 02:55:16PM +0200, Geert Uytterhoeven wrote:
> >> >>> The Renesas Salvator-X and ULCB development board can be equipped with
> >> >>> either an R-Car H3 or M3-W SiP, which are pin-compatible.  All boards
> >> >>> use separate DTBs, but currently there's no sharing of board-specific
> >> >>> devices in DTS.
> >> >>>
> >> >>> This series reduces duplication by extracting common board support into
> >> >>> their own .dtsi files.  As the level of support varies across boards and
> >> >>> SoCs, this requires the addition of a few external clocks and
> >> >>> placeholder devices on R-Car M3-W, so the common board support DTS can
> >> >>> refer to them.
> >> >>>
> >> >>>   - Patches 1 and 2 add the external audio and PCIe bus clocks on R-Car
> >> >>>     M3-W, which are present in r8a7795.dtsi, and used in
> >> >>>     r8a7795-salvator-x.dts,
> >> >>>   - RFC patch 3 adds placeholders for devices that are not yet supported
> >> >>>     and/or tested on R-Car M3-W, but used on R-Car H3,
> >> >>>   - RFC patch 4 extracts common Salvator-X board support,
> >> >>>   - RFC patch 5 extracts common ULCB board support.
> >> >>>
> >> >>> For R-Car H3 based boards, there are no functional changes.
> >> >>> For R-Car M3-W based boards, some new devices are now described in DT.
> >> >>>
> >> >>> Dependencies:
> >> >>>   - renesas-devel-20170420-v4.11-rc7,
> >> >>>   - Patches 1 and 2 can be applied as-is,
> >> >>>   - Patches 4 and 5 depend on "[PATCH 0/8] arm64: dts: renesas: Break
> >> >>>     out R-Car H3 and M3-W SiP"
> >> >>>     (http://www.spinics.net/lists/devicetree/msg173820.html).
>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> >> >>> DTB changes have been inspected using scripts/dtc/dtx_diff.
> >> >>> This has been tested on Salvator-X (both H3 and M3-W).
> >> >>> This has not been tested on H3ULCB and M3ULCB due to lack of hardware.
> >> >>>
> >> >>> Thanks for your comments!
> >> >>
> >> >> Thanks for tackling this important problem. I have looked over the changes
> >> >> and they seem nice to me. I would, however, be more comfortable applying
> >> >> them if they were rested on the ULCB boards.
> >> >
> >> > tested?
> >> >
> >> > I've pushed a branch for testing to topic/rcar3-dtsi-sharing in
> >> > git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git.
> >>
> >> I managed to test it on the new H3ULCB and M3ULCB baords in Magnus' farm.
> >> No issues detected.
> >
> > Great! Any objections to me queuing this up?
> 
> The dependency above (no feedback about the SiP types yet).
> 
> I can respin without that dependency, if that is preferred...

It seems to me that it would be nice to get these in sooner than later - in
particular earlier rather than later in the (v4.13) development cycle. But
I defer to your judgement on what is best.

[PATCH/RFC 0/5] arm64: dts: renesas: Break out common board support

[Geert Uytterhoeven]

Hi Simon,

On Fri, Apr 28, 2017 at 9:32 AM, Simon Horman <horms@verge.net.au> wrote:
> On Fri, Apr 28, 2017 at 09:11:36AM +0200, Geert Uytterhoeven wrote:
>> On Fri, Apr 28, 2017 at 9:04 AM, Simon Horman <horms@verge.net.au> wrote:
>> > On Thu, Apr 27, 2017 at 03:32:49PM +0200, Geert Uytterhoeven wrote:
>> >> On Wed, Apr 26, 2017 at 10:11 AM, Geert Uytterhoeven
>> >> <geert@linux-m68k.org> wrote:
>> >> > CC Vladimir (which I forgot to CC initially, sorry for that)
>> >> >
>> >> > On Wed, Apr 26, 2017 at 10:06 AM, Simon Horman <horms@verge.net.au> wrote:
>> >> >> On Fri, Apr 21, 2017 at 02:55:16PM +0200, Geert Uytterhoeven wrote:
>> >> >>> The Renesas Salvator-X and ULCB development board can be equipped with
>> >> >>> either an R-Car H3 or M3-W SiP, which are pin-compatible.  All boards
>> >> >>> use separate DTBs, but currently there's no sharing of board-specific
>> >> >>> devices in DTS.
>> >> >>>
>> >> >>> This series reduces duplication by extracting common board support into
>> >> >>> their own .dtsi files.  As the level of support varies across boards and
>> >> >>> SoCs, this requires the addition of a few external clocks and
>> >> >>> placeholder devices on R-Car M3-W, so the common board support DTS can
>> >> >>> refer to them.
>> >> >>>
>> >> >>>   - Patches 1 and 2 add the external audio and PCIe bus clocks on R-Car
>> >> >>>     M3-W, which are present in r8a7795.dtsi, and used in
>> >> >>>     r8a7795-salvator-x.dts,
>> >> >>>   - RFC patch 3 adds placeholders for devices that are not yet supported
>> >> >>>     and/or tested on R-Car M3-W, but used on R-Car H3,
>> >> >>>   - RFC patch 4 extracts common Salvator-X board support,
>> >> >>>   - RFC patch 5 extracts common ULCB board support.
>> >> >>>
>> >> >>> For R-Car H3 based boards, there are no functional changes.
>> >> >>> For R-Car M3-W based boards, some new devices are now described in DT.
>> >> >>>
>> >> >>> Dependencies:
>> >> >>>   - renesas-devel-20170420-v4.11-rc7,
>> >> >>>   - Patches 1 and 2 can be applied as-is,
>> >> >>>   - Patches 4 and 5 depend on "[PATCH 0/8] arm64: dts: renesas: Break
>> >> >>>     out R-Car H3 and M3-W SiP"
>> >> >>>     (http://www.spinics.net/lists/devicetree/msg173820.html).
>>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> >> >>> DTB changes have been inspected using scripts/dtc/dtx_diff.
>> >> >>> This has been tested on Salvator-X (both H3 and M3-W).
>> >> >>> This has not been tested on H3ULCB and M3ULCB due to lack of hardware.
>> >> >>>
>> >> >>> Thanks for your comments!
>> >> >>
>> >> >> Thanks for tackling this important problem. I have looked over the changes
>> >> >> and they seem nice to me. I would, however, be more comfortable applying
>> >> >> them if they were rested on the ULCB boards.
>> >> >
>> >> > tested?
>> >> >
>> >> > I've pushed a branch for testing to topic/rcar3-dtsi-sharing in
>> >> > git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git.
>> >>
>> >> I managed to test it on the new H3ULCB and M3ULCB baords in Magnus' farm.
>> >> No issues detected.
>> >
>> > Great! Any objections to me queuing this up?
>>
>> The dependency above (no feedback about the SiP types yet).
>>
>> I can respin without that dependency, if that is preferred...
>
> It seems to me that it would be nice to get these in sooner than later - in
> particular earlier rather than later in the (v4.13) development cycle. But
> I defer to your judgement on what is best.

Agreed.  Stay tuned for v2...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds