[PATCH] ARM: shmobile: Consolidate R8A779[234] machine definitions

[geert@linux-m68k.org (Geert Uytterhoeven)]

Hi Laurent,

On Wed, Oct 5, 2016 at 12:31 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> The three SoCs use the exact same machine definition, consolidate them
> into a single one.

Thanks for your patch!

> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

I'm wondering if we can improve upon...

> --- a/arch/arm/mach-shmobile/setup-rcar-gen2.c
> +++ b/arch/arm/mach-shmobile/setup-rcar-gen2.c

> @@ -203,3 +204,22 @@ void __init rcar_gen2_reserve(void)
>         }
>  #endif
>  }
> +
> +static const char * const rcar_gen2_boards_compat_dt[] __initconst = {
> +       /*
> +        * R8A7790 and R8A7791 can't be handled here as long as they need SMP
> +        * initialization fallback.
> +        */
> +       "renesas,r8a7792",
> +       "renesas,r8a7793",
> +       "renesas,r8a7794",
> +       NULL,
> +};
> +
> +DT_MACHINE_START(RCAR_GEN2_DT, "Generic Gen2 (Flattened Device Tree)")
> +       .init_early     = shmobile_init_delay,

shmobile_init_delay() is not really Renesas-specific, but ARM-specific.
This is just to avoid calibrating the delay loop?

> +       .init_late      = shmobile_init_late,

This calls only into shmobile_suspend_init(), which is also not
Renesas-specific.

> +       .init_time      = rcar_gen2_timer_init,

This is about fixing up the ARM Arch timer, and initializing clocks as we
need to pass the mode pin state (ugh, will hopefully go away soon).

> +       .reserve        = rcar_gen2_reserve,

Reserving a block for CMA DMA is also not really Renesas-specific.

> +       .dt_compat      = rcar_gen2_boards_compat_dt,
> +MACHINE_END

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds