From: geert@linux-m68k.org (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk
Date: Thu, 15 Feb 2018 12:23:56 +0100 [thread overview]
Message-ID: <CAMuHMdWCExs8OPkkm9dnnsFGHsU-HtJbieyCh_m7EEfFBU2u0A@mail.gmail.com> (raw)
In-Reply-To: <20180215104337.ewzggtcm6usdlpnt@katana>
Hi Wolfram,
On Thu, Feb 15, 2018 at 11:43 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
>> > It sends per device, so unless there is a device named "da9210" at
>> > addr 0x70, nothing will happen? Am I missing something?
>>
>> As soon as one of the affected devices is instantiated, it has to shut up
>> all devices. This is done by sending the whole da9xxx_msgs[] array,
>> which needs modification now we have boards with two or three devices.
>
> Ah, I missed the "done = true;" part in remove
Perhaps the code should be rewritten to not match board compatible values,
but scan for da9063 and da9210 regulators, keep track of how many are found,
and activate if more than one is found using the same interrupt?
Yes, more complex code. But I have no idea how many Renesas customers
copied this part of the board design...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-02-15 11:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 10:02 [PATCH V2] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk Marek Vasut
2018-02-15 10:03 ` Wolfram Sang
2018-02-15 10:14 ` Geert Uytterhoeven
2018-02-15 10:19 ` Wolfram Sang
2018-02-15 10:32 ` Geert Uytterhoeven
2018-02-15 10:43 ` Wolfram Sang
2018-02-15 11:23 ` Geert Uytterhoeven [this message]
2018-02-15 17:03 ` Simon Horman
2018-02-15 17:05 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWCExs8OPkkm9dnnsFGHsU-HtJbieyCh_m7EEfFBU2u0A@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).