From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00816CF11C3 for ; Thu, 10 Oct 2024 10:04:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gyYDEMJQN0e3qrTRJi0lW82aU2fQXGEhYCzwe7aKnDM=; b=G/knykQvfwYdxtGoWN4jtZ77cx vYFwan0oNVGBo2uTjyJ052zdx9i57cNu/PWrw5vtLptEbAx4n2gnTggVNvyrmZOJVue/9gZ6/7xen sMBP+YbpNYoIkvVGfMzbikFmGHJdrIzfl73W6F/sqLmH6cxie6hf21eyz2t8h5F9sZ3ZEHmdCBQeW S28vi5Y7GtSQtF+9GLhZg720e+dd6CRuN93Klf3l6YofWPzZz4wLCWkODtgUO6rJgKDELFkWh6Fme Ow/qMwVLZFD9N8raWVO3/axSV5snJR1LQXghbC6mbZadLBNDwYDlwR+Mz2hJmV4dPM4iNG8zNWWYt tjjdMYbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syq1v-0000000CKdL-2N7O; Thu, 10 Oct 2024 10:04:23 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sypw6-0000000CJex-3jch for linux-arm-kernel@bombadil.infradead.org; Thu, 10 Oct 2024 09:58:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version: Sender:Reply-To:Content-ID:Content-Description; bh=gyYDEMJQN0e3qrTRJi0lW82aU2fQXGEhYCzwe7aKnDM=; b=JI5qUcTHj03Ttk7qVc4z7ky+0t SHcTcEPCN1TUEDEJU48dnqeLJ5UPrXC/ZoaJse3vxkLCIqE93AIFpq7nzD43+uHTXCAie1Jdnvr3Q Ys5Mo9oExbcyft1Y/TD2miQJZsfgJT27ogBWAW9IQxIHGyXVl8wOS/gUI5ISvgLNXiBAZhsV5OLFH 1TXJkCk8h5sHf0HwNRf4tclrY2lu9LCsKXm3j9DteQr7rljs/YmCAQrwBeDPAM7L2AiAQZjMHriXz 1Fd4ydfvQ8eHCBCOxzHmiZUQJhkQ0+PpdZv9A512NVA71J5KYYkq/MrVCOhOFoUv7MpExzYJH95sb FoYRXwgg==; Received: from mail-yw1-f182.google.com ([209.85.128.182]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sypw3-00000005Kwq-2c3t for linux-arm-kernel@lists.infradead.org; Thu, 10 Oct 2024 09:58:21 +0000 Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-6dfff346a83so7562477b3.2 for ; Thu, 10 Oct 2024 02:58:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728554297; x=1729159097; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gyYDEMJQN0e3qrTRJi0lW82aU2fQXGEhYCzwe7aKnDM=; b=B/9lPkeGmqRERRXkAAeUsCLRRXx5yQB8mVcm+WSdOn2pv+PQGqbNfEdL+SeiXzZH7c IcSyZP3gudbfxGEXLZ9TUobU/TGvrKr4oeTRw8c3NEYXDSLDu0Y9amtonHFHgf9M//VO g8f35x8URq8zmGPvZAWoIAD3RgI/Ddx/Q+lu5F24IbWVHR+MShXSVBaqfQSRx1Gwijx5 X3xNkdYnSChFsjrcsFAGh30xs1b9Qw9oG6or+wBq+XD2N2cQsb6EqrLlfflyzBxC5aPj rU6ttwSekWauUjfjHZKvFwqXhGrF7HSN+63EFSYkNeKoXW93NCf4uhMsUsjJejSKOrYF gRiA== X-Forwarded-Encrypted: i=1; AJvYcCWQqC93bvb6He4WDu3thfb79Zb/gVEaC5nw8WY2bZJKEaUTmvpV/gZrYaef/f539jKpWS+LP532jfQbY05wTRDu@lists.infradead.org X-Gm-Message-State: AOJu0YyGYSJsy7UloHN8oTsMDhLuq+uaw1L0uCRPSv5EQT9CbH56whIJ ZP18DVj0R7BO4oiJTQVArFXZ3vshZi/vxueKIz2UmJVVeUwF5Cj6ZTR7VqXu X-Google-Smtp-Source: AGHT+IFwnt1HwW6XYkNodgGrUhuBC1dsHQyNxIl+NC51yT5Lx2RtNL4W7g0dG5y3a3qotOJO+cjmBw== X-Received: by 2002:a05:690c:3484:b0:6db:b5b2:53c with SMTP id 00721157ae682-6e322450395mr47129827b3.32.1728554296749; Thu, 10 Oct 2024 02:58:16 -0700 (PDT) Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com. [209.85.128.169]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6e332951f23sm1661217b3.0.2024.10.10.02.58.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Oct 2024 02:58:16 -0700 (PDT) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-6e2346f164cso7021197b3.3 for ; Thu, 10 Oct 2024 02:58:16 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUAXnOhb7hztBBA5VOvptVxYBY23fpsla8Laye8BUKm71MM8oFjjtpECrREcYcGra4LhIsKTvaIwTLASkdwYQ4k@lists.infradead.org X-Received: by 2002:a05:690c:6206:b0:6db:bfa1:5530 with SMTP id 00721157ae682-6e322491433mr59403057b3.41.1728554296092; Thu, 10 Oct 2024 02:58:16 -0700 (PDT) MIME-Version: 1.0 References: <20240830130218.3377060-1-claudiu.beznea.uj@bp.renesas.com> <20240830130218.3377060-2-claudiu.beznea.uj@bp.renesas.com> In-Reply-To: <20240830130218.3377060-2-claudiu.beznea.uj@bp.renesas.com> From: Geert Uytterhoeven Date: Thu, 10 Oct 2024 11:58:04 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 01/12] dt-bindings: clock: renesas,r9a08g045-vbattb: Document VBATTB To: Claudiu Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, magnus.damm@gmail.com, p.zabel@pengutronix.de, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241010_105819_781830_0C836A0A X-CRM114-Status: GOOD ( 23.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Claudiu, On Fri, Aug 30, 2024 at 3:02=E2=80=AFPM Claudiu = wrote: > From: Claudiu Beznea > > The VBATTB IP of the Renesas RZ/G3S SoC controls the clock for RTC, > the tamper detector and a small general usage memory of 128B. Add > documentation for it. > > Signed-off-by: Claudiu Beznea > --- > > Changes in v3: > - moved the file to clock dt bindings directory as it is the > only functionality supported at the moment; the other functionalities > (tamper detector, SRAM) are offered though register spreaded > though the address space of the VBATTB IP and not actually > individual devices; the other functionalities are not > planned to be supported soon and if they will be I think they > fit better on auxiliary bus than MFD > - dropped interrupt names as requested in the review process > - dropped the inner node for clock controller > - added #clock-cells > - added rtx clock > - updated description for renesas,vbattb-load-nanofarads > - included dt-bindings/interrupt-controller/irq.h in examples section Thanks for the update! LGTM, modulo issues pointed out in other review comments. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds