From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3209AC00140 for ; Fri, 12 Aug 2022 09:50:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QHuvlFkzHcfevuD/848hh2yBYet/iiIAo2584ykz8OE=; b=c0mIurCW2Rlbpk 5NVHCMCZoOr6MRFf3NZgXn2YhWIwdNwm/JCPTWlRZYrANsATDbpUPMMEbzZIomerQG+ZimAk+NkEZ N5wO9ZvdZOVIWr0ML+vYGt3ZbdTIfnYjpj2Psge1h8cs/Ql5HatTRgBBjDDrPkZJbOJUIkDOyU9va Dh+PaRHv7Q23XYyaVz3cwrz+zaRloRCBiFaFzXoAaj5ZRnL9CnIQrL7MdKco+6gpyoOB9DcQUXU/B lkFZDU4NBqxf+qCfoghEZ6P8JW3eBVzC83yoXszyPR5AMf4rhwL813NnkPBqfx/vsf7u9PbvKmRpF /UjelohDOw1uEfenMR/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMRIZ-003y1a-TM; Fri, 12 Aug 2022 09:49:48 +0000 Received: from mail-qk1-f177.google.com ([209.85.222.177]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMRIR-003xsO-7v for linux-arm-kernel@lists.infradead.org; Fri, 12 Aug 2022 09:49:40 +0000 Received: by mail-qk1-f177.google.com with SMTP id v14so382017qkf.4 for ; Fri, 12 Aug 2022 02:49:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=84EvJYe5/gB9MvzhwVIbaAf2+0yNVDv4HY17IxGY5sE=; b=wTI9A4uJU2k9CAniMFkgGwyXPlJ4qdl6g8YMOmvuvHLbjyNmrGQvmrS91zJoKGfBYU gmq8GzT4m2zL8g9a6FOJAI8caJ4YLn750JZ/cK8coLUqeuO2tAj/+4WiWrNE5TtoI+CK v0Vdk/w+Ip9+hyADsHa70bklbObnm7XUtC04lWOPYbwWjQL7o7sdbNlIszZkef1OoXeo PDRcypZRBeZ/R+FVeXRBeZS8mdrDkn1AUsBcUAHxDwZroXBia5aKT6lkrw2MA87edQFR kwvf4IdicXvnLQsU16rvlgWuFqMMXpAGYYMK1/T0FTYENfrbhKgJ9v4GS48+0toXqd3p yLlQ== X-Gm-Message-State: ACgBeo1ktMbD4DA2DcVP2wOi3AnCzSqOdGu2DIbVpZnyF1Oe3ajmehZJ zzdmc0WlCnfmytCf8sUGnNoKtoo0NC6Fcw== X-Google-Smtp-Source: AA6agR7UpPELjxwjK0otkwAKc6Yt4xVaGQxFN/bZJPCkeRkIORP6tTU6PPUDlbXxPu73orK0i0LIgQ== X-Received: by 2002:a05:620a:2014:b0:6b9:7978:c69a with SMTP id c20-20020a05620a201400b006b97978c69amr2175715qka.275.1660297776729; Fri, 12 Aug 2022 02:49:36 -0700 (PDT) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com. [209.85.219.175]) by smtp.gmail.com with ESMTPSA id b8-20020ae9eb08000000b006b8f4ade2c9sm1382840qkg.19.2022.08.12.02.49.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 02:49:35 -0700 (PDT) Received: by mail-yb1-f175.google.com with SMTP id 21so693629ybf.4 for ; Fri, 12 Aug 2022 02:49:35 -0700 (PDT) X-Received: by 2002:a25:2d4:0:b0:674:b112:4f37 with SMTP id 203-20020a2502d4000000b00674b1124f37mr2830842ybc.202.1660297775213; Fri, 12 Aug 2022 02:49:35 -0700 (PDT) MIME-Version: 1.0 References: <20220804061133.4110734-1-victor.liu@nxp.com> <20220804061133.4110734-3-victor.liu@nxp.com> In-Reply-To: <20220804061133.4110734-3-victor.liu@nxp.com> From: Geert Uytterhoeven Date: Fri, 12 Aug 2022 11:49:23 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/3] drivers: bus: simple-pm-bus: Use clocks To: Liu Ying Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Linux Kernel Mailing List , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , NXP Linux Team , Saravana Kannan , Greg KH , Geert Uytterhoeven , Krzysztof Kozlowski , Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220812_024939_334841_4A0A9DE7 X-CRM114-Status: GOOD ( 27.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Liu, On Thu, Aug 4, 2022 at 8:10 AM Liu Ying wrote: > Simple Power-Managed bus controller may need functional clock(s) > to be enabled before child devices connected to the bus can be > accessed. Get the clock(s) as a bulk and enable/disable the > clock(s) when the bus is being power managed. > > One example is that Freescale i.MX8qxp pixel link MSI bus controller > needs MSI clock and AHB clock to be enabled before accessing child > devices. > > Signed-off-by: Liu Ying > --- > v1->v3: > * No change. Thanks for your patch! > --- a/drivers/bus/simple-pm-bus.c > +++ b/drivers/bus/simple-pm-bus.c > @@ -72,6 +89,42 @@ static int simple_pm_bus_remove(struct platform_device *pdev) > return 0; > } > > +static int simple_pm_bus_runtime_suspend(struct device *dev) > +{ > + struct simple_pm_bus *bus = dev_get_drvdata(dev); > + > + if (!bus) > + return 0; Can this really happen? > + > + clk_bulk_disable_unprepare(bus->num_clks, bus->clks); > + > + return 0; > +} > + > +static int simple_pm_bus_runtime_resume(struct device *dev) > +{ > + struct simple_pm_bus *bus = dev_get_drvdata(dev); > + int ret; > + > + if (!bus) > + return 0; Likewise. > + > + ret = clk_bulk_prepare_enable(bus->num_clks, bus->clks); > + if (ret) { > + dev_err(dev, "failed to enable clocks: %d\n", ret); > + return ret; > + } > + > + return 0; > +} The rest LGTM, so Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel