From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45390C34022 for ; Mon, 17 Feb 2020 22:24:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15B9A2070B for ; Mon, 17 Feb 2020 22:24:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y5rk1JLg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15B9A2070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GzpcZNewxqJk2jwD1ZSrDFXmrVDG/DlsTO6oFxWUgsE=; b=Y5rk1JLgyR7dM9 EPGzAlTRSaoolWPgXtr52+RlVuw3DHiHeyDa76mNr84f3YBmMGZ8eRJabG4CgbCx9afLIFLSuV8lz LeYognz/td5PZGlQ06E3zBUoXMW8cOF8JlcfYY6tD9MlEo18xUvqeg3vHLwe0rv+PbjECUvA7/3pl pUboY8l9laZqdlbmtvmg1sCF/iRwqOlR2JLKpuX3Ffd6E1wvc+vSn9bP/DeNgciGoi7UivG/w7gIF U8USRKT/KSSHRsXPKdD5dU/f/JrD/1e47QO3n/fKM5vJoq85Z6nW4b58jWYDk3jf39XQZc0xgfsX/ D0clIHhGqEalRpeTv58g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3ooV-0004Mu-05; Mon, 17 Feb 2020 22:24:27 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3ooR-0004MQ-Gf for linux-arm-kernel@lists.infradead.org; Mon, 17 Feb 2020 22:24:25 +0000 Received: by mail-oi1-f194.google.com with SMTP id p125so18164471oif.10 for ; Mon, 17 Feb 2020 14:24:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PbYZrxbxhBBKk5C91qZpoXk9cEvY6aisFfocm2j3KvA=; b=Dxg0kqBEqlWJFdygRCuUOFCWsISSvf3n86PxUIpQRYFcsJD+cE3NwAEuZsqn0WvE5Y UgiC4zxTdgNy5f89yQ8xDzZdhYSE1V5cA/2TnAlG9OInPY7wtPQ1JeuatbXkUOlf4u/Q 49rS34TW9YlY0V8iuJXLcDX4NP3TnOs55+QdB0nnACS+MVCYZ47uu0Q+sYUrHh+AFZ8a C9j6wQaaHMWvIFOzLi+yt0XmVomyv7oTBIAcDHvv5aBQokqNaNxcY099xSGmI58RSMMu hkY0lkCr5MVeYio8EIS2OhpBErczQkRvA6Qui6/U2nubfrECsQwF4hal0jPyYqL9taRf zzAg== X-Gm-Message-State: APjAAAUVZmN1XgTpuM2k75npRKszo+ImFz+qtOdWraZmBf/2vTFUA8Ib xX6GdY8DbjXE6w5Dp1pfYadk16awLjSE4Fs/rJI= X-Google-Smtp-Source: APXvYqz3Xxu6MK5IoxY+z+kFQJuuEELpdbhj84fkAG33NBqiXYnC9I/rrXr/6fP1+IugvUqR7fDBJ8pHyvEZfsIXAtc= X-Received: by 2002:aca:c4d2:: with SMTP id u201mr802861oif.54.1581978262056; Mon, 17 Feb 2020 14:24:22 -0800 (PST) MIME-Version: 1.0 References: <20200217144050.3i4ymbytogod4ijn@kili.mountain> In-Reply-To: <20200217144050.3i4ymbytogod4ijn@kili.mountain> From: Geert Uytterhoeven Date: Mon, 17 Feb 2020 23:24:10 +0100 Message-ID: Subject: Re: [PATCH] dmaengine: coh901318: Fix a double lock bug in dma_tc_handle() To: Dan Carpenter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200217_142423_549502_DDC570FD X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , kernel-janitors@vger.kernel.org, Vinod Koul , Jia-Ju Bai , dmaengine , Dan Williams , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dan, On Mon, Feb 17, 2020 at 3:41 PM Dan Carpenter wrote: > The caller is already holding the lock so this will deadlock. > > Fixes: 0b58828c923e ("DMAENGINE: COH 901 318 remove irq counting") > Signed-off-by: Dan Carpenter > --- > This is the second double lock bug found using static analysis. The > previous one was commit 627469e4445b ("dmaengine: coh901318: Fix a > double-lock bug"). > > The fact that this has been broken for ten years suggests that no one > has the hardware. Or this only runs CONFIG_SMP=n kernels? This seems to be used in arch/arm/boot/dts/ste-u300.dts only, and CONFIG_ARCH_U300 is a ARCH_MULTI_V5 platform, which looks like it doesn't support SMP? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel