* [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn @ 2017-02-17 7:11 Joe Perches 2017-02-17 7:11 ` [PATCH 02/35] ARM: ep93xx: Convert remaining uses of " Joe Perches ` (4 more replies) 0 siblings, 5 replies; 17+ messages in thread From: Joe Perches @ 2017-02-17 7:11 UTC (permalink / raw) To: linux-arm-kernel There are ~4300 uses of pr_warn and ~250 uses of the older pr_warning in the kernel source tree. Make the use of pr_warn consistent across all kernel files. This excludes all files in tools/ as there is a separate define pr_warning for that directory tree and pr_warn is not used in tools/. Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. Miscellanea: o Coalesce formats and realign arguments Some files not compiled - no cross-compilers Joe Perches (35): alpha: Convert remaining uses of pr_warning to pr_warn ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn arm64: Convert remaining uses of pr_warning to pr_warn arch/blackfin: Convert remaining uses of pr_warning to pr_warn ia64: Convert remaining use of pr_warning to pr_warn powerpc: Convert remaining uses of pr_warning to pr_warn sh: Convert remaining uses of pr_warning to pr_warn sparc: Convert remaining use of pr_warning to pr_warn x86: Convert remaining uses of pr_warning to pr_warn drivers/acpi: Convert remaining uses of pr_warning to pr_warn block/drbd: Convert remaining uses of pr_warning to pr_warn gdrom: Convert remaining uses of pr_warning to pr_warn drivers/char: Convert remaining use of pr_warning to pr_warn clocksource: Convert remaining use of pr_warning to pr_warn drivers/crypto: Convert remaining uses of pr_warning to pr_warn fmc: Convert remaining use of pr_warning to pr_warn drivers/gpu: Convert remaining uses of pr_warning to pr_warn drivers/ide: Convert remaining uses of pr_warning to pr_warn drivers/input: Convert remaining uses of pr_warning to pr_warn drivers/isdn: Convert remaining uses of pr_warning to pr_warn drivers/macintosh: Convert remaining uses of pr_warning to pr_warn drivers/media: Convert remaining use of pr_warning to pr_warn drivers/mfd: Convert remaining uses of pr_warning to pr_warn drivers/mtd: Convert remaining uses of pr_warning to pr_warn drivers/of: Convert remaining uses of pr_warning to pr_warn drivers/oprofile: Convert remaining uses of pr_warning to pr_warn drivers/platform: Convert remaining uses of pr_warning to pr_warn drivers/rapidio: Convert remaining use of pr_warning to pr_warn drivers/scsi: Convert remaining use of pr_warning to pr_warn drivers/sh: Convert remaining use of pr_warning to pr_warn drivers/tty: Convert remaining uses of pr_warning to pr_warn drivers/video: Convert remaining uses of pr_warning to pr_warn kernel/trace: Convert remaining uses of pr_warning to pr_warn lib: Convert remaining uses of pr_warning to pr_warn sound/soc: Convert remaining uses of pr_warning to pr_warn arch/alpha/kernel/perf_event.c | 4 +- arch/arm/mach-ep93xx/core.c | 4 +- arch/arm64/include/asm/syscall.h | 8 ++-- arch/arm64/kernel/hw_breakpoint.c | 8 ++-- arch/arm64/kernel/smp.c | 4 +- arch/blackfin/kernel/nmi.c | 2 +- arch/blackfin/kernel/ptrace.c | 2 +- arch/blackfin/mach-bf533/boards/stamp.c | 2 +- arch/blackfin/mach-bf537/boards/cm_bf537e.c | 2 +- arch/blackfin/mach-bf537/boards/cm_bf537u.c | 2 +- arch/blackfin/mach-bf537/boards/stamp.c | 2 +- arch/blackfin/mach-bf537/boards/tcm_bf537.c | 2 +- arch/blackfin/mach-bf561/boards/cm_bf561.c | 2 +- arch/blackfin/mach-bf561/boards/ezkit.c | 2 +- arch/blackfin/mm/isram-driver.c | 4 +- arch/ia64/kernel/setup.c | 6 +-- arch/powerpc/kernel/pci-common.c | 4 +- arch/powerpc/mm/init_64.c | 5 +-- arch/powerpc/mm/mem.c | 3 +- arch/powerpc/platforms/512x/mpc512x_shared.c | 4 +- arch/powerpc/platforms/85xx/socrates_fpga_pic.c | 7 ++-- arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 2 +- arch/powerpc/platforms/pasemi/dma_lib.c | 4 +- arch/powerpc/platforms/powernv/opal.c | 8 ++-- arch/powerpc/platforms/powernv/pci-ioda.c | 10 ++--- arch/powerpc/platforms/ps3/device-init.c | 14 +++---- arch/powerpc/platforms/ps3/mm.c | 4 +- arch/powerpc/platforms/ps3/os-area.c | 2 +- arch/powerpc/platforms/pseries/iommu.c | 8 ++-- arch/powerpc/platforms/pseries/setup.c | 4 +- arch/powerpc/sysdev/fsl_pci.c | 9 ++--- arch/powerpc/sysdev/mpic.c | 10 ++--- arch/powerpc/sysdev/xics/icp-native.c | 10 ++--- arch/powerpc/sysdev/xics/ics-opal.c | 4 +- arch/powerpc/sysdev/xics/ics-rtas.c | 4 +- arch/powerpc/sysdev/xics/xics-common.c | 8 ++-- arch/sh/boards/mach-sdk7786/nmi.c | 2 +- arch/sh/drivers/pci/fixups-sdk7786.c | 2 +- arch/sh/kernel/io_trapped.c | 2 +- arch/sh/kernel/setup.c | 2 +- arch/sh/mm/consistent.c | 5 +-- arch/sparc/kernel/smp_64.c | 5 +-- arch/x86/kernel/amd_gart_64.c | 12 ++---- arch/x86/kernel/apic/apic.c | 46 ++++++++++------------ arch/x86/kernel/apic/apic_noop.c | 2 +- arch/x86/kernel/setup_percpu.c | 4 +- arch/x86/kernel/tboot.c | 15 ++++--- arch/x86/kernel/tsc_sync.c | 8 ++-- arch/x86/mm/kmmio.c | 8 ++-- arch/x86/mm/mmio-mod.c | 5 +-- arch/x86/mm/numa.c | 12 +++--- arch/x86/mm/numa_emulation.c | 6 +-- arch/x86/mm/testmmiotrace.c | 5 +-- arch/x86/oprofile/op_x86_model.h | 6 +-- arch/x86/platform/olpc/olpc-xo15-sci.c | 2 +- arch/x86/platform/sfi/sfi.c | 3 +- arch/x86/xen/debugfs.c | 2 +- arch/x86/xen/setup.c | 2 +- drivers/acpi/apei/apei-base.c | 32 +++++++-------- drivers/acpi/apei/einj.c | 4 +- drivers/acpi/apei/erst-dbg.c | 4 +- drivers/acpi/apei/ghes.c | 30 +++++++------- drivers/acpi/apei/hest.c | 10 ++--- drivers/acpi/resource.c | 4 +- drivers/block/drbd/drbd_nl.c | 13 +++--- drivers/cdrom/gdrom.c | 4 +- drivers/char/virtio_console.c | 2 +- drivers/clocksource/samsung_pwm_timer.c | 4 +- drivers/crypto/n2_core.c | 12 +++--- drivers/fmc/fmc-fakedev.c | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +- drivers/gpu/drm/amd/powerplay/inc/pp_debug.h | 2 +- drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c | 4 +- drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 14 +++---- .../gpu/drm/amd/powerplay/smumgr/polaris10_smc.c | 4 +- drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c | 4 +- drivers/ide/tx4938ide.c | 2 +- drivers/ide/tx4939ide.c | 5 +-- drivers/input/gameport/gameport.c | 4 +- drivers/input/joystick/gamecon.c | 3 +- drivers/input/misc/apanel.c | 3 +- drivers/input/misc/xen-kbdfront.c | 8 ++-- drivers/input/serio/serio.c | 8 ++-- drivers/isdn/gigaset/interface.c | 2 +- drivers/isdn/hardware/mISDN/avmfritz.c | 17 ++++---- drivers/isdn/hardware/mISDN/hfcmulti.c | 8 ++-- drivers/isdn/hardware/mISDN/hfcpci.c | 4 +- drivers/isdn/hardware/mISDN/hfcsusb.c | 4 +- drivers/isdn/hardware/mISDN/mISDNipac.c | 4 +- drivers/isdn/hardware/mISDN/mISDNisar.c | 10 ++--- drivers/isdn/hardware/mISDN/netjet.c | 8 ++-- drivers/isdn/hardware/mISDN/w6692.c | 12 +++--- drivers/isdn/mISDN/hwchannel.c | 8 ++-- drivers/macintosh/windfarm_fcu_controls.c | 5 +-- drivers/macintosh/windfarm_lm87_sensor.c | 4 +- drivers/macintosh/windfarm_pm72.c | 22 +++++------ drivers/macintosh/windfarm_rm31.c | 6 +-- drivers/media/platform/sh_vou.c | 4 +- drivers/mfd/db8500-prcmu.c | 2 +- drivers/mfd/sta2x11-mfd.c | 4 +- drivers/mfd/twl4030-power.c | 7 +--- drivers/mtd/chips/cfi_cmdset_0002.c | 12 ++++-- drivers/mtd/nand/cmx270_nand.c | 4 +- drivers/mtd/ofpart.c | 4 +- drivers/of/fdt.c | 20 +++++----- drivers/oprofile/oprofile_perf.c | 8 ++-- drivers/platform/x86/asus-laptop.c | 2 +- drivers/platform/x86/eeepc-laptop.c | 2 +- drivers/platform/x86/intel_oaktrail.c | 10 ++--- drivers/rapidio/rio-sysfs.c | 4 +- drivers/scsi/a3000.c | 2 +- drivers/sh/intc/core.c | 4 +- drivers/tty/hvc/hvcs.c | 2 +- drivers/tty/tty_io.c | 4 +- drivers/video/fbdev/aty/radeon_base.c | 4 +- drivers/video/fbdev/core/fbmon.c | 4 +- drivers/video/fbdev/pxafb.c | 7 ++-- kernel/trace/trace_benchmark.c | 4 +- lib/cpu_rmap.c | 2 +- lib/dma-debug.c | 2 +- sound/soc/fsl/imx-audmux.c | 6 +-- sound/soc/samsung/s3c-i2s-v2.c | 6 +-- 122 files changed, 367 insertions(+), 397 deletions(-) -- 2.10.0.rc2.1.g053435c ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 02/35] ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn 2017-02-17 7:11 [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches @ 2017-02-17 7:11 ` Joe Perches 2017-02-17 16:26 ` Hartley Sweeten 2017-02-17 7:11 ` [PATCH 03/35] arm64: " Joe Perches ` (3 subsequent siblings) 4 siblings, 1 reply; 17+ messages in thread From: Joe Perches @ 2017-02-17 7:11 UTC (permalink / raw) To: linux-arm-kernel To enable eventual removal of pr_warning. This makes pr_warn use consistent for arch/arm Prior to this patch, there were 2 uses of pr_warning and 405 uses of pr_warn in arch/arm Signed-off-by: Joe Perches <joe@perches.com> --- arch/arm/mach-ep93xx/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c index c393b1b0310d..d6e907b6cc31 100644 --- a/arch/arm/mach-ep93xx/core.c +++ b/arch/arm/mach-ep93xx/core.c @@ -346,9 +346,9 @@ void __init ep93xx_register_i2c(struct i2c_gpio_platform_data *data, * CMOS driver. */ if (data->sda_is_open_drain && data->sda_pin != EP93XX_GPIO_LINE_EEDAT) - pr_warning("sda != EEDAT, open drain has no effect\n"); + pr_warn("sda != EEDAT, open drain has no effect\n"); if (data->scl_is_open_drain && data->scl_pin != EP93XX_GPIO_LINE_EECLK) - pr_warning("scl != EECLK, open drain has no effect\n"); + pr_warn("scl != EECLK, open drain has no effect\n"); __raw_writel((data->sda_is_open_drain << 1) | (data->scl_is_open_drain << 0), -- 2.10.0.rc2.1.g053435c ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 02/35] ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn 2017-02-17 7:11 ` [PATCH 02/35] ARM: ep93xx: Convert remaining uses of " Joe Perches @ 2017-02-17 16:26 ` Hartley Sweeten 0 siblings, 0 replies; 17+ messages in thread From: Hartley Sweeten @ 2017-02-17 16:26 UTC (permalink / raw) To: linux-arm-kernel On Friday, February 17, 2017 12:11 AM, Joe Perches wrote: > To enable eventual removal of pr_warning. > > This makes pr_warn use consistent for arch/arm > > Prior to this patch, there were 2 uses of pr_warning and > 405 uses of pr_warn in arch/arm > > Signed-off-by: Joe Perches <joe@perches.com> > --- > arch/arm/mach-ep93xx/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c > index c393b1b0310d..d6e907b6cc31 100644 > --- a/arch/arm/mach-ep93xx/core.c > +++ b/arch/arm/mach-ep93xx/core.c > @@ -346,9 +346,9 @@ void __init ep93xx_register_i2c(struct i2c_gpio_platform_data *data, > * CMOS driver. > */ > if (data->sda_is_open_drain && data->sda_pin != EP93XX_GPIO_LINE_EEDAT) > - pr_warning("sda != EEDAT, open drain has no effect\n"); > + pr_warn("sda != EEDAT, open drain has no effect\n"); > if (data->scl_is_open_drain && data->scl_pin != EP93XX_GPIO_LINE_EECLK) > - pr_warning("scl != EECLK, open drain has no effect\n"); > + pr_warn("scl != EECLK, open drain has no effect\n"); > > __raw_writel((data->sda_is_open_drain << 1) | > (data->scl_is_open_drain << 0), For the ep93xx part: Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com> ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 03/35] arm64: Convert remaining uses of pr_warning to pr_warn 2017-02-17 7:11 [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches 2017-02-17 7:11 ` [PATCH 02/35] ARM: ep93xx: Convert remaining uses of " Joe Perches @ 2017-02-17 7:11 ` Joe Perches 2017-02-17 10:52 ` Mark Rutland 2017-02-17 7:11 ` [PATCH 23/35] drivers/mfd: " Joe Perches ` (2 subsequent siblings) 4 siblings, 1 reply; 17+ messages in thread From: Joe Perches @ 2017-02-17 7:11 UTC (permalink / raw) To: linux-arm-kernel To enable eventual removal of pr_warning This makes pr_warn use consistent for arch/arm64 Prior to this patch, there were 7 uses of pr_warning and 27 uses of pr_warn in arch/arm64 Signed-off-by: Joe Perches <joe@perches.com> --- arch/arm64/include/asm/syscall.h | 8 ++++---- arch/arm64/kernel/hw_breakpoint.c | 8 ++++---- arch/arm64/kernel/smp.c | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/arm64/include/asm/syscall.h b/arch/arm64/include/asm/syscall.h index 709a574468f0..231f2c3fcf81 100644 --- a/arch/arm64/include/asm/syscall.h +++ b/arch/arm64/include/asm/syscall.h @@ -68,8 +68,8 @@ static inline void syscall_get_arguments(struct task_struct *task, if (i + n > SYSCALL_MAX_ARGS) { unsigned long *args_bad = args + SYSCALL_MAX_ARGS - i; unsigned int n_bad = n + i - SYSCALL_MAX_ARGS; - pr_warning("%s called with max args %d, handling only %d\n", - __func__, i + n, SYSCALL_MAX_ARGS); + pr_warn("%s called with max args %d, handling only %d\n", + __func__, i + n, SYSCALL_MAX_ARGS); memset(args_bad, 0, n_bad * sizeof(args[0])); } @@ -92,8 +92,8 @@ static inline void syscall_set_arguments(struct task_struct *task, return; if (i + n > SYSCALL_MAX_ARGS) { - pr_warning("%s called with max args %d, handling only %d\n", - __func__, i + n, SYSCALL_MAX_ARGS); + pr_warn("%s called with max args %d, handling only %d\n", + __func__, i + n, SYSCALL_MAX_ARGS); n = SYSCALL_MAX_ARGS - i; } diff --git a/arch/arm64/kernel/hw_breakpoint.c b/arch/arm64/kernel/hw_breakpoint.c index 0296e7924240..6fa79ffd0c43 100644 --- a/arch/arm64/kernel/hw_breakpoint.c +++ b/arch/arm64/kernel/hw_breakpoint.c @@ -62,7 +62,7 @@ int hw_breakpoint_slots(int type) case TYPE_DATA: return get_num_wrps(); default: - pr_warning("unknown slot type: %d\n", type); + pr_warn("unknown slot type: %d\n", type); return 0; } } @@ -123,7 +123,7 @@ static u64 read_wb_reg(int reg, int n) GEN_READ_WB_REG_CASES(AARCH64_DBG_REG_WVR, AARCH64_DBG_REG_NAME_WVR, val); GEN_READ_WB_REG_CASES(AARCH64_DBG_REG_WCR, AARCH64_DBG_REG_NAME_WCR, val); default: - pr_warning("attempt to read from unknown breakpoint register %d\n", n); + pr_warn("attempt to read from unknown breakpoint register %d\n", n); } return val; @@ -138,7 +138,7 @@ static void write_wb_reg(int reg, int n, u64 val) GEN_WRITE_WB_REG_CASES(AARCH64_DBG_REG_WVR, AARCH64_DBG_REG_NAME_WVR, val); GEN_WRITE_WB_REG_CASES(AARCH64_DBG_REG_WCR, AARCH64_DBG_REG_NAME_WCR, val); default: - pr_warning("attempt to write to unknown breakpoint register %d\n", n); + pr_warn("attempt to write to unknown breakpoint register %d\n", n); } isb(); } @@ -156,7 +156,7 @@ static enum dbg_active_el debug_exception_level(int privilege) case AARCH64_BREAKPOINT_EL1: return DBG_ACTIVE_EL1; default: - pr_warning("invalid breakpoint privilege level %d\n", privilege); + pr_warn("invalid breakpoint privilege level %d\n", privilege); return -EINVAL; } } diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index 827d52d78b67..9c396e34c090 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -925,8 +925,8 @@ void smp_send_stop(void) udelay(1); if (num_online_cpus() > 1) - pr_warning("SMP: failed to stop secondary CPUs %*pbl\n", - cpumask_pr_args(cpu_online_mask)); + pr_warn("SMP: failed to stop secondary CPUs %*pbl\n", + cpumask_pr_args(cpu_online_mask)); } /* -- 2.10.0.rc2.1.g053435c ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 03/35] arm64: Convert remaining uses of pr_warning to pr_warn 2017-02-17 7:11 ` [PATCH 03/35] arm64: " Joe Perches @ 2017-02-17 10:52 ` Mark Rutland 0 siblings, 0 replies; 17+ messages in thread From: Mark Rutland @ 2017-02-17 10:52 UTC (permalink / raw) To: linux-arm-kernel On Thu, Feb 16, 2017 at 11:11:16PM -0800, Joe Perches wrote: > To enable eventual removal of pr_warning > > This makes pr_warn use consistent for arch/arm64 > > Prior to this patch, there were 7 uses of pr_warning and > 27 uses of pr_warn in arch/arm64 > > Signed-off-by: Joe Perches <joe@perches.com> Looks nicer to me. Acked-by: Mark Rutland <mark.rutland@arm.com> Mark. > --- > arch/arm64/include/asm/syscall.h | 8 ++++---- > arch/arm64/kernel/hw_breakpoint.c | 8 ++++---- > arch/arm64/kernel/smp.c | 4 ++-- > 3 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/include/asm/syscall.h b/arch/arm64/include/asm/syscall.h > index 709a574468f0..231f2c3fcf81 100644 > --- a/arch/arm64/include/asm/syscall.h > +++ b/arch/arm64/include/asm/syscall.h > @@ -68,8 +68,8 @@ static inline void syscall_get_arguments(struct task_struct *task, > if (i + n > SYSCALL_MAX_ARGS) { > unsigned long *args_bad = args + SYSCALL_MAX_ARGS - i; > unsigned int n_bad = n + i - SYSCALL_MAX_ARGS; > - pr_warning("%s called with max args %d, handling only %d\n", > - __func__, i + n, SYSCALL_MAX_ARGS); > + pr_warn("%s called with max args %d, handling only %d\n", > + __func__, i + n, SYSCALL_MAX_ARGS); > memset(args_bad, 0, n_bad * sizeof(args[0])); > } > > @@ -92,8 +92,8 @@ static inline void syscall_set_arguments(struct task_struct *task, > return; > > if (i + n > SYSCALL_MAX_ARGS) { > - pr_warning("%s called with max args %d, handling only %d\n", > - __func__, i + n, SYSCALL_MAX_ARGS); > + pr_warn("%s called with max args %d, handling only %d\n", > + __func__, i + n, SYSCALL_MAX_ARGS); > n = SYSCALL_MAX_ARGS - i; > } > > diff --git a/arch/arm64/kernel/hw_breakpoint.c b/arch/arm64/kernel/hw_breakpoint.c > index 0296e7924240..6fa79ffd0c43 100644 > --- a/arch/arm64/kernel/hw_breakpoint.c > +++ b/arch/arm64/kernel/hw_breakpoint.c > @@ -62,7 +62,7 @@ int hw_breakpoint_slots(int type) > case TYPE_DATA: > return get_num_wrps(); > default: > - pr_warning("unknown slot type: %d\n", type); > + pr_warn("unknown slot type: %d\n", type); > return 0; > } > } > @@ -123,7 +123,7 @@ static u64 read_wb_reg(int reg, int n) > GEN_READ_WB_REG_CASES(AARCH64_DBG_REG_WVR, AARCH64_DBG_REG_NAME_WVR, val); > GEN_READ_WB_REG_CASES(AARCH64_DBG_REG_WCR, AARCH64_DBG_REG_NAME_WCR, val); > default: > - pr_warning("attempt to read from unknown breakpoint register %d\n", n); > + pr_warn("attempt to read from unknown breakpoint register %d\n", n); > } > > return val; > @@ -138,7 +138,7 @@ static void write_wb_reg(int reg, int n, u64 val) > GEN_WRITE_WB_REG_CASES(AARCH64_DBG_REG_WVR, AARCH64_DBG_REG_NAME_WVR, val); > GEN_WRITE_WB_REG_CASES(AARCH64_DBG_REG_WCR, AARCH64_DBG_REG_NAME_WCR, val); > default: > - pr_warning("attempt to write to unknown breakpoint register %d\n", n); > + pr_warn("attempt to write to unknown breakpoint register %d\n", n); > } > isb(); > } > @@ -156,7 +156,7 @@ static enum dbg_active_el debug_exception_level(int privilege) > case AARCH64_BREAKPOINT_EL1: > return DBG_ACTIVE_EL1; > default: > - pr_warning("invalid breakpoint privilege level %d\n", privilege); > + pr_warn("invalid breakpoint privilege level %d\n", privilege); > return -EINVAL; > } > } > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > index 827d52d78b67..9c396e34c090 100644 > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -925,8 +925,8 @@ void smp_send_stop(void) > udelay(1); > > if (num_online_cpus() > 1) > - pr_warning("SMP: failed to stop secondary CPUs %*pbl\n", > - cpumask_pr_args(cpu_online_mask)); > + pr_warn("SMP: failed to stop secondary CPUs %*pbl\n", > + cpumask_pr_args(cpu_online_mask)); > } > > /* > -- > 2.10.0.rc2.1.g053435c > ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn 2017-02-17 7:11 [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches 2017-02-17 7:11 ` [PATCH 02/35] ARM: ep93xx: Convert remaining uses of " Joe Perches 2017-02-17 7:11 ` [PATCH 03/35] arm64: " Joe Perches @ 2017-02-17 7:11 ` Joe Perches 2017-03-14 14:04 ` Lee Jones 2017-03-23 10:52 ` Lee Jones 2017-02-17 12:27 ` [PATCH 00/35] treewide trivial patches converting " Rafael J. Wysocki 2017-02-23 15:28 ` Rob Herring 4 siblings, 2 replies; 17+ messages in thread From: Joe Perches @ 2017-02-17 7:11 UTC (permalink / raw) To: linux-arm-kernel To enable eventual removal of pr_warning This makes pr_warn use consistent for drivers/mfd Prior to this patch, there were 4 uses of pr_warning and 9 uses of pr_warn in drivers/mfd Signed-off-by: Joe Perches <joe@perches.com> --- drivers/mfd/db8500-prcmu.c | 2 +- drivers/mfd/sta2x11-mfd.c | 4 ++-- drivers/mfd/twl4030-power.c | 7 ++----- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c index ca38a6a14110..5c739ac752e8 100644 --- a/drivers/mfd/db8500-prcmu.c +++ b/drivers/mfd/db8500-prcmu.c @@ -2377,7 +2377,7 @@ static void ack_dbb_wakeup(void) static inline void print_unknown_header_warning(u8 n, u8 header) { - pr_warning("prcmu: Unknown message header (%d) in mailbox %d.\n", + pr_warn("prcmu: Unknown message header (%d) in mailbox %d\n", header, n); } diff --git a/drivers/mfd/sta2x11-mfd.c b/drivers/mfd/sta2x11-mfd.c index 9292202039ee..3aeafa228baf 100644 --- a/drivers/mfd/sta2x11-mfd.c +++ b/drivers/mfd/sta2x11-mfd.c @@ -60,8 +60,8 @@ static struct sta2x11_mfd *sta2x11_mfd_find(struct pci_dev *pdev) struct sta2x11_mfd *mfd; if (!pdev && !list_empty(&sta2x11_mfd_list)) { - pr_warning("%s: Unspecified device, " - "using first instance\n", __func__); + pr_warn("%s: Unspecified device, using first instance\n", + __func__); return list_entry(sta2x11_mfd_list.next, struct sta2x11_mfd, list); } diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c index 1beb722f6080..8be023ba8e3e 100644 --- a/drivers/mfd/twl4030-power.c +++ b/drivers/mfd/twl4030-power.c @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata, } if (tscript->flags & TWL4030_SLEEP_SCRIPT) { if (!order) - pr_warning("TWL4030: Bad order of scripts (sleep "\ - "script before wakeup) Leads to boot"\ - "failure on some boards\n"); + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n"); err = twl4030_config_sleep_sequence(address); } out: @@ -929,8 +927,7 @@ static int twl4030_power_probe(struct platform_device *pdev) err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val, TWL4030_PM_MASTER_CFG_P123_TRANSITION); if (err) { - pr_warning("TWL4030 Unable to read registers\n"); - + pr_warn("TWL4030 Unable to read registers\n"); } else if (!(val & SEQ_OFFSYNC)) { val |= SEQ_OFFSYNC; err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val, -- 2.10.0.rc2.1.g053435c ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn 2017-02-17 7:11 ` [PATCH 23/35] drivers/mfd: " Joe Perches @ 2017-03-14 14:04 ` Lee Jones 2017-03-14 17:17 ` Joe Perches 2017-03-23 10:52 ` Lee Jones 1 sibling, 1 reply; 17+ messages in thread From: Lee Jones @ 2017-03-14 14:04 UTC (permalink / raw) To: linux-arm-kernel On Thu, 16 Feb 2017, Joe Perches wrote: > To enable eventual removal of pr_warning > > This makes pr_warn use consistent for drivers/mfd > > Prior to this patch, there were 4 uses of pr_warning and > 9 uses of pr_warn in drivers/mfd > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/mfd/db8500-prcmu.c | 2 +- > drivers/mfd/sta2x11-mfd.c | 4 ++-- > drivers/mfd/twl4030-power.c | 7 ++----- > 3 files changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c > index ca38a6a14110..5c739ac752e8 100644 > --- a/drivers/mfd/db8500-prcmu.c > +++ b/drivers/mfd/db8500-prcmu.c > @@ -2377,7 +2377,7 @@ static void ack_dbb_wakeup(void) > > static inline void print_unknown_header_warning(u8 n, u8 header) > { > - pr_warning("prcmu: Unknown message header (%d) in mailbox %d.\n", > + pr_warn("prcmu: Unknown message header (%d) in mailbox %d\n", > header, n); > } > > diff --git a/drivers/mfd/sta2x11-mfd.c b/drivers/mfd/sta2x11-mfd.c > index 9292202039ee..3aeafa228baf 100644 > --- a/drivers/mfd/sta2x11-mfd.c > +++ b/drivers/mfd/sta2x11-mfd.c > @@ -60,8 +60,8 @@ static struct sta2x11_mfd *sta2x11_mfd_find(struct pci_dev *pdev) > struct sta2x11_mfd *mfd; > > if (!pdev && !list_empty(&sta2x11_mfd_list)) { > - pr_warning("%s: Unspecified device, " > - "using first instance\n", __func__); > + pr_warn("%s: Unspecified device, using first instance\n", > + __func__); > return list_entry(sta2x11_mfd_list.next, > struct sta2x11_mfd, list); > } > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > index 1beb722f6080..8be023ba8e3e 100644 > --- a/drivers/mfd/twl4030-power.c > +++ b/drivers/mfd/twl4030-power.c > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata, > } > if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > if (!order) > - pr_warning("TWL4030: Bad order of scripts (sleep "\ > - "script before wakeup) Leads to boot"\ > - "failure on some boards\n"); > + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n"); Is 80 chars considered the lessor sin? > err = twl4030_config_sleep_sequence(address); > } > out: > @@ -929,8 +927,7 @@ static int twl4030_power_probe(struct platform_device *pdev) > err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val, > TWL4030_PM_MASTER_CFG_P123_TRANSITION); > if (err) { > - pr_warning("TWL4030 Unable to read registers\n"); > - > + pr_warn("TWL4030 Unable to read registers\n"); > } else if (!(val & SEQ_OFFSYNC)) { > val |= SEQ_OFFSYNC; > err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn 2017-03-14 14:04 ` Lee Jones @ 2017-03-14 17:17 ` Joe Perches 2017-03-15 12:23 ` Lee Jones 0 siblings, 1 reply; 17+ messages in thread From: Joe Perches @ 2017-03-14 17:17 UTC (permalink / raw) To: linux-arm-kernel On Tue, 2017-03-14 at 14:04 +0000, Lee Jones wrote: > On Thu, 16 Feb 2017, Joe Perches wrote: > > To enable eventual removal of pr_warning [] > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c [] > > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata, > > } > > if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > > if (!order) > > - pr_warning("TWL4030: Bad order of scripts (sleep "\ > > - "script before wakeup) Leads to boot"\ > > - "failure on some boards\n"); > > + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n"); > > Is 80 chars considered the lessor sin? Splitting logging messages into multiple lines is non preferred. Documentation/process/coding-style.rst: Breaking long lines and strings: never break user-visible strings such as printk messages, because that breaks the ability to grep for them. ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn 2017-03-14 17:17 ` Joe Perches @ 2017-03-15 12:23 ` Lee Jones 2017-03-15 14:17 ` Joe Perches 0 siblings, 1 reply; 17+ messages in thread From: Lee Jones @ 2017-03-15 12:23 UTC (permalink / raw) To: linux-arm-kernel On Tue, 14 Mar 2017, Joe Perches wrote: > On Tue, 2017-03-14 at 14:04 +0000, Lee Jones wrote: > > On Thu, 16 Feb 2017, Joe Perches wrote: > > > To enable eventual removal of pr_warning > [] > > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > [] > > > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata, > > > } > > > if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > > > if (!order) > > > - pr_warning("TWL4030: Bad order of scripts (sleep "\ > > > - "script before wakeup) Leads to boot"\ > > > - "failure on some boards\n"); > > > + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n"); > > > > Is 80 chars considered the lessor sin? > > Splitting logging messages into multiple lines is non preferred. > > Documentation/process/coding-style.rst: > > Breaking long lines and strings: > > never break user-visible strings such as > printk messages, because that breaks the ability to grep for them. Right, I'm aware of this. I'm also aware of the other rule we have where lines are not to exceed 80 chars. Hence my question; "is the 80 chars rule the lessor sin of the two". Rock <=> hard place Actually I would say that the error message sub-optimal and could, in fact be edited to be more succinct, thus not breaking any rules. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn 2017-03-15 12:23 ` Lee Jones @ 2017-03-15 14:17 ` Joe Perches 0 siblings, 0 replies; 17+ messages in thread From: Joe Perches @ 2017-03-15 14:17 UTC (permalink / raw) To: linux-arm-kernel On Wed, 2017-03-15 at 12:23 +0000, Lee Jones wrote: > On Tue, 14 Mar 2017, Joe Perches wrote: [] > > never break user-visible strings such as > > printk messages, because that breaks the ability to grep for them. > > Right, I'm aware of this. I'm also aware of the other rule we have > where lines are not to exceed 80 chars. Hence my question; "is the 80 > chars rule the lessor sin of the two". > > Rock <=> hard place > > Actually I would say that the error message sub-optimal and could, in > fact be edited to be more succinct, thus not breaking any rules. It's not a 'sin' at all. The rule is to exceed 80 columns when the logging message format is long. I didn't even look at the format content. Change it if you wish. ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn 2017-02-17 7:11 ` [PATCH 23/35] drivers/mfd: " Joe Perches 2017-03-14 14:04 ` Lee Jones @ 2017-03-23 10:52 ` Lee Jones 1 sibling, 0 replies; 17+ messages in thread From: Lee Jones @ 2017-03-23 10:52 UTC (permalink / raw) To: linux-arm-kernel > To enable eventual removal of pr_warning > > This makes pr_warn use consistent for drivers/mfd > > Prior to this patch, there were 4 uses of pr_warning and > 9 uses of pr_warn in drivers/mfd > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/mfd/db8500-prcmu.c | 2 +- > drivers/mfd/sta2x11-mfd.c | 4 ++-- > drivers/mfd/twl4030-power.c | 7 ++----- > 3 files changed, 5 insertions(+), 8 deletions(-) Applied. (... and I corrected the $SUBJECT line on your behalf) > diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c > index ca38a6a14110..5c739ac752e8 100644 > --- a/drivers/mfd/db8500-prcmu.c > +++ b/drivers/mfd/db8500-prcmu.c > @@ -2377,7 +2377,7 @@ static void ack_dbb_wakeup(void) > > static inline void print_unknown_header_warning(u8 n, u8 header) > { > - pr_warning("prcmu: Unknown message header (%d) in mailbox %d.\n", > + pr_warn("prcmu: Unknown message header (%d) in mailbox %d\n", > header, n); > } > > diff --git a/drivers/mfd/sta2x11-mfd.c b/drivers/mfd/sta2x11-mfd.c > index 9292202039ee..3aeafa228baf 100644 > --- a/drivers/mfd/sta2x11-mfd.c > +++ b/drivers/mfd/sta2x11-mfd.c > @@ -60,8 +60,8 @@ static struct sta2x11_mfd *sta2x11_mfd_find(struct pci_dev *pdev) > struct sta2x11_mfd *mfd; > > if (!pdev && !list_empty(&sta2x11_mfd_list)) { > - pr_warning("%s: Unspecified device, " > - "using first instance\n", __func__); > + pr_warn("%s: Unspecified device, using first instance\n", > + __func__); > return list_entry(sta2x11_mfd_list.next, > struct sta2x11_mfd, list); > } > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > index 1beb722f6080..8be023ba8e3e 100644 > --- a/drivers/mfd/twl4030-power.c > +++ b/drivers/mfd/twl4030-power.c > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata, > } > if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > if (!order) > - pr_warning("TWL4030: Bad order of scripts (sleep "\ > - "script before wakeup) Leads to boot"\ > - "failure on some boards\n"); > + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n"); > err = twl4030_config_sleep_sequence(address); > } > out: > @@ -929,8 +927,7 @@ static int twl4030_power_probe(struct platform_device *pdev) > err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val, > TWL4030_PM_MASTER_CFG_P123_TRANSITION); > if (err) { > - pr_warning("TWL4030 Unable to read registers\n"); > - > + pr_warn("TWL4030 Unable to read registers\n"); > } else if (!(val & SEQ_OFFSYNC)) { > val |= SEQ_OFFSYNC; > err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn 2017-02-17 7:11 [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches ` (2 preceding siblings ...) 2017-02-17 7:11 ` [PATCH 23/35] drivers/mfd: " Joe Perches @ 2017-02-17 12:27 ` Rafael J. Wysocki 2017-02-17 12:37 ` Geert Uytterhoeven 2017-02-23 15:28 ` Rob Herring 4 siblings, 1 reply; 17+ messages in thread From: Rafael J. Wysocki @ 2017-02-17 12:27 UTC (permalink / raw) To: linux-arm-kernel On Fri, Feb 17, 2017 at 8:11 AM, Joe Perches <joe@perches.com> wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate > define pr_warning for that directory tree and pr_warn is > not used in tools/. > > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. Sorry about asking if that has been asked already. Wouldn't it be slightly less intrusive to simply redefined pr_warning() as a synonym for pr_warn()? Thanks, Rafael ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn 2017-02-17 12:27 ` [PATCH 00/35] treewide trivial patches converting " Rafael J. Wysocki @ 2017-02-17 12:37 ` Geert Uytterhoeven 0 siblings, 0 replies; 17+ messages in thread From: Geert Uytterhoeven @ 2017-02-17 12:37 UTC (permalink / raw) To: linux-arm-kernel Hi Rafael, On Fri, Feb 17, 2017 at 1:27 PM, Rafael J. Wysocki <rafael@kernel.org> wrote: > On Fri, Feb 17, 2017 at 8:11 AM, Joe Perches <joe@perches.com> wrote: >> There are ~4300 uses of pr_warn and ~250 uses of the older >> pr_warning in the kernel source tree. >> >> Make the use of pr_warn consistent across all kernel files. >> >> This excludes all files in tools/ as there is a separate >> define pr_warning for that directory tree and pr_warn is >> not used in tools/. >> >> Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. > > Sorry about asking if that has been asked already. > > Wouldn't it be slightly less intrusive to simply redefined > pr_warning() as a synonym for pr_warn()? That's already the case. This series cleans up the cruft, so we can catch all users with "git grep -w pr_warn". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn 2017-02-17 7:11 [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches ` (3 preceding siblings ...) 2017-02-17 12:27 ` [PATCH 00/35] treewide trivial patches converting " Rafael J. Wysocki @ 2017-02-23 15:28 ` Rob Herring 2017-02-23 17:18 ` Joe Perches 4 siblings, 1 reply; 17+ messages in thread From: Rob Herring @ 2017-02-23 15:28 UTC (permalink / raw) To: linux-arm-kernel On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe@perches.com> wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate > define pr_warning for that directory tree and pr_warn is > not used in tools/. > > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. > > Miscellanea: > > o Coalesce formats and realign arguments > > Some files not compiled - no cross-compilers > > Joe Perches (35): > alpha: Convert remaining uses of pr_warning to pr_warn > ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn > arm64: Convert remaining uses of pr_warning to pr_warn > arch/blackfin: Convert remaining uses of pr_warning to pr_warn > ia64: Convert remaining use of pr_warning to pr_warn > powerpc: Convert remaining uses of pr_warning to pr_warn > sh: Convert remaining uses of pr_warning to pr_warn > sparc: Convert remaining use of pr_warning to pr_warn > x86: Convert remaining uses of pr_warning to pr_warn > drivers/acpi: Convert remaining uses of pr_warning to pr_warn > block/drbd: Convert remaining uses of pr_warning to pr_warn > gdrom: Convert remaining uses of pr_warning to pr_warn > drivers/char: Convert remaining use of pr_warning to pr_warn > clocksource: Convert remaining use of pr_warning to pr_warn > drivers/crypto: Convert remaining uses of pr_warning to pr_warn > fmc: Convert remaining use of pr_warning to pr_warn > drivers/gpu: Convert remaining uses of pr_warning to pr_warn > drivers/ide: Convert remaining uses of pr_warning to pr_warn > drivers/input: Convert remaining uses of pr_warning to pr_warn > drivers/isdn: Convert remaining uses of pr_warning to pr_warn > drivers/macintosh: Convert remaining uses of pr_warning to pr_warn > drivers/media: Convert remaining use of pr_warning to pr_warn > drivers/mfd: Convert remaining uses of pr_warning to pr_warn > drivers/mtd: Convert remaining uses of pr_warning to pr_warn > drivers/of: Convert remaining uses of pr_warning to pr_warn > drivers/oprofile: Convert remaining uses of pr_warning to pr_warn > drivers/platform: Convert remaining uses of pr_warning to pr_warn > drivers/rapidio: Convert remaining use of pr_warning to pr_warn > drivers/scsi: Convert remaining use of pr_warning to pr_warn > drivers/sh: Convert remaining use of pr_warning to pr_warn > drivers/tty: Convert remaining uses of pr_warning to pr_warn > drivers/video: Convert remaining uses of pr_warning to pr_warn > kernel/trace: Convert remaining uses of pr_warning to pr_warn > lib: Convert remaining uses of pr_warning to pr_warn > sound/soc: Convert remaining uses of pr_warning to pr_warn Where's the removal of pr_warning so we don't have more sneak in? Rob ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn 2017-02-23 15:28 ` Rob Herring @ 2017-02-23 17:18 ` Joe Perches 2017-02-23 17:41 ` Emil Velikov 0 siblings, 1 reply; 17+ messages in thread From: Joe Perches @ 2017-02-23 17:18 UTC (permalink / raw) To: linux-arm-kernel On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe@perches.com> wrote: > > There are ~4300 uses of pr_warn and ~250 uses of the older > > pr_warning in the kernel source tree. > > > > Make the use of pr_warn consistent across all kernel files. > > > > This excludes all files in tools/ as there is a separate > > define pr_warning for that directory tree and pr_warn is > > not used in tools/. > > > > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. [] > Where's the removal of pr_warning so we don't have more sneak in? After all of these actually get applied, and maybe a cycle or two later, one would get sent. ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn 2017-02-23 17:18 ` Joe Perches @ 2017-02-23 17:41 ` Emil Velikov 2017-02-23 17:53 ` Joe Perches 0 siblings, 1 reply; 17+ messages in thread From: Emil Velikov @ 2017-02-23 17:41 UTC (permalink / raw) To: linux-arm-kernel On 23 February 2017 at 17:18, Joe Perches <joe@perches.com> wrote: > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: >> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe@perches.com> wrote: >> > There are ~4300 uses of pr_warn and ~250 uses of the older >> > pr_warning in the kernel source tree. >> > >> > Make the use of pr_warn consistent across all kernel files. >> > >> > This excludes all files in tools/ as there is a separate >> > define pr_warning for that directory tree and pr_warn is >> > not used in tools/. >> > >> > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. > [] >> Where's the removal of pr_warning so we don't have more sneak in? > > After all of these actually get applied, > and maybe a cycle or two later, one would > get sent. > By which point you'll get a few reincarnation of it. So you'll have to do the same exercise again :-( I guess the question is - are you expecting to get the series merged all together/via one tree ? If not, your plan is perfectly reasonable. Fwiw in the DRM subsystem, similar cleanups does purge the respective macros/other with the final commit. But there one can pull the lot in one go. Regards, Emil ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn 2017-02-23 17:41 ` Emil Velikov @ 2017-02-23 17:53 ` Joe Perches 0 siblings, 0 replies; 17+ messages in thread From: Joe Perches @ 2017-02-23 17:53 UTC (permalink / raw) To: linux-arm-kernel On Thu, 2017-02-23 at 17:41 +0000, Emil Velikov wrote: > On 23 February 2017 at 17:18, Joe Perches <joe@perches.com> wrote: > > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > > > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe@perches.com> wrote: > > > > There are ~4300 uses of pr_warn and ~250 uses of the older > > > > pr_warning in the kernel source tree. > > > > > > > > Make the use of pr_warn consistent across all kernel files. > > > > > > > > This excludes all files in tools/ as there is a separate > > > > define pr_warning for that directory tree and pr_warn is > > > > not used in tools/. > > > > > > > > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. > > > > [] > > > Where's the removal of pr_warning so we don't have more sneak in? > > > > After all of these actually get applied, > > and maybe a cycle or two later, one would > > get sent. > > > > By which point you'll get a few reincarnation of it. So you'll have to > do the same exercise again :-( Maybe to one or two files. Not a big deal. > I guess the question is - are you expecting to get the series merged > all together/via one tree ? No. The only person that could do that effectively is Linus. > If not, your plan is perfectly reasonable. ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2017-03-23 10:52 UTC | newest] Thread overview: 17+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-02-17 7:11 [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches 2017-02-17 7:11 ` [PATCH 02/35] ARM: ep93xx: Convert remaining uses of " Joe Perches 2017-02-17 16:26 ` Hartley Sweeten 2017-02-17 7:11 ` [PATCH 03/35] arm64: " Joe Perches 2017-02-17 10:52 ` Mark Rutland 2017-02-17 7:11 ` [PATCH 23/35] drivers/mfd: " Joe Perches 2017-03-14 14:04 ` Lee Jones 2017-03-14 17:17 ` Joe Perches 2017-03-15 12:23 ` Lee Jones 2017-03-15 14:17 ` Joe Perches 2017-03-23 10:52 ` Lee Jones 2017-02-17 12:27 ` [PATCH 00/35] treewide trivial patches converting " Rafael J. Wysocki 2017-02-17 12:37 ` Geert Uytterhoeven 2017-02-23 15:28 ` Rob Herring 2017-02-23 17:18 ` Joe Perches 2017-02-23 17:41 ` Emil Velikov 2017-02-23 17:53 ` Joe Perches
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).