[PATCH] arm64: dts: renesas: sparrow-hawk: Disable dtc spi_bus_bridge check

[PATCH] arm64: dts: renesas: sparrow-hawk: Disable dtc spi_bus_bridge check

[Geert Uytterhoeven]

make dtbs:

    arch/arm64/boot/dts/renesas/r8a779g0.dtsi:1269.24-1283.5: Warning (spi_bus_bridge): /soc/spi@e6ea0000: incorrect #address-cells for SPI bus
      also defined at arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts:471.9-486.3
    arch/arm64/boot/dts/renesas/r8a779g0.dtsi:1269.24-1283.5: Warning (spi_bus_bridge): /soc/spi@e6ea0000: incorrect #size-cells for SPI bus
      also defined at arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts:471.9-486.3
    arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge'

The Sparrow Hawk uses the MSIOF module in I2S mode instead of SPI mode,
triggering a conflict between the SPI bus bindings and dtc:
  - Serial engines that can be SPI controllers must use "spi" as their
    node names,
  - Dtc assumes nodes named "spi" are always SPI controllers.

Fix this by disabling this specific warning for this board.

Fixes: ca764d5321a2cee7 ("arm64: dts: renesas: sparrow-hawk: Add MSIOF Sound support")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/20250506192033.77338015@canb.auug.org.au
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
To be queued in renesas-devel for v6.16.

 arch/arm64/boot/dts/renesas/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 21baaa25346744dd..58a498059cf5f2ca 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -94,6 +94,7 @@ dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g2-white-hawk-single.dtb
 r8a779g2-white-hawk-single-ard-audio-da7212-dtbs := r8a779g2-white-hawk-single.dtb white-hawk-ard-audio-da7212.dtbo
 dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g2-white-hawk-single-ard-audio-da7212.dtb
 
+DTC_FLAGS_r8a779g3-sparrow-hawk += -Wno-spi_bus_bridge
 dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g3-sparrow-hawk.dtb
 r8a779g3-sparrow-hawk-fan-pwm-dtbs := r8a779g3-sparrow-hawk.dtb r8a779g3-sparrow-hawk-fan-pwm.dtbo
 dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g3-sparrow-hawk-fan-pwm.dtb
-- 
2.43.0

Re: [PATCH] arm64: dts: renesas: sparrow-hawk: Disable dtc spi_bus_bridge check

[Kuninori Morimoto]

Hi Geert
To: Mark

> make dtbs:
> 
>     arch/arm64/boot/dts/renesas/r8a779g0.dtsi:1269.24-1283.5: Warning (spi_bus_bridge): /soc/spi@e6ea0000: incorrect #address-cells for SPI bus
>       also defined at arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts:471.9-486.3
>     arch/arm64/boot/dts/renesas/r8a779g0.dtsi:1269.24-1283.5: Warning (spi_bus_bridge): /soc/spi@e6ea0000: incorrect #size-cells for SPI bus
>       also defined at arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts:471.9-486.3
>     arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge'
> 
> The Sparrow Hawk uses the MSIOF module in I2S mode instead of SPI mode,
> triggering a conflict between the SPI bus bindings and dtc:
>   - Serial engines that can be SPI controllers must use "spi" as their
>     node names,
>   - Dtc assumes nodes named "spi" are always SPI controllers.
> 
> Fix this by disabling this specific warning for this board.
> 
> Fixes: ca764d5321a2cee7 ("arm64: dts: renesas: sparrow-hawk: Add MSIOF Sound support")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/20250506192033.77338015@canb.auug.org.au
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
(snip)
> +DTC_FLAGS_r8a779g3-sparrow-hawk += -Wno-spi_bus_bridge

Thank you for the patch.

But I still get the same warning. I'm using latest linux-next/master
+ this patch. And run this. Am I missing something ?

	> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml

Best regards
---
Kuninori Morimoto

-- 

Re: [PATCH] arm64: dts: renesas: sparrow-hawk: Disable dtc spi_bus_bridge check

[Geert Uytterhoeven]

Hi Morimoto-san,

On Tue, 13 May 2025 at 01:28, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> > make dtbs:
> >
> >     arch/arm64/boot/dts/renesas/r8a779g0.dtsi:1269.24-1283.5: Warning (spi_bus_bridge): /soc/spi@e6ea0000: incorrect #address-cells for SPI bus
> >       also defined at arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts:471.9-486.3
> >     arch/arm64/boot/dts/renesas/r8a779g0.dtsi:1269.24-1283.5: Warning (spi_bus_bridge): /soc/spi@e6ea0000: incorrect #size-cells for SPI bus
> >       also defined at arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts:471.9-486.3
> >     arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge'
> >
> > The Sparrow Hawk uses the MSIOF module in I2S mode instead of SPI mode,
> > triggering a conflict between the SPI bus bindings and dtc:
> >   - Serial engines that can be SPI controllers must use "spi" as their
> >     node names,
> >   - Dtc assumes nodes named "spi" are always SPI controllers.
> >
> > Fix this by disabling this specific warning for this board.
> >
> > Fixes: ca764d5321a2cee7 ("arm64: dts: renesas: sparrow-hawk: Add MSIOF Sound support")
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Closes: https://lore.kernel.org/20250506192033.77338015@canb.auug.org.au
> > Suggested-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> (snip)
> > +DTC_FLAGS_r8a779g3-sparrow-hawk += -Wno-spi_bus_bridge
>
> Thank you for the patch.
>
> But I still get the same warning. I'm using latest linux-next/master
> + this patch. And run this. Am I missing something ?
>
>         > make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml

Works for me:

$ git checkout next-20250512
$ rm -f arch/arm64/boot/dts/renesas/r8a779g3-*dtb; ARCH=arm64
CROSS_COMPILE=aarch64-linux-gnu- make -j 12 defconfig dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
[...]
arch/arm64/boot/dts/renesas/r8a779g0.dtsi:1269.24-1283.5: Warning
(spi_bus_bridge): /soc/spi@e6ea0000: incorrect #address-cells for SPI
bus
  also defined at
arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts:471.9-486.3
arch/arm64/boot/dts/renesas/r8a779g0.dtsi:1269.24-1283.5: Warning
(spi_bus_bridge): /soc/spi@e6ea0000: incorrect #size-cells for SPI bus
  also defined at
arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts:471.9-486.3
arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dtb: Warning
(spi_bus_reg): Failed prerequisite 'spi_bus_bridge'
[...]
$ git am 20250512_geert_renesas_arm64_dts_renesas_sparrow_hawk_disable_dtc_spi_bus_bridge_check.mbx
$ rm -f arch/arm64/boot/dts/renesas/r8a779g3-*dtb; ARCH=arm64
CROSS_COMPILE=aarch64-linux-gnu- make -j 12 defconfig dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
[... no warning]

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds