linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: geert@linux-m68k.org (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] arm64: dts: renesas: r8a7796: sort subnodes of the soc node
Date: Fri, 23 Mar 2018 09:49:08 +0100	[thread overview]
Message-ID: <CAMuHMdX-Sm2fnnw7DRxNHgJqppjKuWgS6M_uE38URxM6GwHdBg@mail.gmail.com> (raw)
In-Reply-To: <20180322102423.18269-5-horms+renesas@verge.net.au>

Hi Simon,

On Thu, Mar 22, 2018 at 11:24 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> Sort subnodes of the soc node.
> - The primary key is the bus address.
> - The secondary key is the IP block.
> - The tertiary key is the node name.
>
> This is part of an ongoing effort to provide consistent node
> order in the DT of Renesas SoCs to improve maintainability.
>
> This should not have any run-time effect.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
using dtx_diff, and "grep '@.*{', which tells me

> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi

>                 pciec0: pcie at fe000000 {
> @@ -1860,6 +1838,43 @@
>                         /* placeholder */
>                 };
>
> +               gic: interrupt-controller at f1010000 {

Probably gic should be before pciec0.
Currently it's after pciec1, which has a lower address than pciec1.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2018-03-23  8:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 10:24 [PATCH v2 0/4] arm64: dts: renesas: r8a779[56]: sort nodes Simon Horman
2018-03-22 10:24 ` [PATCH v2 1/4] arm64: dts: renesas: r8a7795: sort subnodes of the root node Simon Horman
2018-03-23  8:36   ` Geert Uytterhoeven
2018-03-23  8:58     ` Simon Horman
2018-03-22 10:24 ` [PATCH v2 2/4] arm64: dts: renesas: r8a7795: sort subnodes of the soc node Simon Horman
2018-03-23  8:41   ` Geert Uytterhoeven
2018-03-23  9:05     ` Simon Horman
2018-03-22 10:24 ` [PATCH v2 3/4] arm64: dts: renesas: r8a7796: sort subnodes of the root node Simon Horman
2018-03-23  8:37   ` Geert Uytterhoeven
2018-03-23  9:02     ` Simon Horman
2018-03-22 10:24 ` [PATCH v2 4/4] arm64: dts: renesas: r8a7796: sort subnodes of the soc node Simon Horman
2018-03-23  8:49   ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdX-Sm2fnnw7DRxNHgJqppjKuWgS6M_uE38URxM6GwHdBg@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).