From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Fri, 23 Mar 2018 09:49:08 +0100 Subject: [PATCH v2 4/4] arm64: dts: renesas: r8a7796: sort subnodes of the soc node In-Reply-To: <20180322102423.18269-5-horms+renesas@verge.net.au> References: <20180322102423.18269-1-horms+renesas@verge.net.au> <20180322102423.18269-5-horms+renesas@verge.net.au> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Simon, On Thu, Mar 22, 2018 at 11:24 AM, Simon Horman wrote: > Sort subnodes of the soc node. > - The primary key is the bus address. > - The secondary key is the IP block. > - The tertiary key is the node name. > > This is part of an ongoing effort to provide consistent node > order in the DT of Renesas SoCs to improve maintainability. > > This should not have any run-time effect. > > Signed-off-by: Simon Horman Thanks for your patch! Reviewed-by: Geert Uytterhoeven using dtx_diff, and "grep '@.*{', which tells me > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > pciec0: pcie at fe000000 { > @@ -1860,6 +1838,43 @@ > /* placeholder */ > }; > > + gic: interrupt-controller at f1010000 { Probably gic should be before pciec0. Currently it's after pciec1, which has a lower address than pciec1. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds