From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F651CEFC24 for ; Tue, 8 Oct 2024 15:18:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xNkp0597olvl4BH+GQsjOjO3dePD7p4cBzVhPvQBAu0=; b=GNSZFj3U5bfTrqObDN9RcurTGb bbbwpSmy/JU69kGS9VMAZBEid56dTGqFVVWYwh/pz/Hg//QhKJEe28q3+9bex9psFUbITkljTfV4Z 2VJ8F+SD5d7BG2sBxQeY8lue72wkY8xdFK17m3h7hFpwGdz+otS78/afRCWu/E+z8b0SWvl99APeT 5wUJvzAG/TDWv87yShMiulg4brZLUJtCuKO3FyFAMP5nREF5XoBM6mHZBcDENP1Kbu7VfAc+5N3uO 0RL3Yl27RCYYUvv/d4QpH5rEI9d3CkuadftTRQE8KEjwjHXv3kD5THIFVnQmGC2MOBv+em3NRLDhJ /Fnd+o4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syByh-00000006L1Z-3GkK; Tue, 08 Oct 2024 15:18:23 +0000 Received: from mail-yw1-f172.google.com ([209.85.128.172]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syBxN-00000006KfT-1U6C; Tue, 08 Oct 2024 15:17:02 +0000 Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-6db20e22c85so45578027b3.0; Tue, 08 Oct 2024 08:17:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728400619; x=1729005419; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xNkp0597olvl4BH+GQsjOjO3dePD7p4cBzVhPvQBAu0=; b=GJ7FcIZg4ENZE/dlIKrg/qjBcRwbm/KcUuI0x5iYyojslMONivam7tc+85KngBRPzz PquIQmz6WlbnTGwri1J7Dhr8dVkcrSZ2sJtUYrsUk/YAS/PQxAVomb2F9krhOvMAwiI0 fH7waVVNBFnIOKl6vyGqvu/Ypr+DCFDci2T63AC6pPiXSf/kCyPUL2XdGgpdPnX8GHxj jjl++pmuRzN1Ti73+3ygLCCxGw5mcIJtIwECwwG2+y/E0Gx4bmuCJlpM2MymPXYRZVKu lfN6ttJyHeJJoXdQVeUwBqx5Wz1AUgHE8+Ze1MMwu3VkNu0pEvCH22Le8EWZnnaT5ngN ptig== X-Forwarded-Encrypted: i=1; AJvYcCWUrGwXd4HG4nOjQXU2TFnYngGXOQ8Qx9IR7D1lJK6+f9MZGyhwjLjKGbDdQO9FIOEmjzhZ/yXaewlF@lists.infradead.org, AJvYcCXfhI55XLxxgZnlBTY298B7u9GuPoVV6hdJIG1k8vouCRbbfhyBtAZRVi1xzwAve22VyZFy61aVkDLfbuTimKgG@lists.infradead.org X-Gm-Message-State: AOJu0YxTg8fLHMsYL4Pc01KTciEUhqrGEI2mlWvduGN6f76SULK/gYUd gzzqcQKMAQnL0xof8AaPiGQe6zZ5fNwJf9qrWk9T6pIzK6/p+gQxiXp24V+q X-Google-Smtp-Source: AGHT+IGLvDHXR1tCM6eiaWrVGgRfcljdq07jRXYYy+P8xaixcDktzFWvwa4sPlutPeaSUAjurbeKog== X-Received: by 2002:a05:690c:ec5:b0:6e2:1626:fc4a with SMTP id 00721157ae682-6e2c6fdd16emr151083647b3.9.1728400614521; Tue, 08 Oct 2024 08:16:54 -0700 (PDT) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com. [209.85.128.173]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6e2d93f8f43sm14443907b3.140.2024.10.08.08.16.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2024 08:16:53 -0700 (PDT) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-6e2ef9af517so21922997b3.1; Tue, 08 Oct 2024 08:16:53 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCV/brFsOOgbhbxKqCdF/Rq/SplDQcMhqA94GizeMcwk9Nx60WZxD57LxBCfyUbsq22qgkdWMmOCgYpuSAw8HcwS@lists.infradead.org, AJvYcCWKIAp4TyPtKnbrlefMl2ZkkHoRKgJOn8MUOjMO42SzbYJN24Aly8uyEvbVx0K5++WJ/0ksEQo3qszE@lists.infradead.org X-Received: by 2002:a05:690c:f88:b0:6e2:3e17:1849 with SMTP id 00721157ae682-6e2ecb69a8amr76258537b3.2.1728400613366; Tue, 08 Oct 2024 08:16:53 -0700 (PDT) MIME-Version: 1.0 References: <20240822152801.602318-1-claudiu.beznea.uj@bp.renesas.com> <20240822152801.602318-16-claudiu.beznea.uj@bp.renesas.com> In-Reply-To: <20240822152801.602318-16-claudiu.beznea.uj@bp.renesas.com> From: Geert Uytterhoeven Date: Tue, 8 Oct 2024 17:16:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 15/16] arm64: dts: renesas: rzg3s-smarc: Enable USB support To: Claudiu Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, magnus.damm@gmail.com, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, yoshihiro.shimoda.uh@renesas.com, biju.das.jz@bp.renesas.com, ulf.hansson@linaro.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Claudiu Beznea Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_081701_413232_01420744 X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Claudiu, On Thu, Aug 22, 2024 at 5:28=E2=80=AFPM Claudiu = wrote: > From: Claudiu Beznea > > Enable USB support (host, device, USB PHYs and sysc). > > Signed-off-by: Claudiu Beznea Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi > +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi > @@ -144,3 +188,20 @@ &sdhi1 { > max-frequency =3D <125000000>; > status =3D "okay"; > }; > + > +&sysc { > + status =3D "okay"; > +}; > + To avoid regressions (/sys/devices/soc0/ disappearing), enabling sysc is a dependency for "[PATCH 05/16] soc: renesas: sysc: Move RZ/G3S SoC detection on SYSC driver", so I think it makes sense to change its status to "okay" in r9a08g045.dtsi instead, and spin that off into its own patch. I am not super-worried, so doing the driver and DTS changes in separate patches should be fine, as long as they meet each other in next or upstream. The rest LGTM. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds