From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 217A4C17445 for ; Mon, 11 Nov 2019 16:58:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E37FB2184C for ; Mon, 11 Nov 2019 16:58:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T5CJSDIS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E37FB2184C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/E4oR1Cuz+eRHLz/838cvbrthG9h9owSpoHWJ4AByAY=; b=T5CJSDISpJWqwG L3N8u3INgW35PJ6naZIoZ3JCrmxifdNwrVWa5V7S46svj9C1Ey1BSceZyzmRp3Gr0uqR6zU1sg2r2 EmYScjSrR414WzwSIUOWMjnoxWbWUQJTXyXjvMkpkUVCRAp3IhVkl9tzRHA2aQTK0WGsJjbz8DRIJ VYE7oCZZtPeadxIxd1v4rVMiiXjGk+d4CsYalIxb+FZvZmbg4GVruMdx9NOFqKE7vLm3w1hL5puCn uIAgCzEmClwmJB1HVQl5h+x1ND2NBQURFUjx2hCKdi9iT4wZQytsE4tdLxfA8lNv+CTLndgWOvxxw 0oCjr0Qvv0yiqB98lFmA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUD1B-0005Eh-KD; Mon, 11 Nov 2019 16:58:21 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUD18-0005EI-Do for linux-arm-kernel@lists.infradead.org; Mon, 11 Nov 2019 16:58:19 +0000 Received: by mail-oi1-f194.google.com with SMTP id 22so12090913oip.7 for ; Mon, 11 Nov 2019 08:58:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N5Vcj3yE2rkXP4doP0O2V7gRihUnv+nSjX4pf/13Rw8=; b=Ued1IOp89uIlM5/o6VXExKIJ5CLmvM1rrCq0dt39JiFOg5FtMYtsEZa0uwyPe+HZPS BcHJ0wGuGexvSCOgi7hhO70OIi6n8uRkGoiarqMTA+2gGXe9sBgeRHFUHAQyzfztAmSM p1qjBczspuLrkOYT8YyEG/aDIBve7x9lGiS12e9ss9xoYEkyp8fc1FMVGbO6NdijsXk6 UIB2UducsqL429QuF+witeKIoDTJUiYWGlERVYrAV7FfRQ5w2cq6ZdGiMIwjDXTJ+WmY VklsdkTYzZn9uhDL8gMT4TSXyFI4pwYN66gNwflxNHEkInlZpzNdeo2I9LWKu40lU+sW uwxg== X-Gm-Message-State: APjAAAV017/E7NWPYdcOZeMlfqzla/VURpD5j6VdLdwz+1SqvY3RiEsT CgCHDovxousHLLgpdDPMZivHlWxjr1Mt1atdVfE= X-Google-Smtp-Source: APXvYqy/vMjYcYeqIvTqdLd5GGnLez7ZmWGDKl5AqUc+6PF8GisVTiuTjJisyx2dw7CZpTj+GRrxuJBIdtOSyrbYjfw= X-Received: by 2002:aca:fc92:: with SMTP id a140mr23499698oii.153.1573491497306; Mon, 11 Nov 2019 08:58:17 -0800 (PST) MIME-Version: 1.0 References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-12-keescook@chromium.org> In-Reply-To: <20191011000609.29728-12-keescook@chromium.org> From: Geert Uytterhoeven Date: Mon, 11 Nov 2019 17:58:06 +0100 Message-ID: Subject: Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA To: Kees Cook X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_085818_466855_E551800C X-CRM114-Status: GOOD ( 11.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-Arch , linux-s390 , Michal Simek , the arch/x86 maintainers , "linux-ia64@vger.kernel.org" , linux-c6x-dev@linux-c6x.org, Arnd Bergmann , linux-xtensa@linux-xtensa.org, Michael Ellerman , Dave Hansen , Heiko Carstens , linuxppc-dev , Yoshinori Sato , Borislav Petkov , Parisc List , Andy Lutomirski , alpha , Linux Kernel Mailing List , Rick Edgecombe , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Kees, On Fri, Oct 11, 2019 at 2:07 AM Kees Cook wrote: > There's no reason to keep the RODATA macro: replace the callers with > the expected RO_DATA macro. > > Signed-off-by: Kees Cook > --- > arch/alpha/kernel/vmlinux.lds.S | 2 +- > arch/ia64/kernel/vmlinux.lds.S | 2 +- > arch/microblaze/kernel/vmlinux.lds.S | 2 +- > arch/mips/kernel/vmlinux.lds.S | 2 +- > arch/um/include/asm/common.lds.S | 2 +- > arch/xtensa/kernel/vmlinux.lds.S | 2 +- > include/asm-generic/vmlinux.lds.h | 4 +--- > 7 files changed, 7 insertions(+), 9 deletions(-) Somehow you missed: arch/m68k/kernel/vmlinux-std.lds: RODATA arch/m68k/kernel/vmlinux-sun3.lds: RODATA Leading to build failures in next-20191111: /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-ld:./arch/m68k/kernel/vmlinux.lds:29: syntax error make[1]: *** [/kisskb/src/Makefile:1075: vmlinux] Error 1 Reported-by: noreply@ellerman.id.au http://kisskb.ellerman.id.au/kisskb/buildresult/14022846/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel