From: pushkar.iit@gmail.com (Pushkar Jambhlekar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] vc04_services: Fixing coding and logical guidelines
Date: Tue, 14 Mar 2017 22:02:55 -0700 [thread overview]
Message-ID: <CAMvNc9DpEY1s5U8TRWrzU9TWg0DfpCdn075FnJ-SRUrBO1GGFQ@mail.gmail.com> (raw)
In-Reply-To: <20170315045208.GA9748@kroah.com>
Thanks. I will rewrite patch according to the suggestions.
On Tue, Mar 14, 2017 at 9:52 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote:
>> Description:
>
> No need for that line.
>
>> in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to make code according to 'checkpath.pl'.
>
> Why indent? Also, you need to be specific as to what type of changes
> you made.
>
>> Also, fixing logical issue, i.e. removing break after goto statement.
>
> Don't do multiple things in the same patch, break it up into
> one-patch-per-thing, and no, "checkpatch.pl cleanups" is not "one
> thing" :)
>
> thanks,
>
> greg k-h
--
Jambhlekar Pushkar Arun
M.Tech IIT Roorkee
prev parent reply other threads:[~2017-03-15 5:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 13:09 [PATCH] vc04_services: Fixing coding and logical guidelines Pushkar Jambhlekar
2017-03-15 4:52 ` Greg Kroah-Hartman
2017-03-15 5:02 ` Pushkar Jambhlekar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMvNc9DpEY1s5U8TRWrzU9TWg0DfpCdn075FnJ-SRUrBO1GGFQ@mail.gmail.com \
--to=pushkar.iit@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).