linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: haojian.zhuang@gmail.com (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa: fix missing linux/gpio.h include
Date: Wed, 16 Nov 2011 23:03:33 +0800	[thread overview]
Message-ID: <CAN1soZw4zPCe-VzbXjmGJ6+9yRF3H6KEPtp7kQGa3CtBPHUbfQ@mail.gmail.com> (raw)
In-Reply-To: <1321454103-26596-1-git-send-email-zonque@gmail.com>

On Wed, Nov 16, 2011 at 10:35 PM, Daniel Mack <zonque@gmail.com> wrote:
> Fixes the following compile error:
>
> ?arch/arm/mach-pxa/pxa3xx.c: In function 'pxa3xx_cpu_pm_suspend':
> ?arch/arm/mach-pxa/pxa3xx.c:156: error: implicit declaration of function 'gpio_get_value'
> ?make[1]: *** [arch/arm/mach-pxa/pxa3xx.o] Error 1
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Cc: Haojian Zhuang <haojian.zhuang@marvell.com>
> Cc: Eric Miao <eric.y.miao@gmail.com>
> ---
>
> ?I didn't closely follow all recent patches around PXA, so it might be that
> ?this has already been cared for. Haojian?
>
> ?arch/arm/mach-pxa/pxa3xx.c | ? ?1 +
> ?1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/pxa3xx.c b/arch/arm/mach-pxa/pxa3xx.c
> index 3866d52..7cddd11 100644
> --- a/arch/arm/mach-pxa/pxa3xx.c
> +++ b/arch/arm/mach-pxa/pxa3xx.c
> @@ -19,6 +19,7 @@
> ?#include <linux/platform_device.h>
> ?#include <linux/irq.h>
> ?#include <linux/io.h>
> +#include <linux/gpio.h>
> ?#include <linux/syscore_ops.h>
> ?#include <linux/i2c/pxa-i2c.h>
>
> --
> 1.7.7.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

Hi Daniel,

At first, gpio_get_value() isn't used in arch/arm/mach-pxa/pxa3xx.c.

Which git tree and which branch are you using now? I tried my git
tree, arnd/for-next, rmk/for-next. Everything is ok. I can't find any
build issue.

Thanks
Haojian

  parent reply	other threads:[~2011-11-16 15:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-16 14:35 [PATCH] ARM: pxa: fix missing linux/gpio.h include Daniel Mack
2011-11-16 14:52 ` Eric Miao
2011-11-16 15:03 ` Haojian Zhuang [this message]
2011-11-16 15:08   ` Eric Miao
2011-11-16 15:30     ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN1soZw4zPCe-VzbXjmGJ6+9yRF3H6KEPtp7kQGa3CtBPHUbfQ@mail.gmail.com \
    --to=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).