* [PATCH] ARM: pxa: fix missing linux/gpio.h include
@ 2011-11-16 14:35 Daniel Mack
2011-11-16 14:52 ` Eric Miao
2011-11-16 15:03 ` Haojian Zhuang
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Mack @ 2011-11-16 14:35 UTC (permalink / raw)
To: linux-arm-kernel
Fixes the following compile error:
arch/arm/mach-pxa/pxa3xx.c: In function 'pxa3xx_cpu_pm_suspend':
arch/arm/mach-pxa/pxa3xx.c:156: error: implicit declaration of function 'gpio_get_value'
make[1]: *** [arch/arm/mach-pxa/pxa3xx.o] Error 1
Signed-off-by: Daniel Mack <zonque@gmail.com>
Cc: Haojian Zhuang <haojian.zhuang@marvell.com>
Cc: Eric Miao <eric.y.miao@gmail.com>
---
I didn't closely follow all recent patches around PXA, so it might be that
this has already been cared for. Haojian?
arch/arm/mach-pxa/pxa3xx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-pxa/pxa3xx.c b/arch/arm/mach-pxa/pxa3xx.c
index 3866d52..7cddd11 100644
--- a/arch/arm/mach-pxa/pxa3xx.c
+++ b/arch/arm/mach-pxa/pxa3xx.c
@@ -19,6 +19,7 @@
#include <linux/platform_device.h>
#include <linux/irq.h>
#include <linux/io.h>
+#include <linux/gpio.h>
#include <linux/syscore_ops.h>
#include <linux/i2c/pxa-i2c.h>
--
1.7.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: pxa: fix missing linux/gpio.h include
2011-11-16 14:35 [PATCH] ARM: pxa: fix missing linux/gpio.h include Daniel Mack
@ 2011-11-16 14:52 ` Eric Miao
2011-11-16 15:03 ` Haojian Zhuang
1 sibling, 0 replies; 5+ messages in thread
From: Eric Miao @ 2011-11-16 14:52 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 16, 2011 at 10:35 PM, Daniel Mack <zonque@gmail.com> wrote:
> Fixes the following compile error:
>
> ?arch/arm/mach-pxa/pxa3xx.c: In function 'pxa3xx_cpu_pm_suspend':
> ?arch/arm/mach-pxa/pxa3xx.c:156: error: implicit declaration of function 'gpio_get_value'
> ?make[1]: *** [arch/arm/mach-pxa/pxa3xx.o] Error 1
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Cc: Haojian Zhuang <haojian.zhuang@marvell.com>
> Cc: Eric Miao <eric.y.miao@gmail.com>
Applied.
> ---
>
> ?I didn't closely follow all recent patches around PXA, so it might be that
> ?this has already been cared for. Haojian?
>
> ?arch/arm/mach-pxa/pxa3xx.c | ? ?1 +
> ?1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/pxa3xx.c b/arch/arm/mach-pxa/pxa3xx.c
> index 3866d52..7cddd11 100644
> --- a/arch/arm/mach-pxa/pxa3xx.c
> +++ b/arch/arm/mach-pxa/pxa3xx.c
> @@ -19,6 +19,7 @@
> ?#include <linux/platform_device.h>
> ?#include <linux/irq.h>
> ?#include <linux/io.h>
> +#include <linux/gpio.h>
> ?#include <linux/syscore_ops.h>
> ?#include <linux/i2c/pxa-i2c.h>
>
> --
> 1.7.7.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: pxa: fix missing linux/gpio.h include
2011-11-16 14:35 [PATCH] ARM: pxa: fix missing linux/gpio.h include Daniel Mack
2011-11-16 14:52 ` Eric Miao
@ 2011-11-16 15:03 ` Haojian Zhuang
2011-11-16 15:08 ` Eric Miao
1 sibling, 1 reply; 5+ messages in thread
From: Haojian Zhuang @ 2011-11-16 15:03 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 16, 2011 at 10:35 PM, Daniel Mack <zonque@gmail.com> wrote:
> Fixes the following compile error:
>
> ?arch/arm/mach-pxa/pxa3xx.c: In function 'pxa3xx_cpu_pm_suspend':
> ?arch/arm/mach-pxa/pxa3xx.c:156: error: implicit declaration of function 'gpio_get_value'
> ?make[1]: *** [arch/arm/mach-pxa/pxa3xx.o] Error 1
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Cc: Haojian Zhuang <haojian.zhuang@marvell.com>
> Cc: Eric Miao <eric.y.miao@gmail.com>
> ---
>
> ?I didn't closely follow all recent patches around PXA, so it might be that
> ?this has already been cared for. Haojian?
>
> ?arch/arm/mach-pxa/pxa3xx.c | ? ?1 +
> ?1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/pxa3xx.c b/arch/arm/mach-pxa/pxa3xx.c
> index 3866d52..7cddd11 100644
> --- a/arch/arm/mach-pxa/pxa3xx.c
> +++ b/arch/arm/mach-pxa/pxa3xx.c
> @@ -19,6 +19,7 @@
> ?#include <linux/platform_device.h>
> ?#include <linux/irq.h>
> ?#include <linux/io.h>
> +#include <linux/gpio.h>
> ?#include <linux/syscore_ops.h>
> ?#include <linux/i2c/pxa-i2c.h>
>
> --
> 1.7.7.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
Hi Daniel,
At first, gpio_get_value() isn't used in arch/arm/mach-pxa/pxa3xx.c.
Which git tree and which branch are you using now? I tried my git
tree, arnd/for-next, rmk/for-next. Everything is ok. I can't find any
build issue.
Thanks
Haojian
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: pxa: fix missing linux/gpio.h include
2011-11-16 15:03 ` Haojian Zhuang
@ 2011-11-16 15:08 ` Eric Miao
2011-11-16 15:30 ` Daniel Mack
0 siblings, 1 reply; 5+ messages in thread
From: Eric Miao @ 2011-11-16 15:08 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 16, 2011 at 11:03 PM, Haojian Zhuang
<haojian.zhuang@gmail.com> wrote:
> On Wed, Nov 16, 2011 at 10:35 PM, Daniel Mack <zonque@gmail.com> wrote:
>> Fixes the following compile error:
>>
>> ?arch/arm/mach-pxa/pxa3xx.c: In function 'pxa3xx_cpu_pm_suspend':
>> ?arch/arm/mach-pxa/pxa3xx.c:156: error: implicit declaration of function 'gpio_get_value'
>> ?make[1]: *** [arch/arm/mach-pxa/pxa3xx.o] Error 1
>>
>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>> Cc: Haojian Zhuang <haojian.zhuang@marvell.com>
>> Cc: Eric Miao <eric.y.miao@gmail.com>
>> ---
>>
>> ?I didn't closely follow all recent patches around PXA, so it might be that
>> ?this has already been cared for. Haojian?
>>
>> ?arch/arm/mach-pxa/pxa3xx.c | ? ?1 +
>> ?1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-pxa/pxa3xx.c b/arch/arm/mach-pxa/pxa3xx.c
>> index 3866d52..7cddd11 100644
>> --- a/arch/arm/mach-pxa/pxa3xx.c
>> +++ b/arch/arm/mach-pxa/pxa3xx.c
>> @@ -19,6 +19,7 @@
>> ?#include <linux/platform_device.h>
>> ?#include <linux/irq.h>
>> ?#include <linux/io.h>
>> +#include <linux/gpio.h>
>> ?#include <linux/syscore_ops.h>
>> ?#include <linux/i2c/pxa-i2c.h>
>>
>> --
>> 1.7.7.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
>
> Hi Daniel,
>
> At first, gpio_get_value() isn't used in arch/arm/mach-pxa/pxa3xx.c.
>
> Which git tree and which branch are you using now? I tried my git
> tree, arnd/for-next, rmk/for-next. Everything is ok. I can't find any
> build issue.
Ouch! I didn't even give it a second thought to this obvious one-liner patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: pxa: fix missing linux/gpio.h include
2011-11-16 15:08 ` Eric Miao
@ 2011-11-16 15:30 ` Daniel Mack
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Mack @ 2011-11-16 15:30 UTC (permalink / raw)
To: linux-arm-kernel
On 11/16/2011 04:08 PM, Eric Miao wrote:
> On Wed, Nov 16, 2011 at 11:03 PM, Haojian Zhuang
> <haojian.zhuang@gmail.com> wrote:
>> On Wed, Nov 16, 2011 at 10:35 PM, Daniel Mack <zonque@gmail.com> wrote:
>>> Fixes the following compile error:
>>>
>>> arch/arm/mach-pxa/pxa3xx.c: In function 'pxa3xx_cpu_pm_suspend':
>>> arch/arm/mach-pxa/pxa3xx.c:156: error: implicit declaration of function 'gpio_get_value'
>>> make[1]: *** [arch/arm/mach-pxa/pxa3xx.o] Error 1
>>>
>>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>>> Cc: Haojian Zhuang <haojian.zhuang@marvell.com>
>>> Cc: Eric Miao <eric.y.miao@gmail.com>
>>> ---
>>>
>>> I didn't closely follow all recent patches around PXA, so it might be that
>>> this has already been cared for. Haojian?
>>>
>>> arch/arm/mach-pxa/pxa3xx.c | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-pxa/pxa3xx.c b/arch/arm/mach-pxa/pxa3xx.c
>>> index 3866d52..7cddd11 100644
>>> --- a/arch/arm/mach-pxa/pxa3xx.c
>>> +++ b/arch/arm/mach-pxa/pxa3xx.c
>>> @@ -19,6 +19,7 @@
>>> #include <linux/platform_device.h>
>>> #include <linux/irq.h>
>>> #include <linux/io.h>
>>> +#include <linux/gpio.h>
>>> #include <linux/syscore_ops.h>
>>> #include <linux/i2c/pxa-i2c.h>
>>>
>>> --
>>> 1.7.7.1
>>>
>>>
>>> _______________________________________________
>>> linux-arm-kernel mailing list
>>> linux-arm-kernel at lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>>
>>
>> Hi Daniel,
>>
>> At first, gpio_get_value() isn't used in arch/arm/mach-pxa/pxa3xx.c.
>>
>> Which git tree and which branch are you using now? I tried my git
>> tree, arnd/for-next, rmk/for-next. Everything is ok. I can't find any
>> build issue.
>
> Ouch! I didn't even give it a second thought to this obvious one-liner patch.
Gash. Not my day. We have a stupid workaround in that file that is
buried in a very old patch. Due to recent changes in mainline, this
doesn't build anymore, but that is something I have to keep privately.
Thanks for the heads-up, and sorry. You can drop this patch.
Daniel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-11-16 15:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-16 14:35 [PATCH] ARM: pxa: fix missing linux/gpio.h include Daniel Mack
2011-11-16 14:52 ` Eric Miao
2011-11-16 15:03 ` Haojian Zhuang
2011-11-16 15:08 ` Eric Miao
2011-11-16 15:30 ` Daniel Mack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).