linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: haojian.zhuang@gmail.com (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/sa1100: fix sa1100-rtc memory resource
Date: Fri, 27 Apr 2012 11:02:05 +0800	[thread overview]
Message-ID: <CAN1soZwQ9BBp+=mZZm6tL+r2j5-wX-mFkeBPCOuqCGkibZ0R1g@mail.gmail.com> (raw)
In-Reply-To: <1334384779-532-1-git-send-email-mad_soft@inbox.ru>

On Sat, Apr 14, 2012 at 2:26 PM, Dmitry Artamonow <mad_soft@inbox.ru> wrote:
> DEFINE_RES_MEM() takes the size of resource as a second argument,
> not the end address. Passing end address leads to following error
> in runtime during device registration:
> sa1100-rtc: failed to claim resource 0
>
> Fix it.
>
> Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
> ---
> ?arch/arm/mach-sa1100/generic.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> For reference: bug was introduced by commit 3888c09074
> ("rtc: sa1100: declare irq in resource")
>
> diff --git a/arch/arm/mach-sa1100/generic.c b/arch/arm/mach-sa1100/generic.c
> index 7c524b4..16be4c5 100644
> --- a/arch/arm/mach-sa1100/generic.c
> +++ b/arch/arm/mach-sa1100/generic.c
> @@ -306,7 +306,7 @@ void sa11x0_register_irda(struct irda_platform_data *irda)
> ?}
>
> ?static struct resource sa1100_rtc_resources[] = {
> - ? ? ? DEFINE_RES_MEM(0x90010000, 0x9001003f),
> + ? ? ? DEFINE_RES_MEM(0x90010000, 0x40),
> ? ? ? ?DEFINE_RES_IRQ_NAMED(IRQ_RTC1Hz, "rtc 1Hz"),
> ? ? ? ?DEFINE_RES_IRQ_NAMED(IRQ_RTCAlrm, "rtc alarm"),
> ?};
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at ?http://www.tux.org/lkml/

Applied

Regards
Haojian

      reply	other threads:[~2012-04-27  3:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-14  6:26 [PATCH] arm/sa1100: fix sa1100-rtc memory resource Dmitry Artamonow
2012-04-27  3:02 ` Haojian Zhuang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN1soZwQ9BBp+=mZZm6tL+r2j5-wX-mFkeBPCOuqCGkibZ0R1g@mail.gmail.com' \
    --to=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).