* [PATCH] ARM: mmp: using for_each_set_bit to simplify the code
@ 2012-09-14 2:30 Wei Yongjun
2012-09-14 3:23 ` Eric Miao
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2012-09-14 2:30 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Using for_each_set_bit() to simplify the code.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
arch/arm/mach-mmp/irq.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-mmp/irq.c b/arch/arm/mach-mmp/irq.c
index e60c7d9..3c71246 100644
--- a/arch/arm/mach-mmp/irq.c
+++ b/arch/arm/mach-mmp/irq.c
@@ -153,10 +153,8 @@ static void icu_mux_irq_demux(unsigned int irq, struct irq_desc *desc)
status = readl_relaxed(data->reg_status) & ~mask;
if (status == 0)
break;
- n = find_first_bit(&status, BITS_PER_LONG);
- while (n < BITS_PER_LONG) {
+ for_each_set_bit(n, &status, BITS_PER_LONG) {
generic_handle_irq(icu_data[i].virq_base + n);
- n = find_next_bit(&status, BITS_PER_LONG, n + 1);
}
}
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM: mmp: using for_each_set_bit to simplify the code
2012-09-14 2:30 [PATCH] ARM: mmp: using for_each_set_bit to simplify the code Wei Yongjun
@ 2012-09-14 3:23 ` Eric Miao
2012-09-21 8:00 ` Haojian Zhuang
0 siblings, 1 reply; 3+ messages in thread
From: Eric Miao @ 2012-09-14 3:23 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 14, 2012 at 10:30 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using for_each_set_bit() to simplify the code.
>
> spatch with a semantic match is used to found this.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Great API, this is good. Acked-by: Eric Miao <eric.y.miao@gmail.com>
> ---
> arch/arm/mach-mmp/irq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-mmp/irq.c b/arch/arm/mach-mmp/irq.c
> index e60c7d9..3c71246 100644
> --- a/arch/arm/mach-mmp/irq.c
> +++ b/arch/arm/mach-mmp/irq.c
> @@ -153,10 +153,8 @@ static void icu_mux_irq_demux(unsigned int irq, struct irq_desc *desc)
> status = readl_relaxed(data->reg_status) & ~mask;
> if (status == 0)
> break;
> - n = find_first_bit(&status, BITS_PER_LONG);
> - while (n < BITS_PER_LONG) {
> + for_each_set_bit(n, &status, BITS_PER_LONG) {
> generic_handle_irq(icu_data[i].virq_base + n);
> - n = find_next_bit(&status, BITS_PER_LONG, n + 1);
> }
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ARM: mmp: using for_each_set_bit to simplify the code
2012-09-14 3:23 ` Eric Miao
@ 2012-09-21 8:00 ` Haojian Zhuang
0 siblings, 0 replies; 3+ messages in thread
From: Haojian Zhuang @ 2012-09-21 8:00 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 14, 2012 at 11:23 AM, Eric Miao <eric.y.miao@gmail.com> wrote:
> On Fri, Sep 14, 2012 at 10:30 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Using for_each_set_bit() to simplify the code.
>>
>> spatch with a semantic match is used to found this.
>> (http://coccinelle.lip6.fr/)
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Great API, this is good. Acked-by: Eric Miao <eric.y.miao@gmail.com>
>
Applied
Thanks
Haojian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-21 8:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-14 2:30 [PATCH] ARM: mmp: using for_each_set_bit to simplify the code Wei Yongjun
2012-09-14 3:23 ` Eric Miao
2012-09-21 8:00 ` Haojian Zhuang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).