From mboxrd@z Thu Jan 1 00:00:00 1970 From: haojian.zhuang@gmail.com (Haojian Zhuang) Date: Sun, 11 Aug 2013 13:22:48 +0800 Subject: [PATCH v6 09/11] clk: mmp: parse clock from dts In-Reply-To: References: <1374833133-21119-1-git-send-email-haojian.zhuang@gmail.com> <1374833133-21119-10-git-send-email-haojian.zhuang@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Aug 10, 2013 at 10:57 PM, Daniel Drake wrote: > Hi Haojian, > > I just stumbed upon this mail... I see that I have done some similar > work in my recent patches. Maybe you could CC me in future when we are > duplicating efforts. Yes, I'll cc you for the next patches. > > On Fri, Jul 26, 2013 at 4:05 AM, Haojian Zhuang > wrote: >> Parse clock information from DTS file for mach-mmp. >> >> Changelog: >> v6: >> 1. Remove marvell string from properties in clock driver. >> 2. Append document for clock binding device tree. >> 3. Use apbc to replace apbcp. Since the main difference is register >> base. > > If one replaces the other then why are both still present in the patch? > I think all these clock type acronyms deserve a quick comment > explaining what they are. Maybe I didn't explain it well. I still use the apbcp node, but I replace all apbcp properties by apbc properties. The apbc registers are similar to apbcp registers. But the base registers are different. So I use different apbc & apbcp node. > >> +Required properties for divider clocks: >> + - compatible : should be "marvell,mmp-apmu-clkdiv". >> + - clocks : should be the input parent clock phandle for the clock. This >> + should be the reference clock. >> + - clock-output-names : should be reference name. >> + - #clock-cells : from common clock binding; should be set to 0. >> + - mmp-clk-reg : divider register offset & mask bits. > > I think you should use the standard 'reg' property for providing > register offets, and then other properties (with better names) for > other info that needs to be supplied e.g. mask. It seems that reg property is better. I'll change it. > > I see that your implementation here moves away from using the existing > code in clk-apmu.c and instead just uses clk-divider directly. That > might make sense, but your new DTS does not reimplement many of the > static APMU clocks that were previously implemented (e.g. ccic, sdh in > clk-mmp2.c). Why is this? > I'll append them later. >> +Required properties for gate clocks: >> + - compatible : should be "marvell,mmp-apbc-clk". >> + - clocks : should be the input parent clock phandle for the clock. This >> + should be the reference clock. >> + - clock-output-names : should be reference name. >> + - #clock-cells : from common clock binding; should be set to 0. >> + - mmp-clk-reg : gate register offset & mask bits. > > mmp-clk-reg contains two elements, I guess. But the second element is > not used in your driver for mmp-apbc-clk. Thanks. I'll fix it. > > Thanks > Daniel