linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: haojian.zhuang@gmail.com (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] [for 3.10] pull request from armsoc/dt branch in pxa git tree
Date: Sat, 13 Apr 2013 21:14:47 +0800	[thread overview]
Message-ID: <CAN1soZy5_i784zLixtDzJvD_H5esmfXGPv22eFSGtxNvHWQaBg@mail.gmail.com> (raw)
In-Reply-To: <20130413070905.GA28595@quad.lixom.net>

On Sat, Apr 13, 2013 at 3:09 PM, Olof Johansson <olof@lixom.net> wrote:
> Hi,
>
> On Sat, Apr 13, 2013 at 12:13:14PM +0800, Haojian Zhuang wrote:
>> Hi Arnd & Olof,
>>
>> Please help to pull armsoc/dt branch from pxa git tree. These patches
>> are used to enable hi3xxx SoC
>> and they're depend on Rob's clock source patches.
>>
>> Regards
>> Haojian
>>
>> The following changes since commit f6161aa153581da4a3867a2d1a7caf4be19b6ec9:
>>
>>   Linux 3.9-rc2 (2013-03-10 16:54:19 -0700)
>>
>> are available in the git repository at:
>>
>>   git://github.com/hzhuang1/linux.git armsoc/dt
>
> First of all, please try to move your repo somewhere else than github. We
> really prefer to see signed tags when repos come from github or gitorious
> or other similar sites. Maybe you can get a linaro git repo instead?
>
Sure. Let me move the git repo and use tags for pull request.

> That's not a showstopper in this case though, since there's only a few
> patches here and easy for us to review.
>
> A couple of more important comments below.
>
>> Haojian Zhuang (6):
>>       devtree: add binding documentation for sp804
>>       ARM: debug: support debug ll on hisilicon soc
>>       clk: hi3xxx: add clock support
>
> I didn't see an Acked-by from Mike Turquette on this one. Since this driver is
> an addition to his subsystem, I would like to see one. It could even go through
> his tree since this is all new platform code.
>
I'll resend these patches and wait Mike to Ack them.

> Not only that, but when I went searching for email to find reviews of this
> patch, I see that Arnd had a round of comments including a request to move
> hs_init_clocks() that, according to the email, was addressed but this patch
> does not seem to have moved.
>
>>       ARM: hi3xxx: add board support with device tree
>>       ARM: hi3xxx: enable hi4511 with device tree
>>       ARM: config: append arch hi3xxx into multi defconfig
>
> Given the comments above, and the currently late time for 3.10, I think this
> will be better held off for more review and a merge for 3.11. Please get the
> above taken care of and resubmit to us as soon as 3.10-rc1 is out and we'll
> stage it for 3.11. The code does look nice and clean and looks to be in good
> shape, so there should be no problem to get it in for 3.10.
>
I'm OK for 3.11 merge window.

Regards
Haojian

      parent reply	other threads:[~2013-04-13 13:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13  4:13 [GIT PULL] [for 3.10] pull request from armsoc/dt branch in pxa git tree Haojian Zhuang
2013-04-13  7:09 ` Olof Johansson
2013-04-13  7:09   ` Olof Johansson
2013-04-13 13:14   ` Haojian Zhuang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN1soZy5_i784zLixtDzJvD_H5esmfXGPv22eFSGtxNvHWQaBg@mail.gmail.com \
    --to=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).