linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: haojian.zhuang@gmail.com (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] ARM: pxa168: Add SDHCI support
Date: Mon, 19 Dec 2011 13:30:42 +0800	[thread overview]
Message-ID: <CAN1soZzDR-iH8mkiDaugZ1bo+=fj6MDYxUEh92Pu52XaMDepPw@mail.gmail.com> (raw)
In-Reply-To: <8B50F2A0-3991-4127-B3D9-5D69C70F87EF@marvell.com>

On Mon, Dec 19, 2011 at 1:24 PM, Philip Rakity <prakity@marvell.com> wrote:
>
> Haojian,
>
> Should the APMU definitions be moved to a separate include for pxa168 and say given the name pxa168_apmu.h ?
>
> Same comment applies to all the register set since they are not really common.
>
> Philip

I think it's unnecessary to create a new apmu.h. We can distinguish
them by name in macro, as PXA168/MMP2.

Thanks
Haojian

  reply	other threads:[~2011-12-19  5:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-25 12:37 [PATCH 2/3] mmc: sdhci-pxa: Add SDHCI driver for PXA16x Tanmay Upadhyay
2011-11-10 20:09 ` Chris Ball
2011-11-21  4:23   ` [PATCH 1/4] mmc: sdhci-pxa: Trivial fix in Kconfig Tanmay Upadhyay
2011-11-21  4:26   ` [PATCH v3 2/4] ARM: pxa168: Add SDHCI support Tanmay Upadhyay
2011-12-01 18:05     ` Chris Ball
2011-12-15 23:15       ` Chris Ball
2011-12-19  4:45         ` Haojian Zhuang
2011-12-19  4:55           ` Tanmay Upadhyay
2011-12-19  5:02             ` Haojian Zhuang
2011-12-19  5:17               ` Tanmay Upadhyay
2011-12-19  5:24                 ` Haojian Zhuang
2011-12-20 13:13                   ` [PATCH v4 " Tanmay Upadhyay
2011-12-20 13:25                     ` Haojian Zhuang
2011-12-20 13:38                       ` Haojian Zhuang
2011-12-20 13:44                         ` Tanmay Upadhyay
2011-12-20 13:44                       ` Tanmay Upadhyay
2011-12-20 21:03                     ` Russell King - ARM Linux
2011-12-21  1:48                       ` Haojian Zhuang
2011-12-29 13:43                         ` [PATCH " Tanmay Upadhyay
2011-12-30  0:36                           ` Haojian Zhuang
2012-01-23 22:45                             ` Tanmay Upadhyay
2011-12-19  5:24               ` [PATCH v3 " Philip Rakity
2011-12-19  5:30                 ` Haojian Zhuang [this message]
2011-11-21  4:26   ` [PATCH v2 3/4] mmc: sdhci-pxa: Add SDHCI driver for PXA16x Tanmay Upadhyay
     [not found]     ` <CAMj5Bki3Ev8K63538-dNbyijUw1oNTLChADLd4=Ef-LeCkoacw@mail.gmail.com>
2011-11-25 18:53       ` Philip Rakity
2011-11-21  4:27   ` [PATCH v2 4/4] ARM: pxa168/gplugd: Add support for SD port 1 Tanmay Upadhyay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN1soZzDR-iH8mkiDaugZ1bo+=fj6MDYxUEh92Pu52XaMDepPw@mail.gmail.com' \
    --to=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).