From: haojian.zhuang@gmail.com (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 10/11] ARM: mmp: avoid to use cpu_is_xxx in timer
Date: Tue, 4 Jun 2013 09:24:48 +0800 [thread overview]
Message-ID: <CAN1soZzWGzBX55Uf5XRVFSsSR8Pm6CNTt4cyQDVfYXu+o2Ko3Q@mail.gmail.com> (raw)
In-Reply-To: <201306040034.47041.arnd@arndb.de>
On Tue, Jun 4, 2013 at 6:34 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday 03 June 2013, Haojian Zhuang wrote:
>> void __init mmp_dt_init_timer(void)
>> {
>> struct device_node *np;
>> + struct clk *clk;
>> int irq, ret;
>> + u32 rate = 0;
>>
>> np = of_find_matching_node(NULL, mmp_timer_dt_ids);
>> - if (!np) {
>> - ret = -ENODEV;
>> - goto out;
>
> Please use CLOCKSOURCE_OF_DECLARE() here and call clocksource_of_init()
> in the platform code, rather than calling mmp_dt_init_timer directly.
>
> Arnd
CLOCKSOURCE_OF_DECLARE() is in the 11th patch. And mmp_dt_init_timer()
won't be called in 11th patch.
I split it into 10th & 11th. Since I just want 10th patch to remove
cpu_is_xxx().
Regards
Haojian
next prev parent reply other threads:[~2013-06-04 1:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 9:30 [PATCH v3 00/11] update irqchip, clocksource, clk in mmp Haojian Zhuang
2013-06-03 9:30 ` [PATCH v3 01/11] irqchip: move mmp irq driver Haojian Zhuang
2013-06-03 9:30 ` [PATCH v3 02/11] irqchip: mmp: support irqchip Haojian Zhuang
2013-06-03 9:42 ` Russell King - ARM Linux
2013-06-03 10:06 ` Haojian Zhuang
2013-06-03 9:30 ` [PATCH v3 03/11] irqchip: mmp: support MULTI_IRQ_HANDLER Haojian Zhuang
2013-06-03 9:30 ` [PATCH v3 04/11] ARM: mmp: avoid to include head file in mach-mmp Haojian Zhuang
2013-06-03 22:28 ` Arnd Bergmann
2013-06-03 9:30 ` [PATCH v3 05/11] irqchip: mmp: avoid to include irqs head file Haojian Zhuang
2013-06-03 9:30 ` [PATCH v3 06/11] clocksource: mmp: move mmp timer driver Haojian Zhuang
2013-06-03 9:30 ` [PATCH v3 07/11] ARM: mmp: move timer registers into driver Haojian Zhuang
2013-06-03 22:31 ` Arnd Bergmann
2013-06-03 9:30 ` [PATCH v3 08/11] ARM: pxa: init dma debugfs in late level Haojian Zhuang
2013-06-03 9:30 ` [PATCH v3 09/11] clk: mmp: parse clock from dts Haojian Zhuang
2013-06-03 9:30 ` [PATCH v3 10/11] ARM: mmp: avoid to use cpu_is_xxx in timer Haojian Zhuang
2013-06-03 22:34 ` Arnd Bergmann
2013-06-04 1:24 ` Haojian Zhuang [this message]
2013-06-03 9:30 ` [PATCH v3 11/11] ARCH: mmp: support clocksource " Haojian Zhuang
2013-06-03 17:07 ` John Stultz
2013-06-04 1:25 ` Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN1soZzWGzBX55Uf5XRVFSsSR8Pm6CNTt4cyQDVfYXu+o2Ko3Q@mail.gmail.com \
--to=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).