From: haojian.zhuang@gmail.com (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: pxa: fix build failure for regulator consumer in em-x270.c
Date: Fri, 30 Mar 2012 08:41:58 +0800 [thread overview]
Message-ID: <CAN1soZzssbD1CymiHewy9F8y=1Uc3HDZmL4ws7KTp__R+cpasA@mail.gmail.com> (raw)
In-Reply-To: <1333043034-3374-1-git-send-email-paul.gortmaker@windriver.com>
On Fri, Mar 30, 2012 at 1:43 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> Commit 737f360d5bef5e01c6cfa755dca0b449a154c1e0
>
> ?"regulator: Remove support for supplies specified by struct device"
>
> caused this file to break, since it was still relying on the
> device field to be present. ?Map it onto dev_name appropriately
>
> Since there are two consumers with the name "reg-userspace-consumer",
> we have to supply the ID as a suffix in the REGULATOR_CONSUMER calls.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> CC: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>
> [v3: add .0/.1 ID suffix to "reg-userspace-consumer" instances ]
>
> diff --git a/arch/arm/mach-pxa/em-x270.c b/arch/arm/mach-pxa/em-x270.c
> index c1b65da..16ec557 100644
> --- a/arch/arm/mach-pxa/em-x270.c
> +++ b/arch/arm/mach-pxa/em-x270.c
> @@ -1083,19 +1083,19 @@ static void __init em_x270_userspace_consumers_init(void)
> ?}
>
> ?/* DA9030 related initializations */
> -#define REGULATOR_CONSUMER(_name, _dev, _supply) ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> +#define REGULATOR_CONSUMER(_name, _dev_name, _supply) ? ? ? ? ? ? ? ? ?\
> ? ? ? ?static struct regulator_consumer_supply _name##_consumers[] = { \
> ? ? ? ? ? ? ? ?{ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? \
> - ? ? ? ? ? ? ? ? ? ? ? .dev = _dev, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> + ? ? ? ? ? ? ? ? ? ? ? .dev_name = _dev_name, ? ? ? ? ? ? ? ? ? ? ? ? ?\
> ? ? ? ? ? ? ? ? ? ? ? ?.supply = _supply, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> ? ? ? ? ? ? ? ?}, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> ? ? ? ?}
>
> -REGULATOR_CONSUMER(ldo3, &em_x270_gps_userspace_consumer.dev, "vcc gps");
> +REGULATOR_CONSUMER(ldo3, "reg-userspace-consumer.0", "vcc gps");
> ?REGULATOR_CONSUMER(ldo5, NULL, "vcc cam");
> -REGULATOR_CONSUMER(ldo10, &pxa_device_mci.dev, "vcc sdio");
> +REGULATOR_CONSUMER(ldo10, "pxa2xx-mci", "vcc sdio");
> ?REGULATOR_CONSUMER(ldo12, NULL, "vcc usb");
> -REGULATOR_CONSUMER(ldo19, &em_x270_gprs_userspace_consumer.dev, "vcc gprs");
> +REGULATOR_CONSUMER(ldo19, "reg-userspace-consumer.1", "vcc gprs");
> ?REGULATOR_CONSUMER(buck2, NULL, "vcc_core");
>
> ?#define REGULATOR_INIT(_ldo, _min_uV, _max_uV, _ops_mask) ? ? ? ? ? ? ?\
> --
> 1.7.9.1
>
Applied
Thanks
Haojian
next prev parent reply other threads:[~2012-03-30 0:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 23:12 [PATCH] ARM: pxa: fix build failure for regulator consumer in em-x270.c Paul Gortmaker
2012-03-06 8:46 ` Igor Grinberg
2012-03-06 9:12 ` Haojian Zhuang
2012-03-06 12:16 ` Mark Brown
2012-03-06 12:22 ` Haojian Zhuang
2012-03-07 0:10 ` Paul Gortmaker
2012-03-08 22:06 ` Paul Gortmaker
2012-03-28 15:21 ` Igor Grinberg
2012-03-28 15:27 ` Mark Brown
2012-03-28 15:37 ` Haojian Zhuang
2012-03-28 15:39 ` Mark Brown
2012-03-28 15:59 ` Paul Gortmaker
2012-03-28 16:13 ` Mark Brown
2012-03-28 16:59 ` Paul Gortmaker
2012-03-29 14:28 ` Igor Grinberg
2012-03-29 14:54 ` Mark Brown
2012-03-29 14:57 ` Paul Gortmaker
2012-03-29 15:11 ` Mark Brown
2012-03-29 17:43 ` [PATCH v3] " Paul Gortmaker
2012-03-30 0:41 ` Haojian Zhuang [this message]
2012-03-30 12:24 ` Igor Grinberg
2012-03-29 14:55 ` [PATCH] " Paul Gortmaker
2012-03-30 11:25 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN1soZzssbD1CymiHewy9F8y=1Uc3HDZmL4ws7KTp__R+cpasA@mail.gmail.com' \
--to=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).