From: Etienne Carriere <etienne.carriere@linaro.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init()
Date: Tue, 23 Nov 2021 14:17:54 +0100 [thread overview]
Message-ID: <CAN5uoS8_55fCRoUa67LQzWEtLgkf017fESPydht4QV4o_G800A@mail.gmail.com> (raw)
In-Reply-To: <20211123083620.2366860-1-weiyongjun1@huawei.com>
On Tue, 23 Nov 2021 at 09:23, Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> The driver allocates the mutex but not initialize it.
> Use mutex_init() on it to initialize it correctly.
>
> Fixes: 5f90f189a052 ("firmware: arm_scmi: Add optee transport")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/firmware/arm_scmi/optee.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c
> index d9819b0197ec..901737c9f5f8 100644
> --- a/drivers/firmware/arm_scmi/optee.c
> +++ b/drivers/firmware/arm_scmi/optee.c
> @@ -506,6 +506,7 @@ static int scmi_optee_service_probe(struct device *dev)
> agent->dev = dev;
> agent->tee_ctx = tee_ctx;
> INIT_LIST_HEAD(&agent->channel_list);
> + mutex_init(&agent->mu);
>
> ret = get_capabilities(agent);
> if (ret)
>
`Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>`
Indeed. Thanks for the fix.
Etienne
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-23 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 8:36 [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init() Wei Yongjun
2021-11-23 13:17 ` Etienne Carriere [this message]
2021-11-25 12:36 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN5uoS8_55fCRoUa67LQzWEtLgkf017fESPydht4QV4o_G800A@mail.gmail.com \
--to=etienne.carriere@linaro.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).