From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76110C433F5 for ; Tue, 23 Nov 2021 13:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FfqhWk1PO/B4RFv3ZaJ+npi3whf5CR0wktV2+FZTltE=; b=apsc/W+1hwHkbU A+Vu6Z0125yEEpG9eZVMWNsnE8f7uRcLla+PT95MWLl3XwhxMEgZ1S/8G+wEgy+2HVhsv56b1/h5w ISglqS7vcJwm16H3h/Yk6gt4Yi1VdGUDCBVyAw7eTshcoWvTR1SmU2OVSYHCaZBEBDR7EAOYak66d pjXqzb36ij9NsCId/3LmpGSRRQorEnhPFES3tJh0T4uw+BJunKQpYs1/6yCLAIYox9MhUt7CgUgXF yc1hZjeeouTLLcYBRBXjDjphyuBd8V92Qs0On6Fvy6tp6isigyppy8II/6uuqpHD2x7trqyBidvhY zJTFQBX24t7yUESWObSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpVk8-002LtD-WE; Tue, 23 Nov 2021 13:21:53 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpVgW-002KWD-F1 for linux-arm-kernel@lists.infradead.org; Tue, 23 Nov 2021 13:18:09 +0000 Received: by mail-ed1-x52a.google.com with SMTP id y13so91867135edd.13 for ; Tue, 23 Nov 2021 05:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mAk8tA976gVRgEzEWN8fO9UK+O6cafDP3k8VmtTgX5w=; b=ZlcHuPsPs5XqPHlHybDOmOGrNh0qiyNBwmBCG5MB4Lqj+7XTkXVFtXN/1Bp2RyIIXu i48fr4vDpQ+vIVqE+c6N1UQ40mM0uWHN2ittBrl0AoO5M/goOw4ZJ2QQfUvWRym9OxqX AKgjmMyVwPBmlb2jbdkmaoP7EHV0XWlYMbVjWdFVA/CZthyt7zN5TU+hfgELnOz8dsyp IIxWtVWrwZleqvQeHWT8hJtWtBAasQS3BBvucCsFC5tOvMzCQWyAvpPAD/2+EEYYEQ2H GQ7HF8LIupcY1AtE9yZlvnbMKnS59JlhYiF166pcE9BpDVE0rTgRUla0v89TUv2MF+9J J1aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mAk8tA976gVRgEzEWN8fO9UK+O6cafDP3k8VmtTgX5w=; b=HmyVi0lRICGutBxErO2XqNhA4IAtwJwrnD7N52LMHbhaHYtyWgcU/zbWxMuAp7wf0j Nd8ucRcph+Nbps8uGholtjXg7O3Qlp4DPdWPRPdObnPqIGwlwoMasO+Naege0eESiopx WgumU9Oy0fhB7NhlxIwLu9SPvr9or/58pam8T8cRzk3Ka33suGwz5FnTj68WSE8v5BpS NcZjksNdZM+ZihllSnUoYZ4GEAv47Dw0U5Y56o768JlZoqQNjrTLrsRDl56YPukfIsqE ZdtviwkgIiwVy3nRehjrtZhbhYv/U6nFT2UBERum75v7H1/NkBzNsHIXbUU544B3uf1W ZPzg== X-Gm-Message-State: AOAM531dtKeaXMbp/IrdQbYlk7/Tqket47yDwiSvwxZE/AgT9mYVRWt7 r3+Lo9t1n/ULlZ5zd3iAeIlxiDnJ5cw6PNqYRdcnM4LFd2nOcw== X-Google-Smtp-Source: ABdhPJx1jOOevAIf0UJxx8KjkdMLGW0E1fCsmiuRs/MXcyhAf3Xb3fawyNskFiVUpVxMyEiX4ns31HM0wPPcYLGnFQs= X-Received: by 2002:a17:906:1b1b:: with SMTP id o27mr7495723ejg.279.1637673485902; Tue, 23 Nov 2021 05:18:05 -0800 (PST) MIME-Version: 1.0 References: <20211123083620.2366860-1-weiyongjun1@huawei.com> In-Reply-To: <20211123083620.2366860-1-weiyongjun1@huawei.com> From: Etienne Carriere Date: Tue, 23 Nov 2021 14:17:54 +0100 Message-ID: Subject: Re: [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init() To: Wei Yongjun Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211123_051808_565081_8400DD68 X-CRM114-Status: GOOD ( 16.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 23 Nov 2021 at 09:23, Wei Yongjun wrote: > > The driver allocates the mutex but not initialize it. > Use mutex_init() on it to initialize it correctly. > > Fixes: 5f90f189a052 ("firmware: arm_scmi: Add optee transport") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/firmware/arm_scmi/optee.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c > index d9819b0197ec..901737c9f5f8 100644 > --- a/drivers/firmware/arm_scmi/optee.c > +++ b/drivers/firmware/arm_scmi/optee.c > @@ -506,6 +506,7 @@ static int scmi_optee_service_probe(struct device *dev) > agent->dev = dev; > agent->tee_ctx = tee_ctx; > INIT_LIST_HEAD(&agent->channel_list); > + mutex_init(&agent->mu); > > ret = get_capabilities(agent); > if (ret) > `Reviewed-by: Etienne Carriere ` Indeed. Thanks for the fix. Etienne _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel