From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D360C2BA18 for ; Thu, 20 Jun 2024 09:27:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FROFlUneDLe4vhTKghMMJ/e6nscmWsFk47kSMER6MVc=; b=41dZlUrA1MHmurj2pEhowmoIWD N2KyzQmo+CMkBzowcJPfjONoJnL4smghc4ixHoFYwBYtE1w5X0qTvN4msMi1weTfCCKfbC6GkulvP RnEHluXHthUJpx9qS7MtQLZyPlZtC1xD7GddhpGG7rMEEBECxyRzTOt6+vxicDXs7aESDRZWeu42I hTyBiD93W6rc4sd1v/2kk/MAxKPcUQvoNUcuBQe52K939/WQ2EsjoNUBZWd3NwHYGAwph/dC4jPIK MlMaqqcZ9iJwAuFGNPKKfM4tsl3o8oZ9sRVwbfQQLIOWovlBnPwuCOx6WNNX/6DVWxgHWKLhrnZTz fXDtWD9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKE4h-00000004NeY-49Ki; Thu, 20 Jun 2024 09:27:24 +0000 Received: from mail-oo1-xc2a.google.com ([2607:f8b0:4864:20::c2a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKE4e-00000004NdT-1ZnC for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2024 09:27:21 +0000 Received: by mail-oo1-xc2a.google.com with SMTP id 006d021491bc7-5c19d338401so320247eaf.0 for ; Thu, 20 Jun 2024 02:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718875639; x=1719480439; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FROFlUneDLe4vhTKghMMJ/e6nscmWsFk47kSMER6MVc=; b=a14KxdVGmI81yA10n1MlU63AcJf0G0UbbF8bqTpfbc0WSaWdTece8+UtOK5Eg98wRu IiH4HflKOImbnPhi/+OFMXiZi7RiJWbgfz47GJp9BPTf683hwFEP+uDYpQD4CSKYa9KZ RIKM3UaUGqG+ECqZ1eS59Nkve/ka6G/Qw2qja9H1nlUSo2jde6OII18zRF5AZoTnyqg0 +fTNhKSFeljsw2zSCR/01UO5c3TbnLC5PYFJuFGVVsA8FQUw93EbbbimPbOzmzxsNjZI rC2xP9UiDNoWZJhyqn0E+NFmbhLtPA534kmToLs5j44F5OL5/6+VOQv1UXQYpqfp8Vxq y4Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718875639; x=1719480439; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FROFlUneDLe4vhTKghMMJ/e6nscmWsFk47kSMER6MVc=; b=J+nXyBUvm1psWzcz22JgSNpIAXwH9Y+VRQjJ5r94XKv4l0ffWBExuVNW/tgwlSufGS yYf8xgzTtE/UYj82f1mISJ3rSA/Gdz9mM9LxC0gbo8RGc4vWf3P54f/ZkAng/PwSAasf iXDpCeV4qGkZs6jjuxdnz6W5zV2UGsyrY9YgmAvvGoNNpBfRSPZ9p5bIBf7nDNQ8ZaXK BwgPgDb7vzCIRl5igj4drnM3Aw18HqRXRabH5Hd5je+l45phMxhGeYke0K0CQIOtwpsl +KECnLSpuffP+gYyjcoUHKb1x+KtR6iFSIDstOB94aLgihQ5oSFWqx57FejK9vcm+rMZ 6hRw== X-Forwarded-Encrypted: i=1; AJvYcCXJUWdllU3zx8ylby3WufE+thIrAxjuJLd7Dicn8BSodp4TvGKJVYJQi8tyxp33bIVD7BZ3xZV1ErUk5RJLUFUsnnIDV0JMR+95BBnW3IwMKlSJzog= X-Gm-Message-State: AOJu0YyBqrCukk5bcnq9LVZD8mM7JbnPOTeOnH8Nj+wB/xXuDOk1j8SM iGqFN0Gjo3waci3MIC8d9m2dFrkVVNK++K24Myc+QZBukn0eOrWzkorAYXEueDD1DUSaw8ie0JN TJy+xDpSU01EwOFjyP6lElefz3SQ= X-Google-Smtp-Source: AGHT+IFfg1F0VgT9U7HH46syTdFLN/j9mjNVjjK3LM5UPZUG03dA0siyK9W/UHDjGUhaFvaHXG8w+cqvHC76fvDnpIw= X-Received: by 2002:a4a:8042:0:b0:5ba:f5f3:987b with SMTP id 006d021491bc7-5c1adaea716mr4869639eaf.1.1718875639234; Thu, 20 Jun 2024 02:27:19 -0700 (PDT) MIME-Version: 1.0 References: <20240618204523.9563-1-semen.protsenko@linaro.org> <20240618204523.9563-4-semen.protsenko@linaro.org> In-Reply-To: <20240618204523.9563-4-semen.protsenko@linaro.org> From: Anand Moon Date: Thu, 20 Jun 2024 14:57:03 +0530 Message-ID: Subject: Re: [PATCH v2 3/7] hwrng: exynos: Use devm_clk_get_enabled() to get the clock To: Sam Protsenko Cc: =?UTF-8?Q?=C5=81ukasz_Stelmach?= , Krzysztof Kozlowski , Rob Herring , Conor Dooley , Olivia Mackall , Herbert Xu , Alim Akhtar , linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_022720_435057_61175BAB X-CRM114-Status: GOOD ( 12.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sam, On Wed, 19 Jun 2024 at 02:15, Sam Protsenko wrote: > > Use devm_clk_get_enabled() helper instead of calling devm_clk_get() and > then clk_prepare_enable(). It simplifies the error handling and makes > the code more compact. Also use dev_err_probe() to handle possible > -EPROBE_DEFER errors if the clock is not available yet. > > Signed-off-by: Sam Protsenko > --- > Changes in v2: > - No changes (it's a new patch added in v2) > Reviewed-by: Anand Moon Thanks -Anand