From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C40C2CD11C2 for ; Wed, 10 Apr 2024 05:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MGTN9c0cURBzzgdnahfm1P8Y5lAi6aV/Cpm3tbkWowM=; b=CtH38FA20b2fJn 2Ay4MKYiOuzkmEbhothGmGg5idpUnqWi37PVkJv6rSEtj1xFurASoExNjvLZLrH7lS+7zL/L7vXjn SwAUpAKudI5XVgMFV2+bTFiyssHAIxkxx11RTbE8SDNV3MnYEs6u3RRMw36I2P36JC08MtT7z4IVa LCrqh1ZWJz/Zz+I2N47l1cJKgvA+pYXi2ILbTlaMm2n7xoQcfrWCDT6l+qAd7XwUNIhIlcdzSScFF 0K9oRREH63oHxBJOVPbP55YqizeI4oTF2AnGQqsPkElZPY7UsC2FDk/JH6dLq+8Ng1u5Vdj6D8Y/R EDbDk3386gv4ekkByHcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruQKy-00000005A5Y-2J0V; Wed, 10 Apr 2024 05:17:32 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruQKv-00000005A3q-0sLM for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 05:17:30 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a51d05c50b2so385708066b.0 for ; Tue, 09 Apr 2024 22:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712726246; x=1713331046; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2cVybOrxaIWBpdRlHhr2VWcjnmCsXElx5uaR8eooCU4=; b=Zfs/izz0WBsxJb9878r9tblWXatIwRBZxbHtJLryc55CW10TA/Nb1/jUseHJiGL/Dd 6yAyr/sU0ZP+t3EBsI1w1Y6uT1pl83JZIbPdn+FOXAyMpRGUf2j3dlNAqbJ/SqHniH74 ns72szz8SPuC5oNhUeQx9b1WOYMwZFmTExsR/qquuYTTK4tBk7il4Eo6kdOxFre2c/r8 rWXVGiB9DaMLWi780cwJFYaFmue8uYq/EzTdEXvZWwqaUJqkSoqFiWX6/Dyv2cZs2ypI +lBtEeEEmDHi5AHJ3ftvSRthJjPyHVtkQGP55NDB0vPV1BG3NJl6XFAS7kEJh2VyFnr2 O4ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712726246; x=1713331046; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2cVybOrxaIWBpdRlHhr2VWcjnmCsXElx5uaR8eooCU4=; b=Io89aRcXodDN9pDhzcNjIyF4YBGDJL6dbeeB4ssP7zljZmKBiiqLdi+90bNZ60iCzN DmCDCLGuD3tPcsyovntSLWqfoSQFfBEWDC33T1mFLHuUHT6fTzjAKZ9+10CsDKIFlbgx OYN83dmAnustFnnUjk6WMqVEedH623Ri2MPZ1fjCWA+8fgsEQxPscVrUO4oeaOSQrGp7 WobK6SS8RzppE+fuPohld08Na/0EIMpaVYx3SeXejVuQP990ZzEG+HX7ZczNGyoXZ+3T 1JPG0LlaHPUCBJkqTtvuc4zPbXNJ/b0XaFX68nhgJze+g1N2moZ/2BxfDnSAniEBVkWm sd3g== X-Forwarded-Encrypted: i=1; AJvYcCWTttDH/tzfNzViY88aFNddQXFYV4lTVcmMs3026C7dUtU6cqwfSumgEVEGmuWoGAGH4JVViW2OlQdHqbDIaMJJsHgiOhD5qGkcN5Y2LDlJ9LchO7Y= X-Gm-Message-State: AOJu0YyD2EAjvA1SVShbyDuXfBzje56HBUXxcALsBO/EA9zUcAZZZnmW jIDLGeioYCXf2HJ/HM1MGs1Zxz5opDYdYn1EehvURCtLVTfFLKk9IzNcrnL7ANBXvu9Vf8wdqmz 0X+F75oX1rHQMlTOmfx3t+lPJdfM= X-Google-Smtp-Source: AGHT+IG7FsrMS6CbdL9Mbapbf5TiD5C7IPsXjHCtNalZJ7TlDDnxe6ENgm+0pMmGC+GCa3XGnuZUVLKpFfiXMzh3+Zk= X-Received: by 2002:a17:907:7da5:b0:a52:13ff:5317 with SMTP id oz37-20020a1709077da500b00a5213ff5317mr18170ejc.38.1712726245708; Tue, 09 Apr 2024 22:17:25 -0700 (PDT) MIME-Version: 1.0 References: <20240404071350.4242-1-linux.amoon@gmail.com> <20240404071350.4242-7-linux.amoon@gmail.com> <20240409015352.ocpjbgxrx636jmk4@synopsys.com> In-Reply-To: <20240409015352.ocpjbgxrx636jmk4@synopsys.com> From: Anand Moon Date: Wed, 10 Apr 2024 10:47:10 +0530 Message-ID: Subject: Re: [PATCH v2 6/6] usb: dwc3: exynos: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() To: Thinh Nguyen Cc: Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar , Christophe JAILLET , Johan Hovold , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_221729_282715_5C609235 X-CRM114-Status: GOOD ( 21.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Thinh, On Tue, 9 Apr 2024 at 07:24, Thinh Nguyen wrote: > > On Thu, Apr 04, 2024, Anand Moon wrote: > > Use the new PM macros for the suspend and resume functions to be > > automatically dropped by the compiler when CONFIG_PM_SLEEP are disabled, > > without having to use #ifdef guards. If CONFIG_PM_SLEEP unused, > > they will simply be discarded by the compiler. > > > > Signed-off-by: Anand Moon > > --- > > v2: add __maybe_unused to suspend/resume functions in case CONFIG_PM is > > disabled. > > The compiler discards the code, yet we still need __maybe_unused? > Earlier version had not added this since but I removed the guard.CONFIG_PM_SLEEP. added __maybe_unused just to safeguard the function. I have tried to build with config by disabling CONFIG_PM and CONFIG_PM_SLEEP but could get the warning compilation by adding flag W=1 -Werror=unused-function. diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 7ad48fdda1da..43110e42076e 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -29,8 +29,19 @@ CONFIG_ARM_EXYNOS_CPUIDLE=y CONFIG_VFP=y CONFIG_NEON=y CONFIG_KERNEL_MODE_NEON=y -CONFIG_PM_DEBUG=y -CONFIG_PM_ADVANCED_DEBUG=y +CONFIG_PM_SLEEP=n +CONFIG_PM_SLEEP_SMP=n +# CONFIG_PM_AUTOSLEEP is not set +# CONFIG_PM_USERSPACE_AUTOSLEEP is not set +# CONFIG_PM_WAKELOCKS is not set +CONFIG_PM=n +CONFIG_PM_DEBUG=n +CONFIG_PM_ADVANCED_DEBUG=n +# CONFIG_PM_TEST_SUSPEND is not set +# CONFIG_PM_SLEEP_DEBUG=n +# +CONFIG_PM_DEBUG=n +CONFIG_PM_ADVANCED_DEBUG=n CONFIG_ENERGY_MODEL=y CONFIG_KALLSYMS_ALL=y CONFIG_MODULES=y But since these CONFIG_PM and CONFIG_PM_SLEEP cannot be disabled, I am not getting any warning related to these functions. Do you want me to remove __maybe_unused ? alarm@archl-xu4b:~/linux-exynos-5.y-devel$ ./buildkernelexynos-arch.sh arch/arm/configs/exynos_defconfig:43:warning: override: reassigning to symbol PM_DEBUG arch/arm/configs/exynos_defconfig:44:warning: override: reassigning to symbol PM_ADVANCED_DEBUG # # configuration written to .config # SYNC include/config/auto.conf CALL scripts/checksyscalls.sh CC arch/arm/mach-exynos/pm.o > BR, > Thinh > Thanks -Anand _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel