From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 322E2C2BB85 for ; Sat, 22 Jun 2024 04:30:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F9KsD8yt6Ys8mXDglDi64CvjPaqmJRjrP6+6ZL6aKWI=; b=XqrJSZHLiW6kRVYtoqGgp+Sb22 qcJKhXjHBLZP7aeRDM4FSXSgEcH52OhZtGxX99mN1LAOikRrIGd8ZRdzknQxkfFGNo6yILCdmGRXH uM9Now/WorXtmcADOg78Akq/+Q5oPLE6klXynyipZuF36gXjMeXuxaMMcPdCx6Rqc7W2jfKFi9ZY+ cGrCdH6JwY/HnXJ7FrTBv2Uu1cc3JpDTgnHm4mh4FXqv1tCQqtCgBbeMuagpRqWtadApXoUn7oKuG 09ZD6jYJiHpYkyfdUF3DlQm2ROGqcxmtnQgixa09LTNqHGkqZOM+zd1Sxh688uFX/cDNI8JFivdpx p0po/lRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKsNz-0000000BMoN-2Slx; Sat, 22 Jun 2024 04:29:59 +0000 Received: from mail-oa1-x2a.google.com ([2001:4860:4864:20::2a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKsNu-0000000BMmn-1jI2; Sat, 22 Jun 2024 04:29:56 +0000 Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-25cba5eea69so1238669fac.2; Fri, 21 Jun 2024 21:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719030593; x=1719635393; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=F9KsD8yt6Ys8mXDglDi64CvjPaqmJRjrP6+6ZL6aKWI=; b=d9rf3zbtMLa1xHcw0epm+WKukbMW8Lt91ENlf42huYu+IaOUFefyHUKXeGDDP+a0Un L8rtcZrGzAdu620gNDxn9YhAWjgyi1xPYofmjdnqrgPLZlmfpdDFKNVnUFphkKKScM/1 riEc2EnzjjsNUijQJ5fqGsK+oUM/8+7IHlahXBnOgPhEXOIKZS9FtGaFsKM1pBEtIDGP idX/WwxXB2EX1KNo1hMsrGiTPzEWlOoDPniNSQ3U5tzy84tGvaaCI2h7xQ4b8Ww/wxNV YzCtafJRttdKsYqSLd2zILu06oKHOhshpRRuqPsemmrhFxGKLsts4Gz7f8Z1H026ZhoP 0jhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719030593; x=1719635393; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=F9KsD8yt6Ys8mXDglDi64CvjPaqmJRjrP6+6ZL6aKWI=; b=owSKjrwREoYnu1NQGcvmhap0jab52XK65O9ZiNRExHuKJn3hl0jRTd4dvOzvyM7LUg cwRLEyRNsuTKYCFFEj2JSyp+S5CCQ5qQSzHu0q+TK0RJRliEkIyePqnzMyjsS7kIhyji yPQqkaWKxa29oU8rJT7MQdO7xfVyISXTEot2cPtzlbeilDZVDN2mhLKCuRJuDeEYM6U1 lzQrK2Sb64T+QozO2QvabdV4mIPb8v8bTbqVzUBDQUp4h7HbPa/vSDqcwD45Fm/hkoI2 T7Q+Ax1w2Z4FlsncArIRCssK+25EIhqNj01FhvFeSAMZHxHupiPft/2aszHwf8mFd+FL JO4g== X-Forwarded-Encrypted: i=1; AJvYcCV4Nfg+Q/ushiaDy8W57ThXM3l/2+J3PdUPbJSC2nYJPrFqWUovgIFe67C1z3OiZqJ9ipsu3d8JkdsV4x4GZXfZKCr3NEpbCroep66AKBrVqr2B1N38Uj6YW4a/inb/9EEzPuLuGCW9HldPY/7Z0ubm4jW0TRY1h0E= X-Gm-Message-State: AOJu0Yw6kB/GATO2aMSUN1ZdZeRGVZi4rVx9VubtD2h7ZNdzyC61PqPS WwARz81U1iYB/0/XsO8AYcv4/dSRPRy9NOLSiXJdnZ4an090B0MeXp5otVzmJ3eKK7dSHCYIth9 VU5/foLl/2kse3YVmO3LY9JasDGE= X-Google-Smtp-Source: AGHT+IE1+yk8ZA9XkU/ojx39oXVgXLE6ORoPSVISfOrRYQzqC1BHglAPcab/AKI4UKiw3FAoN067oBVJ79pWX7QhtAI= X-Received: by 2002:a05:6870:d389:b0:254:c95f:cdb6 with SMTP id 586e51a60fabf-25c94d5c85fmr11605824fac.52.1719030592833; Fri, 21 Jun 2024 21:29:52 -0700 (PDT) MIME-Version: 1.0 References: <20240621064426.282048-1-linux.amoon@gmail.com> <20240621212125.GA1406213@bhelgaas> In-Reply-To: <20240621212125.GA1406213@bhelgaas> From: Anand Moon Date: Sat, 22 Jun 2024 09:59:38 +0530 Message-ID: Subject: Re: [PATCH v2 1/3] PCI: rockchip: Simplify clock handling by using clk_bulk*() function To: Bjorn Helgaas Cc: Shawn Lin , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , kernel test robot , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_212954_475961_09A8EEE1 X-CRM114-Status: GOOD ( 20.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bjorn On Sat, 22 Jun 2024 at 02:51, Bjorn Helgaas wrote: > > On Fri, Jun 21, 2024 at 12:14:20PM +0530, Anand Moon wrote: > > Refactors the clock handling in the Rockchip PCIe driver, > > introducing a more robust and efficient method for enabling and > > disabling clocks using clk_bulk*() API. Using the clk_bulk APIs, > > the clock handling for the core clocks becomes much simpler. > > > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/oe-kbuild-all/202406200818.CQ7DXNSZ-lkp@intel.com/ > > Drop these two lines, as suggested in the test robot report: > > If you fix the issue in a separate patch/commit (i.e. not just a new > version of the same patch/commit), kindly add following tags ... > > This is a new version of the same patch, so it doesn't need those > tags. > Ok. > The problem you're solving with this patch is that the clock handling > is too complicated. The test robot didn't report *that* problem. > > Since you'll repost for this, also s/Refactors/Refactor/ in the commit > log so this is in imperative mood: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.9#n94 > https://chris.beams.io/posts/git-commit/ > Ok, I will follow up on this process in the future. > > drivers/pci/controller/pcie-rockchip.c | 64 ++++---------------------- > > drivers/pci/controller/pcie-rockchip.h | 15 ++++-- > > 2 files changed, 21 insertions(+), 58 deletions(-) > > Nice reduction in lines! Thanks -Anand