From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55605CD1292 for ; Thu, 4 Apr 2024 07:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jlfDXuGPjgS6sgz5cJsWEVFdORjcXoZQTBA8EdlDuJE=; b=boQibgVgU7ZspR 6sKwOY3wqWfwNM7OTy+FeInh0dZXuXZdWE6wYqM/B/XGm50nAv57tLPBITkMnirVpV0cZkwRWXg4y 3BKmpc7kFS9cpkCCSUZNHVOZfwtAzjWcPQ4/8jfGVs0BdpZTkxw+ONfnJImAkPzg/+/YQreKyelnN SgI84OH67OKB+pMMu+IrvYRoDRM0fI3GrHpQvsC+Bx96J2deHpDi7+TplpnQBiNwTjh+eZTj9kcG+ FaCboGJYXCI//Y6KNzZlOjTH5nPU6Gdhz0Pyixdwi1ZtJs7AMUkvniqxLVEUreAwQy8/YN2Ika0jF yTfhs0XKP9V2DjYm2Yow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsHgO-00000001fRV-1rng; Thu, 04 Apr 2024 07:38:48 +0000 Received: from mail-oo1-xc36.google.com ([2607:f8b0:4864:20::c36]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsHgL-00000001fPz-39Ro for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2024 07:38:47 +0000 Received: by mail-oo1-xc36.google.com with SMTP id 006d021491bc7-5a7a4119d02so293335eaf.1 for ; Thu, 04 Apr 2024 00:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712216322; x=1712821122; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=we2O1Ti81VxZtCCVRPAlQfc7bOWmir0153692cEekTA=; b=MEOsyevs/6Cg3NE4+o7f/TiwWZYCW9opNrE1RxVb8/POQd4hA9uVwLa3ldAJ+nfzkv FkC60dJh9yZk8pdSsTbQlm2AiJlMU4jwtYxapQWUFNjxG7LtPZh+c6UHzpGj79AniXsQ jxTmZBPYWKZRyfIDtJYPfAqp+40REexQRaaIHMrszH4nsmwjliaeCBTlFsoBQzYWZuR/ +npHmrIJKQYKKnu26cjc5oYDwjzRKN7SrIJ0jTYYEzktabbG0GwSJ1Hj/jaQU4X4/CJo gG2+kd8vfKHiqL1ciDsJd7l0OhCJb7G6wxCfFaoVT+gEwRb4jgy5Xebshi0Jv5J23fGp LhYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712216323; x=1712821123; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=we2O1Ti81VxZtCCVRPAlQfc7bOWmir0153692cEekTA=; b=egSuGFgQXJDomRHEBco5XmUcWNYf8wljZg32XPH2kXAMySF5R/9lBR6dPLgw4B35do OjA7TpwBc+Jbvd6ydpjmqcC0g/JT8BBGdg3EppkSxKBamWAw+BMWwL4an95Z5rIQ8BJN qnzXzKPtq5yhHDWvw5I+r06XiZXSvArRMtG9Bm3z3MiPat80t4NZhy7klOn9RTup90DG /l4F2e7V4Rkx+QRc/agGwtozI+Mn/F+njX3pDbCpvBi6iQkljf7SYkltMVcW/BzIMNIt Rxdawnz+o6U9X0K3aLLoWqcUF3CyhzNUBGvJXRLCv92jvOjzWs7VeOQzLCnZhXlYmttG Brxg== X-Forwarded-Encrypted: i=1; AJvYcCWt+Q432cNBE8mgiXBmk0ZZl8GzF+4JAkcSXVNISE7lbp4iOYaVMNB3JkJKSnn/M9xVX0AVaQAMe2vDOV+XkwcVPNtbG4VJXgEMfXsHLiUg5UCI9zM= X-Gm-Message-State: AOJu0YyJhz9J30IugZ+/YBwapopVvnzyivBuLxTYoPvCOKWiMIWARcFl LAn5CYw9yU1XUiSKD7G6LxDNLS6dS8yKDBQ7mEuMOTnvAL/yTJSpP5Bcf/WAn+3o7RShILI2/3x M/FwfM8KPFr67K7hazMH58+zRFyM= X-Google-Smtp-Source: AGHT+IETHfDKs90ZM2H1TVHcAUgZqVFrTvOqJYL9jrxo6+qMd1YqwAdGD0Ml1tnLH1xe1d0c1QgdqCpI1PaSO0LTKYY= X-Received: by 2002:a05:6820:308f:b0:5a9:d519:b541 with SMTP id eu15-20020a056820308f00b005a9d519b541mr1858551oob.4.1712216322675; Thu, 04 Apr 2024 00:38:42 -0700 (PDT) MIME-Version: 1.0 References: <20240404071350.4242-1-linux.amoon@gmail.com> <20240404071350.4242-6-linux.amoon@gmail.com> In-Reply-To: From: Anand Moon Date: Thu, 4 Apr 2024 13:08:26 +0530 Message-ID: Subject: Re: [PATCH v2 5/6] usb: dwc3: exynos: Use devm_regulator_bulk_get_enable() helper function To: Krzysztof Kozlowski Cc: Thinh Nguyen , Greg Kroah-Hartman , Alim Akhtar , Christophe JAILLET , Johan Hovold , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_003845_832640_68F4F87B X-CRM114-Status: GOOD ( 19.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Thu, 4 Apr 2024 at 12:53, Krzysztof Kozlowski wrote: > > On 04/04/2024 09:13, Anand Moon wrote: > > Use devm_regulator_bulk_get_enable() instead of open coded > > 'devm_regulator_get(), regulator_enable(), regulator_disable(). > > I fail to see how did you replace open-coded suspend/resume paths. > > > > > Signed-off-by: Anand Moon > > --- > > V2: no changes, did not find any regression in pm suspend/resume. > > No, that's not equivalent code. No explanation in commit msg. > > You already got comments on this and nothing improved. You just entirely > ignored received comments. That's not how it works. > > I don't think you understand the code and Linux driver model. This patch > repeats several previous attempts with similar issues: no logic behind a > change. > > NAK. devm_regulator_get_enable and devm_regulator_bulk_get_enable both remove the dependency from the driver to handle the regulator_enabled and regulator_disabled. ie this removes the regulator from the driver structure. Since these functions set devm_add_action to disable the regulator when the resource is not used. ret = devm_add_action(dev, devm_regulator_bulk_disable, devres); if (!ret) return 0; > > Best regards, > Krzysztof > if you feel it's incorrect, I will drop this patch.. Thanks -Anand _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel