From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 379B6C636CA for ; Sun, 18 Jul 2021 13:31:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDA9C6109E for ; Sun, 18 Jul 2021 13:31:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDA9C6109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kPt2IDWrX5bBbHrrRKe83QebU/PoyN8QYT+OYCoSR2I=; b=AhNxy2FKfqIUVu X1iXXh3uRcn1wZXa/01HyEIxhUQYtcWXA8n2LhPTpWT4A52Zfe4eeEdvaNRcJH1CfV2GbS4HtP+iI Jsjp3yz+UNECejFrmgPPSnd7WYWX2Ysy3Q0rhMZ/Fj9/+6LUvwmbX9V1z8iOBVZhUgETLkkfJtLyu LdkAINcOvzgtJ5enazSXv4RDNXu46Ol/uNBLyYVB4vohBmi8RT0et7uOpw0QdXEO4V4lJ+4WVc7HZ N+XLiVXOgo91OCzYriFBoWNMlYCJuk/4ApKYgbbnsvPt9sCircN3nog5rk05o5Q7Gg8Wb1d/M+6Af LFjWxj5GLzD7h6cYu2Tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m56rg-007krK-LO; Sun, 18 Jul 2021 13:29:52 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m56rb-007kqI-3W; Sun, 18 Jul 2021 13:29:49 +0000 Received: by mail-ej1-x631.google.com with SMTP id ga14so23448670ejc.6; Sun, 18 Jul 2021 06:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F+GajXwhgygQihBR6CcfbVvipYuLdp/hO1wlWRx3C4o=; b=epVQx7eGz4knpWvr7qZWRgg+cqOklLV7+27B09/6U4PeysPvhgeCr7GEThu8TciKeV jMcOe6OfHsQbnqcuY0CFuROZvXYtPbkwyf2cYxlgkZEDHPx9mY7TfHGTXc55tpZZyt/u tZXzRoRQX01f8ZXj8NITZLVrb3ma+/NRwOhjUAsVCwKQes++SKgIauY9ZxcqwLnlrpJF m64yJ+o0M5d0Y3tM+f6aky/SzhRVYctiKAxm1Tqq6iEr4ENuydE3lAGmcfO+8rkMKfV5 NFmMk34PZWUKUntNN056JTlHayqo9YZsdOvhTOM6dgNmCs3KufnyCma067HYODkKuOpe BdnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F+GajXwhgygQihBR6CcfbVvipYuLdp/hO1wlWRx3C4o=; b=o6KuLefwmwgW5pDEvXqQSbsiz2dnWbfEaW97HSEnJo2pTmGmmaHy3zpcWIVTtkB5TS tzQ6jOCAJJWD1wrhwHXGL5449KF+wO1W9PCMn6l/W/1P3rtPLElLTtfHkmE+kCyhTjw0 dUlCu4PdJaPLMTMfYmhXY+Uc65hWbohrJLUhuY1hPFJyQpMSVgKbpAoDZap9RiDx+uQS 91SyVzdfiQqVNcYJDMJlMsHfk1oEA1VwWrQF079FJx3+T4Fs4tJ6694S8tkXJ2Enma4b edel6WduuD7W8t6HV+c2qvhgmgZuAGJLUgp9QH0fruQN9i9i3juRTNLvLTc9nRepHd32 /qTA== X-Gm-Message-State: AOAM531fwBh+3SnjfEhKoOuboOW6s91iy0Pt1V29a633kL7dbkSJY/hM SCO5Cfosk4PyjZxbSJytWd29QsfxiResVLZdriI= X-Google-Smtp-Source: ABdhPJwS/Bq94eKEXLwFfTRLtdIbpjGeihkXh/74VjCZ03gcU5phaJC7V8CIx4og+agmjbpKLMIIhFH/RciLujuTosw= X-Received: by 2002:a17:907:3c16:: with SMTP id gh22mr23059755ejc.158.1626614985575; Sun, 18 Jul 2021 06:29:45 -0700 (PDT) MIME-Version: 1.0 References: <20210716103651.1455-1-linux.amoon@gmail.com> <20210716103651.1455-2-linux.amoon@gmail.com> In-Reply-To: From: Anand Moon Date: Sun, 18 Jul 2021 18:59:34 +0530 Message-ID: Subject: Re: [PATCHv2 1/4] ARM: dts: meson8b: odroidc1: Add usb phy power node To: Martin Blumenstingl Cc: linux-phy@lists.infradead.org, linux-arm-kernel , linux-amlogic@lists.infradead.org, Linux Kernel , Matt Corallo , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , devicetree X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210718_062947_245761_9A1C0800 X-CRM114-Status: GOOD ( 55.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Martin, Thanks for your valuable feedback, On Sun, 18 Jul 2021 at 17:07, Martin Blumenstingl wrote: > > Hi Anand, > > On Sun, Jul 18, 2021 at 5:38 AM Anand Moon wrote: > [...] > > > > enable input power to USB ports, set it to Active Low. > > > > > > > > [ 1.253149] phy phy-c1108820.phy.0: Looking up phy-supply from device tree > > > > [ 1.253166] phy phy-c1108820.phy.0: Looking up phy-supply property > > > > in node /soc/cbus@c1100000/phy@8820 failed > > > high prio: > > > Can you please describe how I can test this patch? > > > My concern is that previously I have tested your patch with ACTIVE_LOW > > > and ACTIVE_HIGH polarity. > > > In both cases USB is working and I cannot observe any change (apart > > > from this debug message being gone). > > > > > > In the Odroid-C1 schematics (page 1) GPIOAO.BIT5 is connected to USB_OTG *only*. > > > I cannot give my Acked-/Reviewed-/Tested-by without a description of > > > how I can actually test the GPIO potion of this patch. > This question is still open. > Even with all your explanations below I am missing a way to verify if > GPIOAO_5 is the correct GPIO to use. >From the schematics [1] https://dn.odroid.com/S805/Schematics/odroid-c1+_rev0.4_20160226.pdf You could find references to PWREN <--- GPIOAO.BIT5 The second reference is USB HOST Power Switch The third reference is USB HOST POWER. Hope I am clean in my thought process now. . > > > > [...] > > > > + /* > > > > + * signal name from schematics: PWREN - GPIOAO.BIT5 > > > > + */ > > > > + gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; > > > low prio: > > > Even though it's strictly not necessary I think this is confusing to read. > > > Since there's no "enable-active-high" property the GPIO will be > > > considered as "active low". > > > My suggestion is to change GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW > > > > > My apologies, I might have sent the wrong set of patches its > > GPIO_ACTIVE_LOW I meant > > I have formatted with and in the course of testing and verifying It > > might have got SKIPPED. > > I didn't do this intentionally it happen with a mistake with my two > > repositories. > > I don't intend to repeat my mistake, again and again, *sorry for the trouble*. > no worries, that's why I mentioned that it's low priority > > > > Also if you have any extra information since you last pinged me on IRC > > > then it would be great if you could document it. > > > I am referring to these IRC message, where you are stating that the > > > correct polarity should be "active high": > > > xdarklight I have a question on USB GPIO Polarity on Odroid C1+ > > > As per the > > > https://dn.odroid.com/S805/Schematics/odroid-c1+_rev0.4_20160226.pdf > > > MP62551DGT-LF IC controls the power for the USB PORTS > > > https://www.mouser.com/datasheet/2/277/MP62550-1384050.pdf is > > > MP62551DGT datasheet > > > As per the data sheet in section ORDERING INFORMATION Active > > > enable signal is set below MP62551DGT Active High > > > > > > > [1] https://www.mouser.com/datasheet/2/277/MP62550-1384050.pdf > > > > I have read the datasheets MP62551DGT EN* pin its Enable input. Active Low: > > *EN I Enable input. Active Low: (MP62550), Active High: (MP62551).* > > > > I have tested with ACTIVE_LOW and followed all the steps invalidating > > this with debugfs output. > > > > Last login: Tue Jul 13 00:02:49 2021 from 10.0.0.14 > > [alarm@archl-c1e ~]$ sudo cat /sys/kernel/debug/gpio | grep usb > > gpio-1953 (USB_HUB_RST_N |usb-hub-reset ) out hi > > gpio-1954 (USB_OTG_PWREN |regulator-usb-pwr-en) out lo ACTIVE LOW > This means that whatever is configured in the .dts is also showing up > in debugfs. > It doesn't mean that the correct GPIO or polarity is used -> that is > why I want to understand how to actually test this patch. > Technically I can write a patch that makes GPIOAO_13 (which is > connected to the status LED) show up as being used by > regulator-usb-pwr-en in debugfs. Yep, you are correct, If I used GPIOAO_13 wrong pin, it will not enable the USB power. See below. [alarm@archl-c1e ~]$ sudo cat /sys/kernel/debug/gpio | grep usb gpio-1953 (USB_HUB_RST_N |usb-hub-reset ) out hi So correct way with gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_LOW>; [alarm@archl-c1e linux-amlogic-5.y-devel]$ sudo cat /sys/kernel/debug/gpio | grep usb gpio-1953 (USB_HUB_RST_N |usb-hub-reset ) out hi gpio-1954 (USB_OTG_PWREN |regulator-usb-pwr-en) out lo ACTIVE LOW The reason for USB ports has power without this patch is applied. Please check schematics S805 USB2 SDB USB_VDD33 is powered with VDDIO_AO3V3 regulator directly along with SD CARD. > > [...] > > > > &usb1_phy { > > > > status = "okay"; > > > > + phy-supply = <&usb_pwr_en>; > > > medium priority: > > > I have raised the following concern in one of my previous emails on this topic: > > > > The mistake I made before is considering USB VBUS as PHY power supply. > > > > I believe the USB PHY is actually powered by the AVDD18_USB_ADC and > > > > USB33_VDDIOH signals. See the S905 datasheet [0], page 25 > > > > These are 1.8V and 3.3V signals while you are adding a 5V regulator. > > > you replied with: > > > > OK, thanks. > > > so I don't understand what "OK, thanks" means. > > > If it means "Martin, you are wrong" then please provide a description > > > so I can also learn something! > > > > Yes, I understood your inputs. But from the logs below is seen to > > looking for phy-supply > This sentence is correct > > > This is the reason I went ahead with phy-supply as the core phy node > > needs this property. > This sentence is not correct > From drivers/phy/phy-core.c: > phy->pwr = regulator_get_optional(&phy->dev, "phy"); > > As you can see, the "phy-supply" regulator is marked as optional in > the PHY subsystem. > This matches with > Documentation/devicetree/bindings/phy/phy-bindings.txt where > "phy-supply" is marked as an optional property. > > > Please check below commit > > e841ec956e53 ("ARM64: dts: meson-gxbb-odroidc2: fix usb1 power supply") > That commit is from 2017. You'll also find some commits where I am > also using the phy-supply property (I didn't know better back then). > However, in 2018 things changed when the dwc2 driver gained a > vbus-supply property in commit 531ef5ebea9639 ("usb: dwc2: add support > for host mode external vbus supply") OK. > So for new .dts support phy-supply should not be used anymore for VBUS > because phy-supply (described as "Phandle to a regulator that provides > power to the PHY." in > Documentation/devicetree/bindings/phy/phy-bindings.txt) and > vbus-supply are two different things. > It just came to my notice your email on this issue sees below. [0] https://patchwork.kernel.org/project/linux-usb/patch/20190306212431.5779-1-martin.blumenstingl@googlemail.com/ [1] https://patchwork.kernel.org/patch/10868515/ [2] https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=d8b475212bbf9e5f80c1c923a9701dca5ceb23e2 >From the openwrt commit d8b475212bbf9e5f80c1c923a9701dca5ceb23e2 and binding yaml [3] https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/usb/dwc2.yaml#L87 USB DWC2 power is linked to vbus-supply, so it should be moved to usb node. Now I am getting your point correctly. [ 1.260460] dwc2 c90c0000.usb: Looking up vusb_d-supply property in node /soc/usb@c90c0000 failed [ 1.260490] dwc2 c90c0000.usb: supply vusb_d not found, using dummy regulator [ 1.260606] dwc2 c90c0000.usb: Looking up vusb_a-supply from device tree [ 1.260620] dwc2 c90c0000.usb: Looking up vusb_a-supply property in node /soc/usb@c90c0000 failed [ 1.260641] dwc2 c90c0000.usb: supply vusb_a not found, using dummy regulator [ 1.260717] dwc2 c90c0000.usb: registering common handler for irq35 [ 1.260772] dwc2 c90c0000.usb: Looking up vbus-supply from device tree [ 1.260784] dwc2 c90c0000.usb: Looking up vbus-supply property in node /soc/usb@c90c0000 failed Thanks for the input, I will update the vbus-supply in the next version to USB nodes. > > Best regards, > Martin Thanks -Anand _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel