From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 770E6C67861 for ; Mon, 8 Apr 2024 10:03:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e0JC/fFp0yWtjr1VKryTTXdut8H1x3she/kbkWF+5Eg=; b=AWaJcoBEkISoHX GzYGpdaH9BRohlK0XehUSZYngnUJxD+vu869SodxqzsMES5A5gaViq1POEqYiX1878NZR0ckG8gMF NzuC8PP6TH1qNDssX6uy5Ihm7tVk/Ce6l61arkeg2+7B/BLgSYVSRAZ3EWGj4XtI91N09MQ9It4+p Np0Jmi7CAN+d9dENjOo6NgMrmxQD4CJHPdxKYo3KKXJiU5xJXzqtRzrhrnoDcHqDhifdCc0xUIbPA 2FMb8wtH8uX/cL0Get2X44IV7ocJNtRzYuPRhzHI5P6V/6AIRlkMNPtdNEPf+gwRP+QsHUJ9IgC0C /kWkIseDaetK5oMc0hag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtlqa-0000000FCHa-0Hyo; Mon, 08 Apr 2024 10:03:28 +0000 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtlqW-0000000FCGT-40om for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2024 10:03:26 +0000 Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3bbd6ea06f5so2191601b6e.1 for ; Mon, 08 Apr 2024 03:03:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712570603; x=1713175403; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2PE03u/ATA7y4is4W65IiCIRxo+xGf7RO1YxtgagN7Q=; b=X4a0Cg6urJUbUswKl3vAORdeE/f4DZ0lsSXlG3WNwIde/2gxGlsvwbOKzXRXmKkUr8 cOgvOJ+hrBnfA6HSSlsugkqt+tLQWWN/PhWJpr+ppUo4A9ug3fKfPfNov5cGfI3HDG7j wIPpJ4yOJ4nJX4cgxS3+qB2QbvxZaeyqw5nretOQ4+9l2ykPVdu5j/3aY/MLi7V4jeZ7 qs+CWGjCg4p8ZuYNL7jJZ/qNapHJ+xP0q3xDBia1oLsT0i9UX+KunJCfE3fhLR8P11tw 0nWJXXmDsFSV2zE2PAOqypbXRV6ArkbZj6mXOmTKdVy7Fcn/j1Q/fl/VHAg2R81cCK3F rL7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712570603; x=1713175403; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2PE03u/ATA7y4is4W65IiCIRxo+xGf7RO1YxtgagN7Q=; b=PApLHGEiX0Xjj3WZXTAFuIv3ogAfeQTBiTN69asc6OKZOj9OHE4sMb+mdcMfiR7Lbc L0rrB5r2B5y2/eE3FfLgVqhkEVPOz37MfgZZJA0XOr4a7Kj6ouD5aSKCZpwsPrKwRWb2 TNOgdsJQLZJCgNvELc5AOqGz3POZWyN6xhvivkWva4wqAfonbM6SLWsJuhAZFdbrvVQp IxkM9buZwRpdGr7Kkjgm7eMI/FX/drQb2dQW328p2xLroonGEN/bxzfzJ1EuqiC1WGZe 3MOFDS++jRN1Vji2fYox08RzxYFdvqK0WC5BcTatjPj/kZpp2/Jt+yIS3gU3TtT1dVSM CbFA== X-Forwarded-Encrypted: i=1; AJvYcCUlqcSePFW2/yOPWEPJ2A19maqx04VTAIsZOeH+jTJG2fsodlnSKtsh/PTfXl62/MHDOs7qjzsjoUe/nnZtD+fRV0azKOvh9eNDDqpFvxD9+Z+Ttp8= X-Gm-Message-State: AOJu0Yzkl4i3+YhU7hvMXzc8kedOo0jRM8dHyAt3k6BE3Lb6FzxxAu/P 8Nclb17kH+KggN3M2DTROHKcezhIFylC0eMe99H3A18eJN2kP56IjCLCTbLy6HfYnho2jPrPsV2 WK23wljGXy3VQ9EASVxlk5KnLATc= X-Google-Smtp-Source: AGHT+IEQ3hVGE92TGKT4B04slYnWVGrK3nnjU+kRC8lDhLD9YRUEmgm7Gj1sBkLvrK/h6jh3Ut4TpCkZptegcRGNtjc= X-Received: by 2002:a05:6808:2010:b0:3c3:e679:cfbf with SMTP id q16-20020a056808201000b003c3e679cfbfmr2936986oiw.21.1712570603048; Mon, 08 Apr 2024 03:03:23 -0700 (PDT) MIME-Version: 1.0 References: <20240404071350.4242-1-linux.amoon@gmail.com> <20240404071350.4242-2-linux.amoon@gmail.com> <2024040442-subscript-detective-8d12@gregkh> In-Reply-To: From: Anand Moon Date: Mon, 8 Apr 2024 15:33:07 +0530 Message-ID: Subject: Re: [PATCH v2 1/6] usb: ehci-exynos: Use devm_clk_get_enabled() helpers To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Alan Stern , Alim Akhtar , Christophe JAILLET , Johan Hovold , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_030325_097106_0BB8FCF1 X-CRM114-Status: GOOD ( 28.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Greg. On Thu, 4 Apr 2024 at 19:24, Krzysztof Kozlowski wrote: > > On 04/04/2024 15:52, Anand Moon wrote: > > Hi Greg, > > > > On Thu, 4 Apr 2024 at 18:30, Greg Kroah-Hartman > > wrote: > >> > >> On Thu, Apr 04, 2024 at 12:43:17PM +0530, Anand Moon wrote: > >>> The devm_clk_get_enabled() helpers: > >>> - call devm_clk_get() > >>> - call clk_prepare_enable() and register what is needed in order to > >>> call clk_disable_unprepare() when needed, as a managed resource. > >>> > >>> This simplifies the code and avoids the calls to clk_disable_unprepare(). > >>> > >>> While at it, use dev_err_probe consistently, and use its return value > >>> to return the error code. > >>> > >>> Signed-off-by: Anand Moon > >>> --- > >>> V2: drop the clk_disable_unprepare in suspend/resume functions > >>> fix the usb_put_hcd return before the devm_clk_get_enabled > >>> --- > >>> drivers/usb/host/ehci-exynos.c | 19 +++++-------------- > >>> 1 file changed, 5 insertions(+), 14 deletions(-) > >>> > >>> diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c > >>> index f644b131cc0b..f00bfd0b13dc 100644 > >>> --- a/drivers/usb/host/ehci-exynos.c > >>> +++ b/drivers/usb/host/ehci-exynos.c > >>> @@ -159,20 +159,15 @@ static int exynos_ehci_probe(struct platform_device *pdev) > >>> > >>> err = exynos_ehci_get_phy(&pdev->dev, exynos_ehci); > >>> if (err) > >>> - goto fail_clk; > >>> - > >>> - exynos_ehci->clk = devm_clk_get(&pdev->dev, "usbhost"); > >>> + goto fail_io; > >>> > >>> + exynos_ehci->clk = devm_clk_get_enabled(&pdev->dev, "usbhost"); > >>> if (IS_ERR(exynos_ehci->clk)) { > >>> - dev_err(&pdev->dev, "Failed to get usbhost clock\n"); > >>> - err = PTR_ERR(exynos_ehci->clk); > >>> - goto fail_clk; > >>> + usb_put_hcd(hcd); > >>> + return dev_err_probe(&pdev->dev, PTR_ERR(exynos_ehci->clk), > >>> + "Failed to get usbhost clock\n"); > >> > >> Why is this logic changed? > >> > >> If you want to call dev_err_probe(), that's great, but do NOT mix it up > >> with a commit that does something totally different. > >> > >> When you say something like "while at it" in a changelog text, that is a > >> HUGE hint that it needs to be a separate commit. Because of that reason > >> alone, I can't take these, you know better :( > >> > >> thanks, > >> > > > > Ok, I will improve the commit message relevant to the code changes. > > Please read Greg's message one more time. He did not propose to fix > commit msg, right? > Ok I will drop dev_err_probe and keep the error flow as it is. It will not break the feature.. Thanks -Anand _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel