From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81269C433B4 for ; Tue, 6 Apr 2021 17:29:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 108AC613BC for ; Tue, 6 Apr 2021 17:29:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 108AC613BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mFK14OcFmKrmfMMGnD0n3JRW86G4BI6iKb/+8kTZczc=; b=NdjhU1SMyaXSXuJ8W/qotOix5 Gx19wUn6CwpbfphyFoeJDaje2C+Xenhr5VdZ1t9tp86lgTH+vbyd8qmJ1f5M0ieonXSG0ak1Prv5Q kcnvEfgVboqt+tq3XS0flk/tUh1d2JQXeeTJeyw5DhNMPO1JgddNubDWUIuWHwPtTUWDVBgj0MXg8 Xeb5NtrfgAU9jtbX1AzTk9BoQBD+G9qiu8XgQlEtI0lgybB+mxTF9THWuUEg+LtWGg7yysFxUoxeX rQ25FYkXCymIPXMunQZo+A3Xc72UeI1PoxlEFukITl0N/ZFCCTblh5xW+aDcoQ66jDMOLSDAM3S+2 D+0QM9tOw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTpTp-0036I1-K1; Tue, 06 Apr 2021 17:27:09 +0000 Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTpTk-0036HV-67; Tue, 06 Apr 2021 17:27:06 +0000 Received: by mail-oi1-x229.google.com with SMTP id c16so15912114oib.3; Tue, 06 Apr 2021 10:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aibtX65fRbYclFPJuZJmwbNxAQjzGOE2myqGS3WunLw=; b=Vft4FkSEKfY2Z/qa0/JsrQjiV/YE+4yDEO1Y+jiyV3QFtb/o9z9DILB2JWjOcHMOxg m2VJTdFThlPydPR2J3pNIHJu8W8/BHOi3hdZjcvq0yCjLqSDWQkTtoNSmfbA2BDdrE72 T7UEREB3gwPtPc7k4ukjgIuuxlrKBpLyxD0Um0GSomZ5ia7cbO6Jj6Nb7gLc2dGL18YL CuNSYot4qj+NuxBmDis7Dk/gj70XJyH+Nfd0hbd8dmEgcRj3fDzhaiQSOjJF3gnQ1tpv GJTJEUfGodIMLkBoC/bRKEXAeHevz3BA5Pmcr0VMElTjBGkbHiM/U5YuYAPclmbAs6h5 GLlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aibtX65fRbYclFPJuZJmwbNxAQjzGOE2myqGS3WunLw=; b=bEnL9cN9pCNrno4vZnKBMjXsoh1nPamBc+QTVoKbTIN5DP7i6skxAhJzORMPqhNvR2 fA315Iy/j8yY+mCGqZvuKOsLRwQTOk3mbIJnH8y6he4nEYpgiKotzIG21zAlkA0hoOjj YdFr8cHGOmZNooCQWfjkyQGyK83P1lsRMP0mqVdH+8w3nswLJFMZ2K7R0ZnyJLitR2Bm 0hGiCviWrzMBwxCz/ClwxpL+5AVbppjQNkpqZIiBcx3csvdR8+CBPgB33tDZeaGjkl4R ktY1bhntje7VqNvEByrxLffb6VdaXr+fXCf1dpwnkHaTPr4nX9ceyWYeUX6JPla9yhYW cR8Q== X-Gm-Message-State: AOAM533oFpk5IgG65w0iEnWA+tqgpvYvqQDITApRidrzOEKmHGm24cs+ FNfFPC9S6SGwhBkgoVrke+MOY346MbQrwBzk1n8= X-Google-Smtp-Source: ABdhPJxzlmwLkzM2a1BhjNvUHf4fud8hfZLp5Pb3qDfM6ZswIQ0AQFgakOSrKLr6XR7eX0WHAMCXCC1Q3cApaePjWyM= X-Received: by 2002:aca:35d4:: with SMTP id c203mr4177990oia.10.1617730022896; Tue, 06 Apr 2021 10:27:02 -0700 (PDT) MIME-Version: 1.0 References: <20210401212148.47033-1-jim2101024@gmail.com> <20210401212148.47033-3-jim2101024@gmail.com> <20210406164708.GM6443@sirena.org.uk> In-Reply-To: <20210406164708.GM6443@sirena.org.uk> From: Jim Quinlan Date: Tue, 6 Apr 2021 13:26:51 -0400 Message-ID: Subject: Re: [PATCH v4 2/6] dt-bindings: PCI: Add bindings for Brcmstb endpoint device voltage regulators To: Mark Brown Cc: linux-pci , Nicolas Saenz Julienne , Rob Herring , bcm-kernel-feedback-list , Jim Quinlan , Florian Fainelli , Bjorn Helgaas , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210406_182704_482387_C3208EC2 X-CRM114-Status: GOOD ( 21.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 6, 2021 at 12:47 PM Mark Brown wrote: > > On Thu, Apr 01, 2021 at 05:21:42PM -0400, Jim Quinlan wrote: > > Similar to the regulator bindings found in "rockchip-pcie-host.txt", this > > allows optional regulators to be attached and controlled by the PCIe RC > > driver. That being said, this driver searches in the DT subnode (the EP > > node, eg pci@0,0) for the regulator property. > > > The use of a regulator property in the pcie EP subnode such as > > "vpcie12v-supply" depends on a pending pullreq to the pci-bus.yaml > > file at > > > > https://github.com/devicetree-org/dt-schema/pull/54 > > > > Signed-off-by: Jim Quinlan > > --- > > Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > index f90557f6deb8..f2caa5b3b281 100644 > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > @@ -64,6 +64,9 @@ properties: > > > > aspm-no-l0s: true > > > > + vpcie12v-supply: true > > + vpcie3v3-supply: true > > + > > No great problem with having these in the controller node (assming it > accurately describes the hardware) but I do think we ought to also be > able to describe these per slot. Hi Mark, Can you explain what you think that would look like in the DT? Thanks, Jim Quinlan Broadcom STB _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel