From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D61F1C433B4 for ; Tue, 6 Apr 2021 17:01:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 665E1613B3 for ; Tue, 6 Apr 2021 17:01:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 665E1613B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RhSMMGsicQDxdFNmm2HLfFu+OTmKuh9v7ZyBcTrtoEc=; b=FRHn5XOFknxwbpazjycWAHYiW Y1ztQdEH+MFskOlWnXejNZek8JPq43IOEkR4poo5lzQ6Icb9Bt1ZAeusUgOjmyY0cukSqw2/3HcDk y9KtAH5jHyr826N9yFEk4mCw1oZX1WAetZ6bonEdVWb7SyX7d5Srq39vADJCRxL6k5Cu2fGKwOFXc r/P6ZOH+RxwLpFZyGNRHBJ3s4+C3oWR5fVkoCuNGcpOOtxItpSRBJ2I6bhaXu0HBAtgz7l7dEVq5V 09TJMOB/GAdcH7JU/yQsetL0hwqjSJRyahpWXIJMWLbCOnaNjWhmqiRnp/ea0XGq+48VJtQyTbwKg vRWSHqRFg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTp3H-0033Ym-Go; Tue, 06 Apr 2021 16:59:43 +0000 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTp34-0033Wa-B6; Tue, 06 Apr 2021 16:59:33 +0000 Received: by mail-ot1-x332.google.com with SMTP id s11-20020a056830124bb029021bb3524ebeso15354414otp.0; Tue, 06 Apr 2021 09:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U0vcjmfkxT+FMarvJR1c5UkvtHgWk27fUbHRkWTwpuM=; b=bjJ+VuGbGdU5iyhiJDxbr+3vL4o+9DMITQG2zj1EM0kfv32Y0hkTrqs4fU1RaOtulB ttQ+4VD1SKKqhuKvcAxUzcH7aTbVPAUNSUztgCXhOcCNPuXdgU5tndnEv3+o1N/wF0hw fIauUESFLFhfOcZTArCr1pHrlpYcgmspekQtGvyPlFSogto54TQJ4BvpWM9iohB3oKTB w5u6hhWK2bP5+rKRPeHTCjq4yK9FtStpblsBsmfQ4rIzwOnG153D4Dkm49dhc8n/jp8K Pv4Mzj4HwequtKzhQPV+iEdx49+xnZ9Wpk57AnF6yWlKO0REeSAKGAvkl89d2QhsCn19 4l/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U0vcjmfkxT+FMarvJR1c5UkvtHgWk27fUbHRkWTwpuM=; b=Fqs397VUX7mtDTyNWK11AKg8q9YWV014BTtvIm3Q4maz9wlQSD81Ge11nQiDDf9Q9x lHx+r8+w16v2R7fr/i/xzMVyRFxTObkgi2dXWeUkPrEksVCBNqziNUP8GMCQNJSW7TPL kmnllZC3NqfJQnf7xDZ7ZfabMDWA8km2juM1m03HgxEplUlTgUdD1qt9NxR+fdfKIXze 2yetYb1C+F9UWUWZplALi8oKTvkHmk8tPJayc/5cEn8q/o4eoASVx+GbGtMGjCIkQPB/ Umm0hYNwZaXILLNq9FRirB6LyAeWaX9opRiSvivat6FX0Btd57zBVpZn3N6waWL2kFRQ tdZg== X-Gm-Message-State: AOAM531BnQ515wD56AoMKdUVE3SLMmw0N5OdAJk4czl3fi8Mc3UvS4uz RDXcJt4QbAeTOveaC1zuCkC83/s7yniSsuTM2z8= X-Google-Smtp-Source: ABdhPJz5iJqO3rF79/N/EJoRF+CC6lbD3Jutm2e+GIHzkqN6Fzqr+bxXVIEyl+oz8Fhr2p3cPfT4QSL1G44JtAagyiA= X-Received: by 2002:a05:6830:1c6e:: with SMTP id s14mr27819767otg.17.1617728368316; Tue, 06 Apr 2021 09:59:28 -0700 (PDT) MIME-Version: 1.0 References: <20210401212148.47033-1-jim2101024@gmail.com> <20210401212148.47033-4-jim2101024@gmail.com> <20210406163439.GL6443@sirena.org.uk> In-Reply-To: <20210406163439.GL6443@sirena.org.uk> From: Jim Quinlan Date: Tue, 6 Apr 2021 12:59:16 -0400 Message-ID: Subject: Re: [PATCH v4 3/6] PCI: brcmstb: Add control of slot0 device voltage regulators To: Mark Brown Cc: linux-pci , Nicolas Saenz Julienne , Rob Herring , bcm-kernel-feedback-list , Jim Quinlan , Lorenzo Pieralisi , Bjorn Helgaas , Florian Fainelli , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210406_175932_104661_541084F4 X-CRM114-Status: GOOD ( 17.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 6, 2021 at 12:34 PM Mark Brown wrote: > > On Thu, Apr 01, 2021 at 05:21:43PM -0400, Jim Quinlan wrote: > > > + /* Look for specific pcie regulators in the RC DT node. */ > > + for_each_property_of_node(np, pp) { > > + for (i = 0; i < ns; i++) > > + if (strcmp(supplies[i], pp->name) == 0) > > This is broken, the driver knows which supplies are expected, the device > can't function without these supplies so the driver should just > unconditionally request them like any other supply. Hi Mark, Some boards require the regulators, some do not. So the driver is only sure what the names may be if they are present. If I put these names in my struct regulator_bulk_data array and do a devm_regulator_bulk_get(), I will get the following for the boards that do not need the regulators (e.g. the RPi SOC): [ 6.823820] brcm-pcie xxx.pcie: supply vpcie12v-supply not found, using dummy regulator [ 6.832265] brcm-pcie xxx.pcie: supply vpcie3v3-supply not found, using dummy regulator IIRC you consider this a debug feature? Be that as it may, these lines will confuse our customers and I'd like that they not be printed if possible. So I ask you to allow the code as is. If you still insist, I will change and resubmit. Regards, Jim Quinlan Broadcom STB _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel