From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61599C433B4 for ; Tue, 6 Apr 2021 17:31:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE733613BD for ; Tue, 6 Apr 2021 17:31:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE733613BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I+RvziZ9EXqaWZ+6Y1KuvsVJ/2InKPAcnRrNmeo2FL8=; b=HnQ1jRfVnHkeWujp3tvlHNBYS g3HLX62O43vbYJ9GbFsK5jp3wNa8xHQzknVwXt6G0mJagJ2RROYSFP0tg+woAbWAoYP6IyhT+MRIL D4Eh+UQII3SdzYJ5l2u8xCxlZ/YcHrfqapeh81rXJCuNV6pKIr2YrVyX/cRwIjkl/n+1gRLtiHMl9 I6sCvqcFjhXhZW6OLVQXBqkfO59Mz4QpbUMt5YwMdwGbyZywpnQUL5cZJ2jvLuc14rcaiIaWO+l9n dzIf9//h9hfosFzeOxnIbV5HFJ6SETTlvVRpuF4TQib9/YMYldBHPouDsAuNp7gCKU0/d/KBpOjxf o9CZwTUcQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTpWb-0036q7-Uc; Tue, 06 Apr 2021 17:30:02 +0000 Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTpWV-0036mZ-P5; Tue, 06 Apr 2021 17:29:57 +0000 Received: by mail-oi1-x230.google.com with SMTP id v25so15913939oic.5; Tue, 06 Apr 2021 10:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e9XCrHRbPqjp2SIACD271qp9C9m0DUNFOwKAi0QKpXs=; b=YBZah0WeABNCYq0ebm/I87ZFpbg0mlsv9pTMX6nhWLnrxZgASf89DWi7GzZlKD2svc BTTN01jmIvz6EI6EZygJ/3n79A8xrD3wBk02eJduiV6a5gJT8VLsoZZoWDoWQDWZxJCi z69rT/QA30kbdV4PchR3sj0XyKsqYjdneHxAaRj4Rv8WYywFUli5wHvegPOsbDs4KUGi MrawLcKd21iWytX7uPzpgdt9Sr9oOCszLnq71v5x0uBhLhDpyFjfoy6NTAoxFeL3RoHx wG1IQzGYERVPErQhJee16HLqo3lNgHXO8/7PTfysJe+EZ1NTLxpDW/GskLhCfK3Gg4tO 1f8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e9XCrHRbPqjp2SIACD271qp9C9m0DUNFOwKAi0QKpXs=; b=AvpeOKdd6Vm+G9GrHKQ6NQ0YnMTMb/tMoPMtdsELseWAyfOvc3pdiY6ZAf8UAKZwTn 2qhUX/KvXvKf8EVlBmDtZRfgBxi9jdpQ3jz+k31n5AHks37tdkIalY1sC5vaj9jz4BXg yNMzSxZAY83I+tHzk8kalRVP0i7iASub9d/KWpQ4OMWErIPgt+UJ0pSLZbJhONAV6T3U mA23b5onsFCCHZ7fNp5G53RPPsD7nQ+ZDsqXwPqF2A2qftR2QGlDPtiz7zV8dj1Id1Nm jotKo++a5sYOs05OZBV5GxaKKdp3TCKaNdGtY7dsgto30Q2Nz/yprUaRAf5zcXaG50pE PnwA== X-Gm-Message-State: AOAM532CjQXhzChrQqQOUhX8Y0cbpi692vnbMja40doWKhwcI76tyNcI XgD1Gnpn0MXUI02YYe/OkfOZj1fz4sUL9hnHSPvem5+f X-Google-Smtp-Source: ABdhPJwE+fUN8o/LQb//6t43DmpeyIY8YaG40zK3+s4/evbg6pFMHv53bEk1TPp+MnBpqKtTbb5PjpE44JswmPwH61Q= X-Received: by 2002:aca:fc11:: with SMTP id a17mr4067194oii.68.1617730191812; Tue, 06 Apr 2021 10:29:51 -0700 (PDT) MIME-Version: 1.0 References: <20210401212148.47033-1-jim2101024@gmail.com> <20210401212148.47033-4-jim2101024@gmail.com> <20210406163439.GL6443@sirena.org.uk> <20210406172320.GO6443@sirena.org.uk> In-Reply-To: <20210406172320.GO6443@sirena.org.uk> From: Jim Quinlan Date: Tue, 6 Apr 2021 13:29:40 -0400 Message-ID: Subject: Re: [PATCH v4 3/6] PCI: brcmstb: Add control of slot0 device voltage regulators To: Mark Brown Cc: linux-pci , Nicolas Saenz Julienne , Rob Herring , bcm-kernel-feedback-list , Jim Quinlan , Lorenzo Pieralisi , Bjorn Helgaas , Florian Fainelli , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210406_182955_942214_AB08FBA5 X-CRM114-Status: GOOD ( 29.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 6, 2021 at 1:23 PM Mark Brown wrote: > > On Tue, Apr 06, 2021 at 12:59:16PM -0400, Jim Quinlan wrote: > > On Tue, Apr 6, 2021 at 12:34 PM Mark Brown wrote: > > > On Thu, Apr 01, 2021 at 05:21:43PM -0400, Jim Quinlan wrote: > > > > This is broken, the driver knows which supplies are expected, the device > > > can't function without these supplies so the driver should just > > > unconditionally request them like any other supply. > > > Some boards require the regulators, some do not. So the driver is > > No, some boards have the supplies described in firmware and some do not. True. > > > only sure what the names may be if they are present. If I put these > > names in my struct regulator_bulk_data array and do a > > devm_regulator_bulk_get(), I will get the following for the boards > > that do not need the regulators (e.g. the RPi SOC): > > > > [ 6.823820] brcm-pcie xxx.pcie: supply vpcie12v-supply not found, > > using dummy regulator > > [ 6.832265] brcm-pcie xxx.pcie: supply vpcie3v3-supply not found, > > using dummy regulator > > Sure, those are just warnings. > > > IIRC you consider this a debug feature? Be that as it may, these > > lines will confuse our customers and I'd like that they not be printed > > if possible. > > You can stop the warnings by updating your firmware to more completely > describe the system - ideally all the supplies in the system would be > described for future proofing. Or if this is a custom software stack > just delete whatever error checking and warnings you like. The warnings > are there in case we've not got something mapped properly (eg, if there > were a typo in a property name) and things stop working, it's not great > to just ignore errors. A lot of this is really not under our control. > > > So I ask you to allow the code as is. If you still insist, I will > > change and resubmit. > > Remove it, conditional code like this is just as bad in this driver as > it is in every other one. I will remove this and resubmit. Thanks, Jim Quinlan Broadcom STB _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel