From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763FBC433EF for ; Thu, 11 Nov 2021 18:19:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CC5D61284 for ; Thu, 11 Nov 2021 18:19:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3CC5D61284 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=77Q2DsCT8ara1CKRU5A6zxywY3bf3Lt5GPWVDgnYVZ0=; b=w2831i0b/+Hvdc CjOC7kM9fxZNWNQ5Z7X6vIkJwRR86cr4kHoYk7w+rQopTZdB5JCH5dOSm7NiXf6G36ViKLRu/mrgH drNqDaIIPkhxdimGibTBJBN/FAuK41D4NfSj/8a8UXEgMvHa38B40/CxGTXJTQfemUy78tEUy9GQq J5QhhQkvvavN9KsLxtHT03Lq2mdT82wG6TFOOncI4Z/JpWBWulzU5/Qd3kjfgucaMCv8yE6MUpzXv Z8METeKSkhnT7ZpiI780axjZe0W+3salzIU+IVrnO722qD663L170KsWrd4+j5fcP4u31dSBOJNoX dDK7hPK93c3Tsps+atxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlEei-008YAa-RY; Thu, 11 Nov 2021 18:18:37 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlEee-008Y9b-92 for linux-arm-kernel@lists.infradead.org; Thu, 11 Nov 2021 18:18:34 +0000 Received: by mail-ed1-x52a.google.com with SMTP id c8so27187792ede.13 for ; Thu, 11 Nov 2021 10:18:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vnmxwn/tZeM/AHymk+3atT3H8KaElmrCo0Jws8wvOvA=; b=ExqD7I0dtPteyE+rPa5NxBrJ7mWXCX+6K1XnVBIyiRxmjTpjy34M1yZ+ZD7k7I4cX+ 3Kv4LeG1cljOnPaqMNOchb3VsUdPhPadvZlrLJGHAVa8957yvCXygvk5luW7ripmeG0w saAdMc0h1DFLV2cBJ8i/Fl5fk4kpkkHxCTZR1OKOw8g4WCD5qMzTPch2VzJpAGzFr59R qrK/I5pmFTyRZj7a6hJOqUUE9f6lKnLzx2Bd4fltBrKni+AHa1GQ2KJUJIEc0mVhPxP/ hXcyFM7WSLBj+CNM73dVat6eZZy+SKKKNGCPfHMIn6EzLvj6PziP2kjslddOiS4hVcvD n5OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vnmxwn/tZeM/AHymk+3atT3H8KaElmrCo0Jws8wvOvA=; b=RaB9RSBQb0uwQvLxHdP8BDxhTF9ALTb27lxuQUmfGI6SsJOg8E99teom8KSUjs+ojT tzdl6f3RA9r4ATuD1rFom6wTmhgG33tWedSOOq+llLeuCK4wYXCQPrYjv7sMMO6EXiQI 9REY657bns1Q4ek9gKBFm6OEeIEqsenqY2PM+2ojzh6Q2KWXDBG/kxFHLkGUuweF8/v4 7y6WoeF4e90plcpksqFQehDVvHsFYuspNN7LgABPW1AZTxFwTym98KfF2h/LS50y47ci yj5+K/WFXNVTRVuSeQfh90Kbdy2JT8e+ZrKpyChWcsxk6JP5qMk5nMmmn3ND3jewUcP4 SKRw== X-Gm-Message-State: AOAM531zWKnSeCtv5GY1Z2WvWMD4A/4W/yngGB9j9ljJYGLzPHj6M5p8 0Au/gyig+w73q6UqmgO3ZrDxE4NyCSdD8JIdi2fgfg== X-Google-Smtp-Source: ABdhPJzba7bVic9RyDyOSTksjvjV62o5u0z5w36iz4HU98btIq1dlbOxkB93U98vp5KpeLHVHkfLQgWCDJugvMeQGGU= X-Received: by 2002:a17:906:4d4a:: with SMTP id b10mr12055937ejv.89.1636654710614; Thu, 11 Nov 2021 10:18:30 -0800 (PST) MIME-Version: 1.0 References: <20211102141535.28372-1-mark-pk.tsai@mediatek.com> In-Reply-To: <20211102141535.28372-1-mark-pk.tsai@mediatek.com> From: Mathieu Poirier Date: Thu, 11 Nov 2021 11:18:18 -0700 Message-ID: Subject: Re: [PATCH v2] remoteproc: use %pe format string to print return error code To: Mark-PK Tsai Cc: ohad@wizery.com, bjorn.andersson@linaro.org, matthias.bgg@gmail.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, yj.chiang@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211111_101832_990788_3DC1DB60 X-CRM114-Status: GOOD ( 18.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mark, On Tue, 2 Nov 2021 at 08:15, Mark-PK Tsai wrote: > > Use %pe format string to print return error code which > make the error message easier to understand. > > Signed-off-by: Mark-PK Tsai > --- > drivers/remoteproc/remoteproc_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index 502b6604b757..2242da320368 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -575,8 +575,8 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr, > dma_get_mask(rproc->dev.parent)); > if (ret) { > dev_warn(dev, > - "Failed to set DMA mask %llx. Trying to continue... %x\n", > - dma_get_mask(rproc->dev.parent), ret); > + "Failed to set DMA mask %llx. Trying to continue... (%pe)\n", > + dma_get_mask(rproc->dev.parent), ERR_PTR(ret)); Macro ERR_PTR() is used to convert error codes to pointer type when returning from a function - I fail to see how doing so in a dev_warn() context can make the message easier to understand. Can you provide an example? Thanks, Mathieu > } > > /* parse the vrings */ > -- > 2.18.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel