From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63FA5C4360F for ; Wed, 3 Apr 2019 04:32:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 307BD206C0 for ; Wed, 3 Apr 2019 04:32:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YnZdsfx8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="BbZVYyg8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 307BD206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wTzvUsKmeNdiogOs4rFayi9NGtQJdrUNqlLDcBWw7vE=; b=YnZdsfx8A4ujzz fAQWnTJ+pEW5bJeEU/mS7ELmtqQVXntkOMDvYgRiLj4U3U07KkvJ2CtAu1igAujBXY+i5Sr7bGHg1 hzp0o4e4dKjKkemgo9xigUUAA8ZnA3VmvvfWe5OrporHJZmwwOrLOo+EqRtXq4Y8u0tSL7PP+jFyy a5zelHad1hJ0WYgSM/6Gshis986VrGKhKOVLQ2DLDOxxhkO3i/im3BJIY1byIfdZbcG+3Q4Iv+BKC P3/mO/vVwn/yC2gcFJAVKqn3f3S/gm+7tFRxqoexFEGXkq/E6lZHw8v27gwxovAjrUKuwiMh0QSPI vDfVSWQNInOZgyqohWxQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBXZW-0005dX-W6; Wed, 03 Apr 2019 04:32:22 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBXZS-0005cA-4D for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2019 04:32:19 +0000 Received: by mail-qt1-x844.google.com with SMTP id w30so17771571qta.8 for ; Tue, 02 Apr 2019 21:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=S57beQPqnsWH7c2yhxwG0r7rfdOqzi6B+T57wk8rq/M=; b=BbZVYyg8g6syDUQKFjBvTT9cLUZZE7a6OoGz+AIY0bEwIXN9dYTEbQaMsqnN4pxqOI 2r0+OQ+53kGWyP2J80MdrjT1505TRde0MzZ6us98yNcBZuc6C7WbyPZUduN1fogM437b G1cTOHaQO47gppSFUJUHRq0GoKVkpZiZM1PaI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S57beQPqnsWH7c2yhxwG0r7rfdOqzi6B+T57wk8rq/M=; b=ds7cwifGh4Dh2WTGJblgjOvB9xBtrG3SNvdaTLBgQsAxQ6i5k1E7PkbVWotxQGZzz/ /ONwC3H7h0X3Nx94fKph/m5jUSX2Cyt5BJnZLh5Yzl5YpbOyqzazDbyG7McUt5CbN5Wa hETsESEwtGJemwFXkWtcp1UpShxYvWtz+1HarPjn/A/xSTWqXqS8STK6DrlRvlsGpcRD jhuMwnr4imM4Ob9W7IJSyyGmnTitVJs9F4Fz3gP16HOdR8w39yXGJKYoiU3mndV17cPq yf5OlPvD/p/bfQsfkJYKEOlzZdO4MNFVV3MBxPR32KOlR7EDNagO9ZK6D68dtl2ew76T vjJQ== X-Gm-Message-State: APjAAAUJfwdmS1lnSB1WLl5KRvOKOxzFZHEcYOh54dOEIkqnbMnj2m4M sv8qLa6pux/A2ZU4fyB7Rw5RWliRUwIFAtNeJhNTbg== X-Google-Smtp-Source: APXvYqwCMzL/Q6XymiDfrIN3Qb+qE6BeNX7uPJe7jrtKFSR5gRQ8ao3MXoV+ChtaAA8YTutR2Ju+mySkTo3kVL2gS+w= X-Received: by 2002:ac8:2ed7:: with SMTP id i23mr61752841qta.326.1554265936440; Tue, 02 Apr 2019 21:32:16 -0700 (PDT) MIME-Version: 1.0 References: <1553841972-19737-1-git-send-email-andrew-sh.cheng@mediatek.com> <1553841972-19737-3-git-send-email-andrew-sh.cheng@mediatek.com> In-Reply-To: <1553841972-19737-3-git-send-email-andrew-sh.cheng@mediatek.com> From: Nicolas Boichat Date: Wed, 3 Apr 2019 12:32:05 +0800 Message-ID: Subject: Re: [PATCH v2 2/4] opp: add API which get max freq by voltage To: "Andrew-sh.Cheng" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_213218_213808_4D9DA190 X-CRM114-Status: GOOD ( 23.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream , linux-pm@vger.kernel.org, Viresh Kumar , "Rafael J. Wysocki" , lkml , Rob Herring , Chanwoo Choi , Kyungmin Park , MyungJoo Ham , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Fan Chen , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 29, 2019 at 2:46 PM Andrew-sh.Cheng wrote: > > This API will get voltage as input parameter. > Search all opp items for the item which with max frequency, > and the voltae is smaller than provided voltage. > > Signed-off-by: Andrew-sh.Cheng > --- > drivers/opp/core.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/pm_opp.h | 8 ++++++++ > 2 files changed, 63 insertions(+) > > diff --git a/drivers/opp/core.c b/drivers/opp/core.c > index 0420f7e..7323cd9 100644 > --- a/drivers/opp/core.c > +++ b/drivers/opp/core.c > @@ -526,6 +526,61 @@ struct dev_pm_opp *dev_pm_opp_find_freq_floor(struct device *dev, > } > EXPORT_SYMBOL_GPL(dev_pm_opp_find_freq_floor); > > +/** > + * dev_pm_opp_find_max_freq_by_volt() - Search for a opp with max freq > + * under provided voltage > + * @dev: device for which we do this operation > + * @u_volt: provided voltage > + * > + * Search for the matching available OPP which provide voltage can support. > + * > + * Return: matching *opp, else returns ERR_PTR in case of error > + * and should be handled using IS_ERR. > + * Error return values can be: > + * EINVAL: for bad pointer > + * ERANGE: no match found for search > + * ENODEV: if device not found in list of registered devices > + * > + * The callers are required to call dev_pm_opp_put() for the returned OPP after > + * use. > + */ > +struct dev_pm_opp *dev_pm_opp_find_max_freq_by_volt(struct device *dev, > + unsigned long u_volt) > +{ > + struct opp_table *opp_table; > + struct dev_pm_opp *temp_opp, *opp = ERR_PTR(-ERANGE); > + > + if (!dev || !u_volt) { > + dev_err(dev, "%s: Invalid argument volt=%d\n", __func__, > + u_volt); u_volt is an unsigned long, so you should use %lu. drivers/opp/core.c:582:3: error: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Werror=format=] chromeos-kernel-4_19-4.19.32-r271: dev_err(dev, "%s: Invalid argument volt=%d\n", __func__, chromeos-kernel-4_19-4.19.32-r271: ^ > + return ERR_PTR(-EINVAL); > + } > + > + opp_table = _find_opp_table(dev); > + if (IS_ERR(opp_table)) > + return ERR_CAST(opp_table); > + > + mutex_lock(&opp_table->lock); > + > + list_for_each_entry(temp_opp, &opp_table->opp_list, node) { > + if (temp_opp->available) { > + /* go to the next node, before choosing prev */ > + if (temp_opp->supplies[0].u_volt > u_volt) > + break; > + opp = temp_opp; > + } > + } > + > + /* Increment the reference count of OPP */ > + if (!IS_ERR(opp)) > + dev_pm_opp_get(opp); > + mutex_unlock(&opp_table->lock); > + dev_pm_opp_put_opp_table(opp_table); > + > + return opp; > +} > +EXPORT_SYMBOL_GPL(dev_pm_opp_find_max_freq_by_volt); > + > static int _set_opp_voltage(struct device *dev, struct regulator *reg, > struct dev_pm_opp_supply *supply) > { > diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h > index 24c757a..57deef9 100644 > --- a/include/linux/pm_opp.h > +++ b/include/linux/pm_opp.h > @@ -102,6 +102,8 @@ struct dev_pm_opp *dev_pm_opp_find_freq_exact(struct device *dev, > > struct dev_pm_opp *dev_pm_opp_find_freq_floor(struct device *dev, > unsigned long *freq); > +struct dev_pm_opp *dev_pm_opp_find_max_freq_by_volt(struct device *dev, > + unsigned long u_volt); > > struct dev_pm_opp *dev_pm_opp_find_freq_ceil(struct device *dev, > unsigned long *freq); > @@ -207,6 +209,12 @@ static inline struct dev_pm_opp *dev_pm_opp_find_freq_floor(struct device *dev, > return ERR_PTR(-ENOTSUPP); > } > > +static inline struct dev_pm_opp *dev_pm_opp_find_max_freq_by_volt(struct device *dev, > + unsigned long u_volt) > +{ > + return ERR_PTR(-ENOTSUPP); > +} > + > static inline struct dev_pm_opp *dev_pm_opp_find_freq_ceil(struct device *dev, > unsigned long *freq) > { > -- > 1.8.1.1.dirty > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel