From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B708C31E44 for ; Fri, 14 Jun 2019 08:31:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F2432168B for ; Fri, 14 Jun 2019 08:31:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YHPfVnpT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="i23VuOuZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F2432168B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zNSxXVfLoogpnv8jRbg4cr2kUwz9nuvCVVhMeHiZ+B0=; b=YHPfVnpTHAm/iQ CjbGm4vgsXpO6naOHyLKjlZ7Z3AtDil0pQQahBnJE01b+RuGyYWIRkD9km1yUQxgAGgHf09xNfOf3 ZxcaySR3I1f3Gyf1VOwyER3nEaor5iUAoaxBfVHXdf9XgstMjnU5EQaPMdQvGTmWY9W1JViuEQI9r 07xq5o9BlQWRE0aYGBeUqK7gfDbWedt3yNw+k+T77vMVq3Rj2AjY4VXVwZ1zNwdVoztgatqpvYPmo efFemDaSqzfzDn8QZBEjetmRIgPzfc/JZlEYBNTNM/k4L8BzhP8GsvlS6sDEJ0MRC1fCF+tc2zvWq Tvye+335dBnXpWocTE2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbhce-0006ZO-6V; Fri, 14 Jun 2019 08:31:44 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbhcY-0006X8-DZ for linux-arm-kernel@lists.infradead.org; Fri, 14 Jun 2019 08:31:41 +0000 Received: by mail-qt1-x841.google.com with SMTP id h21so1487218qtn.13 for ; Fri, 14 Jun 2019 01:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WFDrQf4njTwrCLjFsRfgBfcro7/dqMXuf3KcCnlG7eU=; b=i23VuOuZ0hfuRp/LswwKqj7gDp6Tlmafsj4Mm0OMRl4Vx/LbKVjew4IdJyh3RXRsBS oJ/pXT42q4cyS1GSeDiksQD1bOpT84+3YUseJco/7CZjfBO5lFktZvECavHicuyZdmvD u7U+7MQWSzNnpAJaO1w7qNqlIB/B345yxOQ8k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WFDrQf4njTwrCLjFsRfgBfcro7/dqMXuf3KcCnlG7eU=; b=J20xLcPKfKt7A4AUkRgYlw97+eFXLmY/essfDpRnK4EaGGD/4240FNxsS6xBiyhZLm mFLLUHt2KccXhI0JSB3tV3p+bddg4wG0vh0lX8G9wrijNSBzEygIJXcWlWqDtbLm45fZ plnaM7ZFWkZGkbH+aX1A470bZIjCOtm+zAANntUeELebbIUhBBKGK2EpJCarqQ74t5k/ OyPF0NFwF2R7CsGAMiS4Dc8NT7T5CvMQGNGp3WICXKOtzD/98mFrrxqQAl+I3/0VxJcn lrCm5V5BqKsvQgs9gwTJhGWggeLaXJxbH6AkYGggZnyiyt/T5CZwEWvY3Yrt9M4/yWhB m/Lw== X-Gm-Message-State: APjAAAXHhAqwcAIZVqZDZkzHIb5p2LgD0kTBNhC0YKUOoREliBcZhXOE 0Uc/xbGH3LYXFKJ3dCfWTzFXBGDt2Iqg6eI9tmmURw== X-Google-Smtp-Source: APXvYqwJxz2R9C2u4+JZCsLN1H0xVaea7YSFUZIYK7HKRBDxLRfIPlaG5zng2MeCFRi/Ky0Kb1OnwOXd9vUp1mXjvOw= X-Received: by 2002:ac8:279b:: with SMTP id w27mr7486636qtw.159.1560501096909; Fri, 14 Jun 2019 01:31:36 -0700 (PDT) MIME-Version: 1.0 References: <20190612085349.21243-1-bibby.hsieh@mediatek.com> <20190612085349.21243-12-bibby.hsieh@mediatek.com> In-Reply-To: <20190612085349.21243-12-bibby.hsieh@mediatek.com> From: Nicolas Boichat Date: Fri, 14 Jun 2019 16:31:26 +0800 Message-ID: Subject: Re: [PATCH v8 11/12] soc: mediatek: cmdq: add cmdq_dev_get_client_reg function To: Bibby Hsieh X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190614_013138_491875_F6DEB551 X-CRM114-Status: GOOD ( 16.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, YT Shen , Philipp Zabel , srv_heupstream , Daoyuan Huang , Sascha Hauer , Jassi Brar , lkml , Daniel Kurtz , Dennis-YC Hsieh , CK HU , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Houlong Wei , Sascha Hauer , Matthias Brugger , Jiaguang Zhang , linux-arm Mailing List , ginny.chen@mediatek.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 12, 2019 at 4:53 PM Bibby Hsieh wrote: > > GCE cannot know the register base address, this function > can help cmdq client to get the cmdq_client_reg structure. > > Signed-off-by: Bibby Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 24 ++++++++++++++++++++++++ > include/linux/soc/mediatek/mtk-cmdq.h | 20 ++++++++++++++++++++ > 2 files changed, 44 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 70ad4d806fac..fac4d33fd520 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -27,6 +27,30 @@ struct cmdq_instruction { > u8 op; > }; > > +int cmdq_dev_get_client_reg(struct device *dev, > + struct cmdq_client_reg *client_reg, int idx) > +{ > + struct of_phandle_args spec; > + > + if (!client_reg) > + return -EINVAL; > + > + if (of_parse_phandle_with_args(dev->of_node, "mediatek,gce-client-reg", > + "#subsys-cells", idx, &spec)) { > + dev_err(dev, "can't parse gce-client-reg property (%d)", idx); > + > + return -EINVAL; > + } > + > + client_reg->subsys = spec.args[0]; > + client_reg->offset = spec.args[1]; > + client_reg->size = spec.args[2]; > + of_node_put(spec.np); > + > + return 0; > +} > +EXPORT_SYMBOL(cmdq_dev_get_client_reg); > + > static void cmdq_client_timeout(struct timer_list *t) > { > struct cmdq_client *client = from_timer(client, t, timer); > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > index a345870a6d10..2e2a2274c231 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -15,6 +15,12 @@ > > struct cmdq_pkt; > > +struct cmdq_client_reg { > + u8 subsys; > + u16 offset; > + u16 size; > +}; > + > struct cmdq_client { > spinlock_t lock; > u32 pkt_cnt; > @@ -142,4 +148,18 @@ int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb, > */ > int cmdq_pkt_flush(struct cmdq_pkt *pkt); > > +/** > + * cmdq_dev_get_client_reg() - parse cmdq client reg from the device node of CMDQ client Minor nit: this line is over 80 chars. > + * @dev: device of CMDQ mailbox clienti > + * @client_reg: CMDQ client reg pointer > + * @idx: the index of desired reg > + * > + * Return: 0 for success; else the error code is returned > + * > + * Help CMDQ client pasing the cmdq client reg > + * from the device node of CMDQ client. > + */ > +int cmdq_dev_get_client_reg(struct device *dev, > + struct cmdq_client_reg *client_reg, int idx); > + > #endif /* __MTK_CMDQ_H__ */ > -- > 2.18.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel