From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC1D5C4345F for ; Wed, 17 Apr 2024 16:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bkk2qsuV7A8f/5ngRpnORZ8idkXELex0RLgWUKQ0b2w=; b=OMf7i+txyszS6p R6zDNR4IIvMz2vp9qvsza2gzWrD551UZmP6Aqre/nfsuovywtFDkIcAR1GXOqu5gWzTXbrglmVuQa Ur2zRIXQ0M0pQv0n8QL4fN3Y99fkVS44VPOOJx5xnrcPhubULNxqJCoed92Qb+X1GURKuAZXw/+ZQ m8oE37qyHz9Q+VjXSOrswlMaZwzwn4vKOG25qBJFE5UYurvYzM3/Zr+sIsthwPN0uSO3OlqvrzbuW vywfHGlaf9X91OnDFRHntng751SIPY4ophZNhqvUcoFVAIZK8hPWdLfY98TaO/hKxH29y3KFz/MMP QqA9HvSB9kvjEu9j7GtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx80y-0000000Gmin-0BQ4; Wed, 17 Apr 2024 16:20:04 +0000 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx80o-0000000Gmdg-0MWH for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2024 16:19:55 +0000 Received: by mail-oi1-x234.google.com with SMTP id 5614622812f47-3c3d2d0e86dso2693393b6e.2 for ; Wed, 17 Apr 2024 09:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713370792; x=1713975592; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=taaoAprv/l78nPfrpJUaaECkLiisEqHYV1iSW1K7qDE=; b=fxvq73adxI0JnVLddwwkbOsGkqtl79kMEe74Ix97m/oT9EENqV0I0QS15el2Xn7Kuw QgQZcu64IjjmURpVN5K3u2lLE5tHbnDcEuHag3a9yC1RyNaK/2DFCrqRZwwlr6b9TwbQ uq18ejcmlsF6+cz+Kbjy2KgXPNoEWHF9X6blw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713370792; x=1713975592; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=taaoAprv/l78nPfrpJUaaECkLiisEqHYV1iSW1K7qDE=; b=PssMLvycPYFYixoBdaZ7fWuX2vxjqnp7pXmAQ1g9sdVVQUX2yyNCwA8GW6ysTD24QZ /KS4ocsjvXYQ0PQpbF008ZRhrUMfGdeVahLTPnlHVVn57YohJZGcwFrE5X0GwCazBLnh ACXyQWxKO1pcPKgoW7UOhGB4bUMZXknIwrwwVuty3eM6QdRvUze1PXmmJt6edaSBETZj VivznEHo9Ej7Uqk7EHkjKMbmQM2WJJQ05V+lDkIXLOjdjYjmUGmBVJvL8Mc1bIqvsNh/ uybgn26ZA+F8KVVDBgrKet4mnASESQhPpUg4tZuzwbyDSlXaoeiPKoh72Y6hQmOpR+/J OB/w== X-Forwarded-Encrypted: i=1; AJvYcCWNR+6ocgDK4VYlE1vj0qzpwPXPcrMj5FcqxNcuvZ20aVtdFCflg8CYF2reMViUKr/G/2yesoKcsl5jGGGwLsNhBWNK3wzNusOIdqllwcbPRa95nUk= X-Gm-Message-State: AOJu0Yy1d52kd+JGcWOQdWtd1CKOOroWpVXOnagbJeleAnyuwr/lknnF ZiCnS0Ad9c2ljBtc+vSa9+Y7st9Gx/fGxJia3mAHWOH6V3y1wWmg0wVz2mm9mDS75t1l+UR20Po UQA== X-Google-Smtp-Source: AGHT+IFKfQ+1BQIJrG3RmM6H28oaWkxtMMmd9MUx+xjVeH5wA15Od/ZCtIBsHZ/bSP6PR87DLh573g== X-Received: by 2002:a05:6808:624b:b0:3c5:e66b:1f79 with SMTP id dt11-20020a056808624b00b003c5e66b1f79mr2018oib.16.1713370791974; Wed, 17 Apr 2024 09:19:51 -0700 (PDT) Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com. [209.85.160.47]) by smtp.gmail.com with ESMTPSA id cn14-20020a056808350e00b003c5ed0d7d24sm2450312oib.18.2024.04.17.09.19.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Apr 2024 09:19:51 -0700 (PDT) Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-2352cc0b076so1093005fac.0 for ; Wed, 17 Apr 2024 09:19:51 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVnEKOtHeO97SzuM3MxmCIxaYZXf40VioUfPgCzl+/Db5PyCgggcxRhvdHGpJX2qcy6PC7JEny6FV3JxYLHKuen2dujL7uQSix/HLHoTRvb/+qlhNY= X-Received: by 2002:ad4:4f23:0:b0:69b:5445:6ab0 with SMTP id fc3-20020ad44f23000000b0069b54456ab0mr19079283qvb.46.1713370770447; Wed, 17 Apr 2024 09:19:30 -0700 (PDT) MIME-Version: 1.0 References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240417155112.GQ12561@pendragon.ideasonboard.com> In-Reply-To: <20240417155112.GQ12561@pendragon.ideasonboard.com> From: Ricardo Ribalda Date: Wed, 17 Apr 2024 18:19:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/35] media: Fix coccinelle warning/errors To: Laurent Pinchart Cc: Dan Carpenter , Martin Tuma , Mauro Carvalho Chehab , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , "Bryan O'Donoghue" , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Pavel Machek , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Oleg Drokin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_091954_162077_C518BE7B X-CRM114-Status: GOOD ( 30.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent On Wed, 17 Apr 2024 at 17:51, Laurent Pinchart wrote: > > On Tue, Apr 16, 2024 at 11:47:17AM +0300, Dan Carpenter wrote: > > In my opinion, it's better to just ignore old warnings. > > I agree. Whatever checkers we enable, whatever code we test, there will > always be false positives. A CI system needs to be able to ignore those > false positives and only warn about new issues. We already have support for that: https://gitlab.freedesktop.org/linux-media/media-ci/-/tree/main/testdata/static?ref_type=heads But it would be great if those lists were as small as possible: - If we have a lot of warnings, two error messages can be combined and will scape the filters eg: print(AAAA); print(BBBB); > AABBBAAB - The filters might hide new errors if they are too broad Most of the patches in this series are simple and make a nicer code: Eg the non return minmax() , Other patches show real integer overflows. Now that the patches are ready, let's bite the bullet and try to reduce our technical debt. Regards! > > > When code is new the warnings are going to be mostly correct. The > > original author is there and knows what the code does. Someone has > > the hardware ready to test any changes. High value, low burden. > > > > When the code is old only the false positives are left. No one is > > testing the code. It's low value, high burden. > > > > Plus it puts static checker authors in a difficult place because now > > people have to work around our mistakes. It creates animosity. > > > > Now we have to hold ourselves to a much higher standard for false > > positives. It sounds like I'm complaining and lazy, right? But Oleg > > Drokin has told me previously that I spend too much time trying to > > silence false positives instead of working on new code. He's has a > > point which is that actually we have limited amount of time and we have > > to make choices about what's the most useful thing we can do. > > > > So what I do and what the zero day bot does is we look at warnings one > > time and we re-review old warnings whenever a file is changed. > > > > Kernel developers are very good at addressing static checker warnings > > and fixing the real issues... People sometimes ask me to create a > > database of warnings which I have reviewed but the answer is that > > anything old can be ignored. As I write this, I've had a thought that > > instead of a database of false positives maybe we should record a > > database of real bugs to ensure that the fixes for anything real is > > applied. > > -- > Regards, > > Laurent Pinchart -- Ricardo Ribalda _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel