From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7857C3DA45 for ; Mon, 15 Jul 2024 08:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UxvuVs2RYdJvTG90vVQNL3KW5LdM1oQjpCuXib7OYPg=; b=kIsspdXbNQIf5ly4bablmJiOyA DSqG6QXWQ0lS7GDrKla9jxfR7CxvFgOE3EOYLm8ITUj94Mf9URmM7J6sRWBu5UGmzZ4pgm8GaDkbM DwMKBgikm6SwJFhRTVP+4qaQzTj9bZkMKnG1gw9CYIYitO2LNoQfAGAq/Do8EE0fIfoGyi5cvO8Rb VeIW/acuHXP7ku3qKuNG3a7+qH9Q9/J2LAnfua6VTXev/jd8BTDVmEv/GklPQAWpKWR0D5+wREqDW JSdbE1XIQdHjiIUubdgHHcZursQrbwxB3vB3UA4A63NOCuiaCIgWokQaI6Nxf+ivLgAeHQaF7TB4D HSht9QMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTGzF-00000006Ip3-3JiL; Mon, 15 Jul 2024 08:23:09 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTGyw-00000006Ijm-14do for linux-arm-kernel@lists.infradead.org; Mon, 15 Jul 2024 08:22:51 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-58b0dddab8cso6284017a12.0 for ; Mon, 15 Jul 2024 01:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1721031768; x=1721636568; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UxvuVs2RYdJvTG90vVQNL3KW5LdM1oQjpCuXib7OYPg=; b=bhWMA/KIwkSX8njQIGvbBZBtPNnnY/cfa2pFmFPJ13pZ4Gh8lad1Qb+sZzQgu5Rz/H 5d9C/7FDhPWdC8qcPxu/9L7Ka36R9ligRvBvXzPgp6qgtbmVghNNB21pm8x6dUurS7Hc EYTc04hNML4TEW/w6vFp6QY4WlQVxH2CLGjz8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721031768; x=1721636568; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UxvuVs2RYdJvTG90vVQNL3KW5LdM1oQjpCuXib7OYPg=; b=fCO8+FTItDsUFfjrTXj2AE0EE7ymIiKWHQAc6FzILO6jdNRAY5tlnKFex4VvKPkAOs 4VLRitKh2z7+zrmTkWu6oqS0Rr2d0AIIa2Qka8Crd5uZNDKdPD9mICDweuJcnVLvciLe jrcPZtO+eQ4qv146Ud0xjRnhpm9Rj/okK9NWrIux+RFP6+iLDMZ1mXR5aCBUwvNFTrIG k5ez/Nf4fvYHX+7IVsg0CDeUVv/p6C/cmCIbgY8WWg9BjAv1oTI5QI5PRnHOrp32Nbrm YhJEyDAKJ/+mQX/NMLkSSc16yd9J0uFaqfsLPWqxfvDsTTHTF/cRuISjEk4PixA0myLu 33Cg== X-Forwarded-Encrypted: i=1; AJvYcCVdQo7ZuIVztHyIsHehdx+84gYsrjXOv0PdZ6+9gtxWwakdTIzL2CQBCVMXLh0Iw7ww4U2J7IzCef4Q+qDDjIX6cllwsCpNo/ZzdVQC1pgr0IQgVKg= X-Gm-Message-State: AOJu0YwnosgHSNrdLb8MwXT40Ya7LT0sF2Se9Qh3taa8GT0iD/YRHhk/ MNdYA5S+rIdnsxW+OGBVpXrBbxwEHG7AiDAhvzf2mn7QaQ6u0037W7LFMd9X1DfQ0x/2Tarp9Ee N+Q== X-Google-Smtp-Source: AGHT+IHAKP0iGrs2yb18VWcVsUnh5+HVIEZtJ6+Z2bbQccbK6h1k0Cswonyzb1xf8DeJlXNi6qLhGw== X-Received: by 2002:a17:906:f592:b0:a79:7dd2:5b99 with SMTP id a640c23a62f3a-a797dd25c52mr1152787166b.28.1721031768050; Mon, 15 Jul 2024 01:22:48 -0700 (PDT) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com. [209.85.218.44]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a79bc7f1d38sm193925966b.140.2024.07.15.01.22.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jul 2024 01:22:46 -0700 (PDT) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a7523f0870cso440687366b.3 for ; Mon, 15 Jul 2024 01:22:46 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVoMS8M0XkDddU1KAFGYjmF1uGwp6SfMB/A0HdBCPxbfDaAfiyviIyQ60m5Kz2aebnU5I8naRYjf7vqk9osypO50B5WwVKF61Euyn+zbEelxyHC08I= X-Received: by 2002:a17:906:46c9:b0:a77:e2b2:8ec with SMTP id a640c23a62f3a-a780b68899dmr1183961966b.3.1721031766301; Mon, 15 Jul 2024 01:22:46 -0700 (PDT) MIME-Version: 1.0 References: <20240628-gcc5-v1-1-7cd56f04a6a8@chromium.org> <7dbda1952c9e873823d4e6d2a9534f1b3b945c4a.camel@pengutronix.de> In-Reply-To: <7dbda1952c9e873823d4e6d2a9534f1b3b945c4a.camel@pengutronix.de> From: Ricardo Ribalda Date: Mon, 15 Jul 2024 10:22:34 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] media: imx-pxp: Rewrite coeff expression To: Philipp Zabel Cc: Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hans Verkuil Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_012250_336147_2DBF3EC1 X-CRM114-Status: GOOD ( 17.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Philipp On Mon, 1 Jul 2024 at 11:30, Philipp Zabel wrote: > > On Fr, 2024-06-28 at 15:11 +0000, Ricardo Ribalda wrote: > > GCC5 cannot figure out that the expressions are constant, and that > > triggers a build failure. Rewrite the expressions. > > > > The following gcc5 error is workaround: > > > > #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 > > ^ > > BM_PXP_CSC1_COEF0_YCBCR_MODE | > > ^ > > #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 > > ^ > > > > drivers/media/platform/nxp/imx-pxp.c: In function 'pxp_setup_csc': > > drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant > > drivers/media/platform/nxp/imx-pxp.c:374:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' > > drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt601_lim[0]') > > Signed-off-by: Ricardo Ribalda > > Can you elaborate on how this is triggered? Building the driver with https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64/5.5.0/ It might be easier to repro with: ribalda@denia:~/work/linux$ podman run --pids-limit=-1 --rm -it -v .:/workdir registry.freedesktop.org/linux-media/media-ci/build-ancient # cd /workdir # CROSS_COMPILE=x86_64-linux- make allyesconfig # scripts/config -d MITIGATION_RETPOLINE # CROSS_COMPILE=x86_64-linux- make olddefconfig # CROSS_COMPILE=x86_64-linux- make drivers/media/platform/nxp/ > > At least I couldn't reproduce this by just copy & pasting the > csc1_coef_bt601_lim initializer and the required macros into gcc 5.4 on > godbolt. > > Can this be fixed by using GENMASK / FIELD_PREP instead? I was looking to make the change as simple as possible :) > > regards > Philipp -- Ricardo Ribalda