From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B71C5C4338F for ; Wed, 25 Aug 2021 10:01:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 875DD61076 for ; Wed, 25 Aug 2021 10:01:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 875DD61076 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j7kAhRyPDEehDvGyHYYERIWWqUN6Pm1iwM4WN1kWNls=; b=d6N6YP9ipbZRca zqtUdLnSPO9YFnJkjI9wuFXdLhaH6jCBh2PDyDBgLH14/vihfrkzmBQYi4PPdZkid3Krf9mcvCnEr 0NWUAmgpdn41325DBAEoafiTUoVJd1+PPydshHmOqWZigWGO4VC+YeQUWJn8Fv+v9L74G4/HvBnTu 9LbdiDwDuOdgtl3mKSQUR+mLCC8MSYxp3lU/57ZVcfxeB9OndAio1YIw/PASixR+tuXgMJeiJZWgz 0CJK36G0wfpsRQswA7IQAyxd/NCEd7ki6DsFP2ezxBkH1vgoMklxgEcbzz084tdm3DNG7+9Kh3sXF l0IgmvGj0AwUJIsNu0Qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIpgs-006Iwe-0N; Wed, 25 Aug 2021 09:59:26 +0000 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIpgj-006Itv-A6 for linux-arm-kernel@lists.infradead.org; Wed, 25 Aug 2021 09:59:22 +0000 Received: by mail-ot1-x32c.google.com with SMTP id i3-20020a056830210300b0051af5666070so44343385otc.4 for ; Wed, 25 Aug 2021 02:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RT/ruHmEJSYewLcThfyctJrU8xPbr8Cf1G+FiOsvBbc=; b=kH94v5ZxPDA7JSNS32fZwHKxAXd60dS9blcW/t47MaGYzjYnCKVR19RucXnY57xNKr BUrzW/8zOQIKcpWMsaITLqjndyxPgOYKArgLmXMjrv8eavPanrhDnYdJ4XMtUImJ2pQ2 KBpVSuyz0k1kju91c+0Cv+SMsrvZmMf7EQ3VXi1Ld/R9ZOogfsLocTo7KlnhKbz7t3Bf yf1L4Pjtkr1utHQrJxKKNdJiDxUmGOX7XIkK4gFmNhbQuEhRVkWVlryWVInLfVUwoldi FoJvcETwbTnVZyeldnHF6u+10bxhp+2VPaVASQNoVY0kLIkzR5f++l3n9FBLUBUN+o+U 9vtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RT/ruHmEJSYewLcThfyctJrU8xPbr8Cf1G+FiOsvBbc=; b=VG847zqJrZLgx2eB14BQejPCIuSQANts9sLiKUg192KSlTU9aZf1FxJKQdcNePo48e HddvMhClIkGx4kS/jS8ds3lNway/FUxF6L+5aPsqTlN115QV+45ns5ALaQPstwzMFRqw Iz+GdR95wk+TPWRIQWqAAF0zywN3w7DSNVpRlOGzopolOh/PycsFptz7IyPSkTwY3u+d 3jX0YS7O/gBuiBEMZMAsF3KQEFvtB4OH630iWDpHVCg50y07c7o6ZsPt4Ff8c0P4yNZx I8MRqaLA5gRBbsoQV6WZ2eii5qaN0fw0bhKu/rv/Ohh8vwPZ0151ATNp/QOPK+deBuFv oItQ== X-Gm-Message-State: AOAM530DoTCvOhw3UXAkIHle2LRtlWFaQ1AJa912BD+lzRv2uVUwVLcn r7pkiWr17duYX4/oqYJuGnsKngJPuo6vuSC7+23DdQ== X-Google-Smtp-Source: ABdhPJx2usLhYzv+VjiLuR95RXRD8SNaj20fFAitgqXBEpUoTneeal2gi19km1Bp9KPiR4r6uJfBVYv99DlHTSaUqlA= X-Received: by 2002:aca:4589:: with SMTP id s131mr6136352oia.121.1629885556155; Wed, 25 Aug 2021 02:59:16 -0700 (PDT) MIME-Version: 1.0 References: <20210825092116.149975-1-wangkefeng.wang@huawei.com> <20210825092116.149975-5-wangkefeng.wang@huawei.com> <99daf260-76af-8316-fa9a-a649c8a8d1ab@huawei.com> In-Reply-To: <99daf260-76af-8316-fa9a-a649c8a8d1ab@huawei.com> From: Marco Elver Date: Wed, 25 Aug 2021 11:59:04 +0200 Message-ID: Subject: Re: [PATCH 4/4] mm: kfence: Only load kfence_test when kfence is enabled To: Kefeng Wang Cc: Alexander Potapenko , Russell King , Dmitry Vyukov , Linux ARM , LKML , kasan-dev , Andrew Morton X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_025917_432552_470E251D X-CRM114-Status: GOOD ( 17.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 25 Aug 2021 at 11:55, Kefeng Wang wrote: > On 2021/8/25 17:31, Alexander Potapenko wrote: > > On Wed, Aug 25, 2021 at 11:17 AM Kefeng Wang wrote: > >> Provide kfence_is_enabled() helper, only load kfence_test module > >> when kfence is enabled. > > What's wrong with the current behavior? > > I think we need at least some way to tell the developer that KFENCE > > does not work, and a failing test seems to be the perfect one. > > If the kfence is not enabled, eg kfence.sample_interval=0, kfence_test > spend too much time, > > and all tests will fails. It is meaningless. so better to just skip it ;) But what is your usecase? I'd like to avoid the export of a new function that is pretty much unused. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel