From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E732C433F5 for ; Tue, 21 Dec 2021 12:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i5Se6xgmoUfy/j9cpodjMyJ1d9CxXHl+lkFZqA1X0ig=; b=R/5re7yqsTpcSt GJWh4vCwfK9RvPeg0ia8yu4vOVFMiPUywpzJz2oWLg877GBoB63dqULA9JVjMgW5Tohh9fl+w8xhQ bxRXXP+WfKtkH39/TRlkfcw/5+5CCUlLmWX54xjmeO+efCNGOHnNvYATmx3oPm0PRpAMBzPMNeRT/ FsH4B4N4/TV4K0jxFgfEBUIRy7FXykoWdoeFdL8mB8SHLRaeyA6iMrNbuRZKcJielX7z7FYEVCJKB OPMZlTFMeZvbHYr2Y8DZTyY06IMXqQt/mJXRPOIUKTNP3JzPqPiw4JDV6kzmrOrlXgTj6vCyR7gJ9 Sygx0WpXmw+fA+Wvqf8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mze7e-006kkE-Qg; Tue, 21 Dec 2021 12:20:02 +0000 Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mze7a-006kiZ-HQ for linux-arm-kernel@lists.infradead.org; Tue, 21 Dec 2021 12:19:59 +0000 Received: by mail-oi1-x22b.google.com with SMTP id v6so2030434oib.13 for ; Tue, 21 Dec 2021 04:19:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BaXR+Sf/o4pHq2K7zFqOPHm0HQk54kBEfN6/GC5fgeM=; b=DOY8PDnOLcMR8fY8k4rMeFeCw7xBBFK3OPAE/n+xtb8qDFv9JkNk3LZbYjMxSp9Kr/ LN+Kgfkxy81v9dusGxkmzUFNm8E70Ly1GdWreagXAuCygdufarJbRI0BYaGpKjyNtKVm fcs6Nr4Dx4+k2Ft9cxJL8HkFmQSBrjkGt7mRlv+ODuxymPHHSAKkyo+d65Q5ur8dZtuR c5pim4OMXxIgsJJmBOFqJJe6VYugNfMHha7zuSla8xEq1khHiCctmEw6R2vpPUfoR/0z MLWB1XzrewUW/h8hIweXJDtWOqIalVXR+sc4Ky4KTcKSYKVVmRi3Oio8WbCCUpw3w2xb 5VRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BaXR+Sf/o4pHq2K7zFqOPHm0HQk54kBEfN6/GC5fgeM=; b=yRLGgHA3LFl2oOkni3od5N5VQbuS9F7ezOHqBIK1lhRuoFSxse+XEfbZPfzvzWj0yt XTBeQtGpxirQXLC1kLRQrb8Llns7l5SlHoMHl80gYKk0vtkAPO4GVN2pIdOPsX34dGIF uXY2G1Vt4bFuAIdQV8cSr4s464mCEgXIB76XOPM03o2q1k0JZAFVv6Mthn/vEoAJrHnj VCv+EaFX0rkATi27X9HtB+sWcJZSBoEdmMMaFoQ+2Ga1+chpNk6GfzgECDdaEI+tC5eR gGyKZ750SLroHDr1Aj3sGINPnh+O+/CWw6kF6Zb8YSo6ArEi9ktMTxewWpcMakLEgIhU Dvgg== X-Gm-Message-State: AOAM532Yvqwp8AowlOsHCBmTmDzqakpdTtpo2f2GPQbYR1PtCgiYyKdX cWgzpH8Jsgafjd9Sz73wOuYbtbCp+uAxxrXaITBnGA== X-Google-Smtp-Source: ABdhPJxBX/Gkn5yNgs1quOEw+mGlZ7jRH4P8oW8i+xSqTHpBDQPz/PzlNjgclCi6wHGOYn03vA+wj3XaqwTIXkiJN/g= X-Received: by 2002:a05:6808:1903:: with SMTP id bf3mr2240565oib.7.1640089196762; Tue, 21 Dec 2021 04:19:56 -0800 (PST) MIME-Version: 1.0 References: <73a0b47ec72a9c29e0efc18a9941237b3b3ad736.1640036051.git.andreyknvl@google.com> In-Reply-To: From: Marco Elver Date: Tue, 21 Dec 2021 13:19:45 +0100 Message-ID: Subject: Re: [PATCH mm v4 28/39] kasan, page_alloc: allow skipping unpoisoning for HW_TAGS To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrew Morton , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, Peter Collingbourne , Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211221_041958_601850_7240779A X-CRM114-Status: GOOD ( 13.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 21 Dec 2021 at 13:14, Marco Elver wrote: > > On Mon, Dec 20, 2021 at 11:02PM +0100, andrey.konovalov@linux.dev wrote: > [...] > > +static inline bool should_skip_kasan_unpoison(gfp_t flags, bool init_tags) > > +{ > > + /* Don't skip if a software KASAN mode is enabled. */ > > + if (IS_ENABLED(CONFIG_KASAN_GENERIC) || > > + IS_ENABLED(CONFIG_KASAN_SW_TAGS)) > > + return false; > > + > > + /* Skip, if hardware tag-based KASAN is not enabled. */ > > + if (!kasan_hw_tags_enabled()) > > + return true; > > Same question here: why is IS_ENABLED(CONFIG_KASAN_{GENERIC,SW_TAGS}) > check required if kasan_hw_tags_enabled() is always false if one of > those is configured? Hmm, I pattern-matched too quickly. In this case there's probably no way around it because the return value is different, so not exactly like the should_skip_init(). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel