From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8A08C4360F for ; Tue, 2 Apr 2019 21:24:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5C362075E for ; Tue, 2 Apr 2019 21:24:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jgmTYfms"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="Ie4bQWsy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5C362075E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y+QaBX/u/l9UmNxec+eaxtEjRh2c/rrfYN4a8e2GwOk=; b=jgmTYfmslXu3sL 4Ms8Wof5gYKRIQ0rE8R1x+loGkSP2QKWs3b3x6q6WH3ERWzQsJ6ADEIxPvVp7sRE2UqrfBSz5kJ8w 7HeXvy41VbXaHnpJjNfg0tQnwXFQXoYC5u9U26EPvyn0+xIIa/frjw+L3z3Ap4dGaV8a2QCJqGBVD EeLuMXTtjM87fiIcvAqUTziMzdW9ASL7O0qygLoGs3bCiFIROv40R6OF3AWl8nTnKpNUZXP3aAlww 670/UuuGYz6P7QSPSdVUslumlfKPvRxQMFdUiyZEqMTTqgbgqNZUo8UB7vFLEbuFJTWTmvCzUNDM2 jPjOaIrSgLoMzjlMTbeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBQtj-0007DA-VK; Tue, 02 Apr 2019 21:24:47 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBQtg-0007CI-DB for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2019 21:24:45 +0000 Received: by mail-pg1-x541.google.com with SMTP id v12so7193639pgq.1 for ; Tue, 02 Apr 2019 14:24:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bkGQE13GsdWKLOaw1fQZ4yp5t1Jwweb12JetTyoT95g=; b=Ie4bQWsyRA5nCrRG/T244BrMSLw9Xw1X/ipBKi8zbzuEJgCyPmMq+eCXWKmkHriQqt TDAtm24hckOUcG1/g0T4X4qOcD3Nwhu0pquimbUFdtOkgAZyiOPH47Q7HKkXPGyUfBrM 2yK5yhklU6Kd0J/WEK87NjO9PI63UbIPqBNZWyRI3lx36S8jljnHiiuOKywxhR25lJUi EWVMR/RQjyzLpsTlyNjeQEV4u0ldG/Z4jRP1sV73An3N1P4uLeXmafiFNtmzULy5JuqL WtDjOR99h4D9Dzxzk/Ry6eE4Zx76loF2XDuIwQ0ERqd7V9sOZ03Cs90a7yTxqs0QssEC EvtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bkGQE13GsdWKLOaw1fQZ4yp5t1Jwweb12JetTyoT95g=; b=R981QKDpa6FXJU04v0BNO/xlHYBqOOt+p5N8gsiPTih/jDdABQEL7tYoLdfx5N6z7O WssWVt4IRXrsuyaskR7w0pvJrVfzJHm0KOT0z85KyyzE4jzS99KvpjJCGTarlKxVAV8M 8rmRXXDClQN14ARfUQTuU6kXul5F8mVPGr+Cparjy9tYv1iYy7HWUkd1FmbGl7LgaS2t BcsKxlje4n/cXnhBfzE/xaXalbjM68nDWz2HjWVnkjVNTSUaYalGo97sbdaX+2N+5way 4mnS7UbAi4qx+eeuKVQw1OLrnaznmyALJzO4cicwF0TJxTGJhOu0Z9HuVrtH7Q8Hpb62 yiGA== X-Gm-Message-State: APjAAAV8/iSpePOnTeXyJQtZLF8BA4ZtR/45FurFLpaBE73xb4PQ2HOa qhZgjXfKUv1Y9AS8Wsmj2YwPmMiToRBI90FGjfw58K8onDc= X-Google-Smtp-Source: APXvYqwZQ7n+paBvBR6wM+KWwQkbMjXi9aFcieJwOT4vUYxhMNV0YPOS3ocfS0fNnP2KqqiL39nlJ8TRn9xkHqWxX2Q= X-Received: by 2002:a62:61c2:: with SMTP id v185mr20217596pfb.117.1554240281133; Tue, 02 Apr 2019 14:24:41 -0700 (PDT) MIME-Version: 1.0 References: <20190329151025.204094-1-venture@google.com> In-Reply-To: From: Patrick Venture Date: Tue, 2 Apr 2019 14:24:29 -0700 Message-ID: Subject: Re: [PATCH v8 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support To: Andrew Jeffery X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_142444_475234_4CF11865 X-CRM114-Status: GOOD ( 25.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Rob Herring , Greg Kroah-Hartman , Linux Kernel Mailing List , Rob Herring , Joel Stanley , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 1, 2019 at 8:42 PM Andrew Jeffery wrote: > > Hi Patrick, > > I held off on reviewing this until we'd hashed out what we needed in the driver. > > I have some comments below. > > On Sat, 30 Mar 2019, at 01:40, Patrick Venture wrote: > > Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. > > > > Signed-off-by: Patrick Venture > > Reviewed-by: Rob Herring > > --- > > Changes for v8: > > - None > > Changes for v7: > > - Moved node under the syscon node it requires > > Changes for v6: > > - None > > Changes for v5: > > - None > > Changes for v4: > > - None > > Changes for v3: > > - None > > Changes for v2: > > - Added comment about syscon required parameter. > > --- > > .../bindings/misc/aspeed-p2a-ctrl.txt | 48 +++++++++++++++++++ > > 1 file changed, 48 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt > > > > diff --git a/Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt > > b/Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt > > new file mode 100644 > > index 0000000000000..088cc4e3dc54b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt > > @@ -0,0 +1,48 @@ > > +====================================================================== > > +Device tree bindings for Aspeed AST2400/AST2500 PCI-to-AHB Bridge > > Control Driver > > +====================================================================== > > + > > +The bridge is available on platforms with the VGA enabled on the > > Aspeed device. > > +In this case, the host has access to a 64KiB window into all of the > > BMC's > > +memory. The BMC can disable this bridge. If the bridge is enabled, > > the host > > +has read access to all the regions of memory, however the host only > > has read > > +and write access depending on a register controlled by the BMC. > > + > > +Required properties: > > +=================== > > + > > + - compatible: must be one of: > > + - "aspeed,ast2400-p2a-ctrl" > > + - "aspeed,ast2500-p2a-ctrl" > > + > > + - syscon: handle to syscon device node controlling PCI. > > The p2a-ctrl node is meant to be a child of the syscon. I noted this in my review > of the associated driver - you need to remove the description of the syscon > property. Roger that, I'll take a hack at cleaning this up later this week (I'm OOO). > > > + > > +Optional properties: > > +=================== > > + > > +- memory-region: A phandle to a reserved_memory region to be used for > > the PCI > > + to AHB mapping > > + > > +The p2a-control node should be the child of a syscon node with the > > required > > +property: > > + > > +- compatible : Should be one of the following: > > + "aspeed,ast2400-scu", "syscon", "simple-mfd" > > + "aspeed,g4-scu", "syscon", "simple-mfd" > > + "aspeed,ast2500-scu", "syscon", "simple-mfd" > > + "aspeed,g5-scu", "syscon", "simple-mfd" > > The note above should go where you've described the syscon property above. > > Cheers, > > Andrew > > > + > > +Example: > > + > > +g4 Example > > +---------- > > + > > +syscon: scu@1e6e2000 { > > + compatible = "aspeed,ast2400-scu", "syscon", "simple-mfd"; > > + reg = <0x1e6e2000 0x1a8>; > > + > > + p2a: p2a-control { > > + compatible = "aspeed,ast2400-p2a-ctrl"; > > + memory-region = <&reserved_memory>; > > + }; > > +}; > > -- > > 2.21.0.392.gf8f6787159e-goog > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel