* [PATCH v5] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property
@ 2017-10-26 15:25 Marco Franchi
2017-10-26 18:10 ` Fabio Estevam
2017-11-16 7:36 ` Shawn Guo
0 siblings, 2 replies; 6+ messages in thread
From: Marco Franchi @ 2017-10-26 15:25 UTC (permalink / raw)
To: linux-arm-kernel
The following build warning is seen with W=1:
Warning (unit_address_vs_reg): Node /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has a unit name, but no reg property
Fix this warning by adding reg property from such node and, consequently,
includes a mdio node into the fec node, with the 'address-cells' and
'size-cells' to avoid these other following warnings:
Warning (reg_format): "reg" property in /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0
Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0
Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
---
Change since v4:
-pass the 'address-cells' and 'size-cells' values using a mdio node
-change message log
arch/arm/boot/dts/imx53-tx53.dtsi | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
index 71b58b6..a22e461 100644
--- a/arch/arm/boot/dts/imx53-tx53.dtsi
+++ b/arch/arm/boot/dts/imx53-tx53.dtsi
@@ -225,10 +225,16 @@
mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */
status = "okay";
- phy0: ethernet-phy at 0 {
- interrupt-parent = <&gpio2>;
- interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
- device_type = "ethernet-phy";
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ phy0: ethernet-phy at 0 {
+ reg = <0>;
+ interrupt-parent = <&gpio2>;
+ interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
+ device_type = "ethernet-phy";
+ };
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v5] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property
2017-10-26 15:25 [PATCH v5] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property Marco Franchi
@ 2017-10-26 18:10 ` Fabio Estevam
2017-11-02 8:18 ` Lothar Waßmann
2017-11-16 7:36 ` Shawn Guo
1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2017-10-26 18:10 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 26, 2017 at 1:25 PM, Marco Franchi <marco.franchi@nxp.com> wrote:
> The following build warning is seen with W=1:
>
> Warning (unit_address_vs_reg): Node /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has a unit name, but no reg property
>
> Fix this warning by adding reg property from such node and, consequently,
> includes a mdio node into the fec node, with the 'address-cells' and
> 'size-cells' to avoid these other following warnings:
>
> Warning (reg_format): "reg" property in /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0
>
> Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
Lothar, could you please test it?
> ---
> Change since v4:
> -pass the 'address-cells' and 'size-cells' values using a mdio node
> -change message log
> arch/arm/boot/dts/imx53-tx53.dtsi | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
> index 71b58b6..a22e461 100644
> --- a/arch/arm/boot/dts/imx53-tx53.dtsi
> +++ b/arch/arm/boot/dts/imx53-tx53.dtsi
> @@ -225,10 +225,16 @@
> mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */
> status = "okay";
>
> - phy0: ethernet-phy at 0 {
> - interrupt-parent = <&gpio2>;
> - interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
> - device_type = "ethernet-phy";
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + phy0: ethernet-phy at 0 {
> + reg = <0>;
> + interrupt-parent = <&gpio2>;
> + interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
> + device_type = "ethernet-phy";
> + };
> };
> };
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v5] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property
2017-10-26 18:10 ` Fabio Estevam
@ 2017-11-02 8:18 ` Lothar Waßmann
2017-11-02 13:38 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Lothar Waßmann @ 2017-11-02 8:18 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Thu, 26 Oct 2017 16:10:54 -0200 Fabio Estevam wrote:
> On Thu, Oct 26, 2017 at 1:25 PM, Marco Franchi <marco.franchi@nxp.com> wrote:
> > The following build warning is seen with W=1:
> >
> > Warning (unit_address_vs_reg): Node /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has a unit name, but no reg property
> >
> > Fix this warning by adding reg property from such node and, consequently,
> > includes a mdio node into the fec node, with the 'address-cells' and
> > 'size-cells' to avoid these other following warnings:
> >
> > Warning (reg_format): "reg" property in /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> > Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0
> > Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0
> >
> > Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
>
> Lothar, could you please test it?
>
> > ---
> > Change since v4:
> > -pass the 'address-cells' and 'size-cells' values using a mdio node
> > -change message log
> > arch/arm/boot/dts/imx53-tx53.dtsi | 14 ++++++++++----
> > 1 file changed, 10 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
> > index 71b58b6..a22e461 100644
> > --- a/arch/arm/boot/dts/imx53-tx53.dtsi
> > +++ b/arch/arm/boot/dts/imx53-tx53.dtsi
> > @@ -225,10 +225,16 @@
> > mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */
> > status = "okay";
> >
> > - phy0: ethernet-phy at 0 {
> > - interrupt-parent = <&gpio2>;
> > - interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
> > - device_type = "ethernet-phy";
> > + mdio {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + phy0: ethernet-phy at 0 {
> > + reg = <0>;
> > + interrupt-parent = <&gpio2>;
> > + interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
> > + device_type = "ethernet-phy";
> > + };
> > };
> > };
> >
> > --
> > 2.7.4
> >
>
Tested-by: <LW@karo-electronics.de>
Acked-by: <LW@karo-electronics.de>
Lothar Wa?mann
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v5] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property
2017-11-02 8:18 ` Lothar Waßmann
@ 2017-11-02 13:38 ` Fabio Estevam
2017-11-02 14:52 ` Lothar Waßmann
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2017-11-02 13:38 UTC (permalink / raw)
To: linux-arm-kernel
Hi Lothar,
On Thu, Nov 2, 2017 at 6:18 AM, Lothar Wa?mann <LW@karo-electronics.de> wrote:
> Tested-by: <LW@karo-electronics.de>
> Acked-by: <LW@karo-electronics.de>
Thanks for testing and acking.
It seems you missed to add your name into the tags and what you meant
to say was:
Tested-by: Lothar Wa?mann <LW@karo-electronics.de>
Acked-by: Lothar Wa?mann <LW@karo-electronics.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v5] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property
2017-11-02 13:38 ` Fabio Estevam
@ 2017-11-02 14:52 ` Lothar Waßmann
0 siblings, 0 replies; 6+ messages in thread
From: Lothar Waßmann @ 2017-11-02 14:52 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Thu, 2 Nov 2017 11:38:49 -0200 Fabio Estevam wrote:
> Hi Lothar,
>
> On Thu, Nov 2, 2017 at 6:18 AM, Lothar Wa?mann <LW@karo-electronics.de> wrote:
>
> > Tested-by: <LW@karo-electronics.de>
> > Acked-by: <LW@karo-electronics.de>
>
> Thanks for testing and acking.
>
> It seems you missed to add your name into the tags and what you meant
> to say was:
>
> Tested-by: Lothar Wa?mann <LW@karo-electronics.de>
> Acked-by: Lothar Wa?mann <LW@karo-electronics.de>
>
Yes, of course. It was too early in the morning...
Lothar Wa?mann
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v5] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property
2017-10-26 15:25 [PATCH v5] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property Marco Franchi
2017-10-26 18:10 ` Fabio Estevam
@ 2017-11-16 7:36 ` Shawn Guo
1 sibling, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2017-11-16 7:36 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 26, 2017 at 01:25:14PM -0200, Marco Franchi wrote:
> The following build warning is seen with W=1:
>
> Warning (unit_address_vs_reg): Node /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has a unit name, but no reg property
>
> Fix this warning by adding reg property from such node and, consequently,
> includes a mdio node into the fec node, with the 'address-cells' and
> 'size-cells' to avoid these other following warnings:
>
> Warning (reg_format): "reg" property in /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0
>
> Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-16 7:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-26 15:25 [PATCH v5] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property Marco Franchi
2017-10-26 18:10 ` Fabio Estevam
2017-11-02 8:18 ` Lothar Waßmann
2017-11-02 13:38 ` Fabio Estevam
2017-11-02 14:52 ` Lothar Waßmann
2017-11-16 7:36 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).