Re: [PATCH 4/4] arm64: dts: imx93-11x11-evk: enable usb and typec nodes

From: Fabio Estevam <festevam@gmail.com>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org,  shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	 linux-imx@nxp.com, devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] arm64: dts: imx93-11x11-evk: enable usb and typec nodes
Date: Thu, 14 Dec 2023 08:25:05 -0300	[thread overview]
Message-ID: <CAOMZO5AXB8h6+fqPO3aCsa1=-etRzPMZSLn7Kca6egUmUX822Q@mail.gmail.com> (raw)
In-Reply-To: <20231214112442.2412079-4-xu.yang_2@nxp.com>

On Thu, Dec 14, 2023 at 8:19 AM Xu Yang <xu.yang_2@nxp.com> wrote:
>
> There are 2 Type-C ports and 2 USB controllers on i.MX93. Enable them.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 108 ++++++++++++++++++
>  1 file changed, 108 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> index 2b9d47716f75..42b1ea7d5220 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> @@ -5,6 +5,7 @@
>
>  /dts-v1/;
>
> +#include <dt-bindings/usb/pd.h>
>  #include "imx93.dtsi"
>
>  / {
> @@ -103,6 +104,70 @@ &mu2 {
>         status = "okay";
>  };
>
> +&lpi2c3 {
> +       #address-cells = <1>;
> +       #size-cells = <0>;
> +       clock-frequency = <400000>;
> +       pinctrl-names = "default", "sleep";
> +       pinctrl-0 = <&pinctrl_lpi2c3>;
> +       pinctrl-1 = <&pinctrl_lpi2c3>;
> +       status = "okay";
> +
> +       ptn5110: tcpc@50 {
> +               compatible = "nxp,ptn5110";
> +               reg = <0x50>;
> +               interrupt-parent = <&gpio3>;
> +               interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
> +               status = "okay";
> +
> +               port {
> +                       typec1_dr_sw: endpoint {
> +                               remote-endpoint = <&usb1_drd_sw>;
> +                       };
> +               };
> +
> +               typec1_con: connector {
> +                       compatible = "usb-c-connector";
> +                       label = "USB-C";
> +                       power-role = "dual";
> +                       data-role = "dual";
> +                       try-power-role = "sink";
> +                       source-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
> +                       sink-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)
> +                                    PDO_VAR(5000, 20000, 3000)>;
> +                       op-sink-microwatt = <15000000>;
> +                       self-powered;

Your patch introduce dt-schema warnings.

Port should be placed under connector as per nxp,ptn5110.yaml.

Please check:
https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?h=for-next&id=de0bae0b75f288381746bb9f6d6fd1b30f397975

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel