[PATCH] clk: mxs: Register USB clocks for mx23

[PATCH] clk: mxs: Register USB clocks for mx23

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Register USB clocks for mx23.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/clk/mxs/clk-imx23.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/clk/mxs/clk-imx23.c b/drivers/clk/mxs/clk-imx23.c
index f7be225..4735136 100644
--- a/drivers/clk/mxs/clk-imx23.c
+++ b/drivers/clk/mxs/clk-imx23.c
@@ -195,6 +195,8 @@ int __init mx23_clocks_init(void)
 	clk_register_clkdevs(clks[ssp], ssp_lookups, ARRAY_SIZE(ssp_lookups));
 	clk_register_clkdevs(clks[gpmi], gpmi_lookups, ARRAY_SIZE(gpmi_lookups));
 	clk_register_clkdevs(clks[lcdif], lcdif_lookups, ARRAY_SIZE(lcdif_lookups));
+	clk_register_clkdev(clks[usb_pwr], NULL, "8007c000.usbphy");
+	clk_register_clkdev(clks[usb], NULL, "80080000.usb");
 
 	for (i = 0; i < ARRAY_SIZE(clks_init_on); i++)
 		clk_prepare_enable(clks[clks_init_on[i]]);
-- 
1.7.1

[PATCH] clk: mxs: Register USB clocks for mx23

[Shawn Guo]

On Tue, Jun 19, 2012 at 08:26:32PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Register USB clocks for mx23.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/clk/mxs/clk-imx23.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/clk/mxs/clk-imx23.c b/drivers/clk/mxs/clk-imx23.c
> index f7be225..4735136 100644
> --- a/drivers/clk/mxs/clk-imx23.c
> +++ b/drivers/clk/mxs/clk-imx23.c
> @@ -195,6 +195,8 @@ int __init mx23_clocks_init(void)
>  	clk_register_clkdevs(clks[ssp], ssp_lookups, ARRAY_SIZE(ssp_lookups));
>  	clk_register_clkdevs(clks[gpmi], gpmi_lookups, ARRAY_SIZE(gpmi_lookups));
>  	clk_register_clkdevs(clks[lcdif], lcdif_lookups, ARRAY_SIZE(lcdif_lookups));
> +	clk_register_clkdev(clks[usb_pwr], NULL, "8007c000.usbphy");
> +	clk_register_clkdev(clks[usb], NULL, "80080000.usb");

It depends on the node name in device tree.  I would defer this
a little bit to have the node name in dts settled down first.

Regards,
Shawn

>  
>  	for (i = 0; i < ARRAY_SIZE(clks_init_on); i++)
>  		clk_prepare_enable(clks[clks_init_on[i]]);
> -- 
> 1.7.1
> 

[PATCH] clk: mxs: Register USB clocks for mx23

[Fabio Estevam]

On Wed, Jun 20, 2012 at 11:38 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
...
>> +     clk_register_clkdev(clks[usb_pwr], NULL, "8007c000.usbphy");
>> +     clk_register_clkdev(clks[usb], NULL, "80080000.usb");
>
> It depends on the node name in device tree.  I would defer this
> a little bit to have the node name in dts settled down first.

Now that the mxs usb driver is in mainline, could this patch be applied?

Regards,

Fabio Estevam

[PATCH] clk: mxs: Register USB clocks for mx23

[Shawn Guo]

On Sun, Aug 05, 2012 at 02:08:07PM -0300, Fabio Estevam wrote:
> On Wed, Jun 20, 2012 at 11:38 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> ...
> >> +     clk_register_clkdev(clks[usb_pwr], NULL, "8007c000.usbphy");
> >> +     clk_register_clkdev(clks[usb], NULL, "80080000.usb");
> >
> > It depends on the node name in device tree.  I would defer this
> > a little bit to have the node name in dts settled down first.
> 
> Now that the mxs usb driver is in mainline, could this patch be applied?
> 
Probably, no, as I plan to freeze the addition to clkdev lookup table
and replace it with DT clock lookup.

-- 
Regards,
Shawn

[PATCH] clk: mxs: Register USB clocks for mx23

[Fabio Estevam]

Shawn,

On Mon, Aug 6, 2012 at 12:00 AM, Shawn Guo <shawn.guo@linaro.org> wrote:

> Probably, no, as I plan to freeze the addition to clkdev lookup table
> and replace it with DT clock lookup.

Could you please suggest how can I register the USB clocks for mx23?
Any example I can refer to implement a "DT clock lookup"?

Regards,

Fabio Estevam

[PATCH] clk: mxs: Register USB clocks for mx23

[Fabio Estevam]

Shawn,

On Mon, Aug 13, 2012 at 12:06 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Shawn,
>
> On Mon, Aug 6, 2012 at 12:00 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
>
>> Probably, no, as I plan to freeze the addition to clkdev lookup table
>> and replace it with DT clock lookup.
>
> Could you please suggest how can I register the USB clocks for mx23?
> Any example I can refer to implement a "DT clock lookup"?

Ping?

I saw some patches from you that changes the way dt clocks are
registered for mx23/mx28, but not sure if these were applied or not.

Please let me know how should I proceed regarding mx23 usb clocks registration.

Regards,

Fabio Estevam

[PATCH] clk: mxs: Register USB clocks for mx23

[Shawn Guo]

On Thu, Aug 30, 2012 at 11:09:49AM -0300, Fabio Estevam wrote:
> Shawn,
> 
> On Mon, Aug 13, 2012 at 12:06 AM, Fabio Estevam <festevam@gmail.com> wrote:
> > Shawn,
> >
> > On Mon, Aug 6, 2012 at 12:00 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> >
> >> Probably, no, as I plan to freeze the addition to clkdev lookup table
> >> and replace it with DT clock lookup.
> >
> > Could you please suggest how can I register the USB clocks for mx23?
> > Any example I can refer to implement a "DT clock lookup"?
> 
> Ping?
> 
> I saw some patches from you that changes the way dt clocks are
> registered for mx23/mx28, but not sure if these were applied or not.
> 
The v2 patch solving Russell's comment has been acked by Rob.  I'm
waiting for Mike to apply it, and then I can publish a mxs branch
based on that.

> Please let me know how should I proceed regarding mx23 usb clocks registration.
> 
> Regards,
> 
> Fabio Estevam

-- 
Regards,
Shawn