From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58797C433DB for ; Tue, 22 Dec 2020 18:00:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0ED7F2242A for ; Tue, 22 Dec 2020 18:00:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0ED7F2242A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hy21e5+Wu3Xoz49mnkibxrdso6eKDsvAcuGrJPuynAg=; b=r5UExxkdtdmS0/pY1OaiKiEVv l/UTg179qYvReiv0PZlXxVFYSXD9+53D4etK5Y5W7Lw6NAhajScvyfKPlRhsqOqTw3ykQ5DIby+lJ TlbrPnqgL+tYomOlKdBy2G6CH7a0GrDxhDFXDw7T81FbV1YSU3NS/kUI+Brj+DFAaMhsxss7Czpll QqvHX5x9tGKp+5whH3oGcBJLoVvmBcXrPVAas1OprDFNaIqxhdfToErhmRaDnLHkF37TCzt2ZuE15 ZZLCdFtt9wZJrf42HnRu+US7xCIOwz3zdjbfNxF8w2q+UVr3AmCId8ekPHiYel/49JfdwdOzdwKiL 9vhKP0Dpw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krlvo-0001JM-Mu; Tue, 22 Dec 2020 17:58:44 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krlvl-0001It-4i for linux-arm-kernel@lists.infradead.org; Tue, 22 Dec 2020 17:58:42 +0000 Received: by mail-lf1-x12f.google.com with SMTP id s26so33931895lfc.8 for ; Tue, 22 Dec 2020 09:58:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PfXAXQ8kBE2vb/nUDtD4To0JchlXyJ1Qy383TUCdL5w=; b=bUt7/Ewoudd8Ppjf+R80lF3XO9mPK8pM3OhJPkyh7wcro70W1s2ps19o+kAMZu9Bo5 IamxHUDH1WQg7+353HzRyVnc84N3pGo1MkoWpdqQq2S/gGSvvU+VBQDQ1ZWH6IS9yvJx uCPKZLZSOVX8lWdf3X4efSbHJb0LTFWLs69HHKjITTfrzqi/CSI38LH4wOt9kG8S9ldD oqfc84awKOYe35uJWz33WRhGOv7p/UHi4pqaho4F7vvfb899441quA9DJVWo+Zjt8uCT duCf3wDNI03Me+YoKe3sx4tBTiIH7N9py30uqYdRqCRgbknlP+0gaXWoUUgunOAx/lsp CRLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PfXAXQ8kBE2vb/nUDtD4To0JchlXyJ1Qy383TUCdL5w=; b=DXMwRtkYYM/8qsZnq+3/pj21sI5PS7blJ4W+5QsdSWTp5zMRpwO5rbTgkP9qIbkLPO rbngBv+z76iH478NUCuZdboDZun2A4YApkfaIHq4LlAm8XJ22g2wI/+hsafFSMpfCUC7 w22oDBHn5Ayl4oOQP8S65jXx23455wC6seQ0uO7f76Kxh0nSr5PUqdoJp/AQsZpmrj0v nSSNQUX+7E5doDe1lVuHjZKLWQpqBLN7uODQ9LNGLF6+n+agZXA/Jr+xytzUOo4Oo+vN xxupsnR4P+jRTDG0jKIVbdV5vZRWoFwcBvfyurk3YYP0EQL/6izZYG3hre+oEnoAAP5G iRXA== X-Gm-Message-State: AOAM5309wohV/wLKXyBsp60C0Qq/qNMzIXKd7hEy3kdD7PjNRGKsfoyk 1T5WUqa5JWm9XEpJyml5uc3p88YDJ9qqfPmkrc4= X-Google-Smtp-Source: ABdhPJxiMPW/bFl10CagAVMyf3CW3+lHjSBLbEcXhJeid36YohxQ09gShY8vDKRMIFXxt/2lq/4zLFC9vZRuRgXvJWw= X-Received: by 2002:ac2:4431:: with SMTP id w17mr8772863lfl.223.1608659918710; Tue, 22 Dec 2020 09:58:38 -0800 (PST) MIME-Version: 1.0 References: <20201125161815.2361-1-lukma@denx.de> <20201125161815.2361-3-lukma@denx.de> In-Reply-To: <20201125161815.2361-3-lukma@denx.de> From: Fabio Estevam Date: Tue, 22 Dec 2020 14:58:27 -0300 Message-ID: Subject: Re: [PATCH 3/3] ARM: dts: imx28: Add DTS description of imx28 based XEA board To: Lukasz Majewski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201222_125841_230051_FF098A64 X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sascha Hauer , linux-kernel , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Lukasz, On Wed, Nov 25, 2020 at 1:19 PM Lukasz Majewski wrote: > diff --git a/arch/arm/boot/dts/imx28-lwe.dtsi b/arch/arm/boot/dts/imx28-lwe.dtsi > new file mode 100644 > index 000000000000..cb2eb4377d9c > --- /dev/null > +++ b/arch/arm/boot/dts/imx28-lwe.dtsi > @@ -0,0 +1,185 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +/* > + * Copyright 2020 > + * Lukasz Majewski, DENX Software Engineering, lukma@denx.de > + */ > + > +/dts-v1/; > +#include "imx28.dtsi" > + > +/ { > + compatible = "fsl,imx28"; You can drop this one. > + > + aliases { > + spi2 = &ssp3; > + }; > + > + chosen { > + bootargs = "root=/dev/mmcblk0p2 rootfstype=ext4 ro rootwait console=ttyAMA0,115200 panic=1"; You could remove bootargs and let the bootloader pass it. We usually don't pass bootargs in the i.MX dts files. > + }; > + > + memory { memory@40000000 otherwise you will get dtc build warnings with W=1. > + reg = <0x40000000 0x08000000>; > + }; > + > + regulators { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <0>; No need for this 'regulators' container. > + > + reg_3v3: regulator@0 { reg_3v3: regulator-reg-3v3 { > + compatible = "regulator-fixed"; > + reg = <0>; Remove the reg = <0> Same applies to other regulators. > + reg_usb_5v: regulator@1 { > + compatible = "regulator-fixed"; > + reg = <1>; > + regulator-name = "usb_vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + enable-active-high; Why passing 'enable-active-high' when this is not gpio controlled? > + }; > + > + reg_fec_3v3: regulator@2 { > + compatible = "regulator-fixed"; > + reg = <2>; > + regulator-name = "fec-phy"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + enable-active-high; Same here. > +&ssp3 { > + compatible = "fsl,imx28-spi"; > + pinctrl-names = "default"; > + pinctrl-0 = <&spi3_pins_a>; > + status = "okay"; > + > + flash0: s25fl256s0@0 { Node names should be generic flash@0 > + > +/dts-v1/; > +#include "imx28-lwe.dtsi" > + > +/ { > + model = "XEA"; compatible = "xea,imx20-lwe", "fsl,imx28"; You should add xea to the vendor prefix in a separate patch. You also need to add thie board to Documentation/devicetree/bindings/arm/fsl.yaml _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel