From: festevam@gmail.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: video: mxs: Fix mxsfb misconfiguring VDCTRL0
Date: Sat, 16 Mar 2013 19:38:57 -0300 [thread overview]
Message-ID: <CAOMZO5AwD7Q3G+xp9DW0vioZnHZJX538nFeE9F-P+jbHMHPqoQ@mail.gmail.com> (raw)
In-Reply-To: <1363471581-10132-1-git-send-email-marex@denx.de>
On Sat, Mar 16, 2013 at 7:06 PM, Marek Vasut <marex@denx.de> wrote:
> The issue fixed by this patch manifests only then using X11
> with mxsfb driver. The X11 will display either shifted image
> or otherwise distorted image on the LCD.
>
> The problem is that the X11 tries to reconfigure the framebuffer
> and along the way call fb_ops.fb_set_par() with it's configuration
> values. The field of particular interest is fb_info->var.sync which
> contains non-standard values if configured by kernel. These are
> FB_SYNC_DATA_ENABLE_HIGH_ACT and FB_SYNC_DOTCLK_FAILING_ACT defined
> in include/linux/mxsfb.h . The driver interprets those and configures
> the LCD controller accordingly. Yet X11 only has access to standard
> values for this field defined in include/uapi/linux/fb.h and thus
> omits these special values. This results in distorted image on the
> LCD.
>
> This patch moves these non-standard values into new field of the
> mxsfb_platform_data structure so the driver can in turn check this
> field instead of the video mode field for these specific portions.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estavem@freescale.com>
> Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>
> Cc: Linux FBDEV <linux-fbdev@vger.kernel.org>
> Cc: Lothar Wa?mann <LW@karo-electronics.de>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
This fixes the X11 offset issue on my mx28evk, thanks!
Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
next prev parent reply other threads:[~2013-03-16 22:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 20:09 Shifted framebuffer after X11 starts on mx28 Fabio Estevam
2013-03-16 20:55 ` Marek Vasut
2013-03-16 21:00 ` Marek Vasut
2013-03-16 22:06 ` [PATCH] ARM: video: mxs: Fix mxsfb misconfiguring VDCTRL0 Marek Vasut
2013-03-16 22:38 ` Fabio Estevam [this message]
2013-03-18 12:44 ` Shawn Guo
2013-03-18 13:11 ` Fabio Estevam
2013-03-18 13:01 ` Shawn Guo
2013-03-18 13:58 ` Marek Vasut
2013-03-18 14:06 ` Shawn Guo
2013-03-18 14:18 ` Marek Vasut
2013-03-18 14:31 ` Shawn Guo
2013-03-18 15:19 ` Marek Vasut
2013-03-19 5:48 ` Shawn Guo
2013-03-19 10:33 ` Marek Vasut
-- strict thread matches above, loose matches on Subject: below --
2013-03-18 18:23 Marek Vasut
2013-03-18 18:58 ` Greg KH
2013-03-18 21:31 ` Marek Vasut
2013-03-18 22:01 ` Jonathan Nieder
2013-03-18 22:17 ` Marek Vasut
2013-03-18 18:24 Marek Vasut
2013-03-19 5:51 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5AwD7Q3G+xp9DW0vioZnHZJX538nFeE9F-P+jbHMHPqoQ@mail.gmail.com \
--to=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).