From: festevam@gmail.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx35: add iim module to imx35.dtsi
Date: Thu, 8 Sep 2016 15:09:17 -0300 [thread overview]
Message-ID: <CAOMZO5BLJvL3ad5An2n=h0K+15qOZfWDVLbUz+fe_4Mz7NLMXw@mail.gmail.com> (raw)
In-Reply-To: <20160908175546.lvc5qehbekx7s2ty@pengutronix.de>
On Thu, Sep 8, 2016 at 2:55 PM, Uwe Kleine-K?nig
<u.kleine-koenig@pengutronix.de> wrote:
>> Where is "fsl,imx35-iim" defined?
>
> right next to the other fsl,imx*-iim :-)
Ok, "fsl,imx35-iim" is not being used arch/arm/mach-imx/cpu-imx35.c currently.
I suppose you want to replace
"rev = imx_readl(MX35_IO_ADDRESS(MX35_IIM_BASE_ADDR + MXC_IIMSREV));"
by retrieving the base address via dt, like we do in
imx5_read_srev_reg() at arch/arm/mach-imx/cpu-imx5.c.
> By the way, compared to the other imx*.dtsi I didn't declare
> compatibility to fsl,imx27-iim. I checked the i.MX25 reference manual
> and the i.MX35 looked different. Didn't check for imx5x and the i.MX27
> RM doesn't describe the registers. What do you think?
I think this is fine as is, so:
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
next prev parent reply other threads:[~2016-09-08 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 9:28 [PATCH] ARM: imx35: add iim module to imx35.dtsi Uwe Kleine-König
2016-09-08 16:21 ` Fabio Estevam
2016-09-08 17:55 ` Uwe Kleine-König
2016-09-08 18:09 ` Fabio Estevam [this message]
2016-09-08 18:18 ` Uwe Kleine-König
2016-09-09 6:19 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5BLJvL3ad5An2n=h0K+15qOZfWDVLbUz+fe_4Mz7NLMXw@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).