From mboxrd@z Thu Jan 1 00:00:00 1970 From: jean.pihet@newoldbits.com (Jean Pihet) Date: Wed, 12 Dec 2012 11:18:23 +0100 Subject: [PATCH 05/12] ARM: OMAP3xxx: PM: convert to use the functional power states API In-Reply-To: <20121209175312.6933.92995.stgit@dusk.lan> References: <20121209174545.6933.59371.stgit@dusk.lan> <20121209175312.6933.92995.stgit@dusk.lan> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Paul, On Sun, Dec 9, 2012 at 6:53 PM, Paul Walmsley wrote: > From: Jean Pihet > > Use the functional power states as the API to control power domains: > > - use the PWRDM_FUNC_PWRST_* macros for the power states and logic > settings, > > - the function pwrdm_set_next_fpwrst(), which controls the power domains > next power and logic settings, shall be used instead of > pwrdm_set_next_pwrst() to program the power domains next states, > > - the function pwrdm_set_fpwrst(), which programs the power domains > power and logic settings, shall be used instead of > omap_set_pwrdm_state(). > > Signed-off-by: Jean Pihet > [paul at pwsan.com: split the original patch into OMAP2/3/4 variants; > clean up omap3_save_secure_ram_context(); fix commit message; > warn if sets fail; various other changes] > There are a lot of 'XXX' comments, can this be fixed by a proper comment? Regards, Jean > Signed-off-by: Paul Walmsley > --- > arch/arm/mach-omap2/cpuidle34xx.c | 95 ++++++++++++----------- > arch/arm/mach-omap2/pm.h | 2 > arch/arm/mach-omap2/pm34xx.c | 156 > +++++++++++++++++++------------------ > 3 files changed, 130 insertions(+), 123 deletions(-) > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: